Skip to content

fix(api): adapt floating rate form to generated request types - #449

Closed
Whxuan0701 wants to merge 1 commit into
apache:mainfrom
Whxuan0701:fix/448-floating-rate-api
Closed

fix(api): adapt floating rate form to generated request types#449
Whxuan0701 wants to merge 1 commit into
apache:mainfrom
Whxuan0701:fix/448-floating-rate-api

Conversation

@Whxuan0701

Copy link
Copy Markdown

Summary

  • remove the deleted FloatingRateRequest dependency from the floating-rate form
  • derive create and update payload types from the generated service methods
  • keep the form state non-nullable and reject incomplete rate-period rows before submission

Apache Fineract's generated client now exposes separate request models for creating and updating
floating rates. This change keeps the consumer compatible with the current client and with the
model changes introduced by #447, without hand-editing generated files.

Validation

  • npm ci
  • npm run format:check
  • npm run lint
  • npm run api:surface
  • npm run verify-api-client
  • npm run build
  • npm test -- --watch=false --browsers=ChromeHeadless --include=src/app/features/products/floating-rates/floating-rate-form.component.spec.ts
  • npm run build on a temporary worktree containing the generated client from chore(api): sync the Fineract OpenAPI spec #447

The build reports the repository's existing header component style-budget warning. The focused
Karma run passes all 3 tests. The full Vitest command is currently environment-sensitive under
Node 26 because its file-backed localStorage database is shared by parallel workers; with the
workaround, 745 of 746 tests pass and the remaining failure is the SQLite lock in an unrelated
navigation test.

Fixes #448

OpenAI Codex (GPT-5) on behalf of Weihao Xuan (Whxuan0701)

@github-actions

Copy link
Copy Markdown
Contributor

Commits on this pull request are not verified

1 of 1 commit is not showing as Verified on GitHub, so this pull request cannot be merged into main yet.

unsigned

These commits carry no signature at all.

  • abb8d0fa fix(api): adapt floating rate form to generated request types

How to fix: Set up commit signing, then re-sign the commits already on this branch. CONTRIBUTING.md has the setup.

Re-signing

# only for the identity reasons above (no_user / unverified_email):
git config user.email "you@example.com"

# re-sign every commit on this branch:
git rebase --exec 'git commit --amend --no-edit --reset-author -S' origin/main
git push --force-with-lease

Force-pushing is expected here — re-signing rewrites the commits, so their hashes change.


This comment is posted automatically and updates itself when you push; it disappears once every commit verifies. If you believe this is wrong, say so on the pull request — a maintainer can check.

@Aman-Mittal

Copy link
Copy Markdown
Member

Commits on this pull request are not verified

1 of 1 commit is not showing as Verified on GitHub, so this pull request cannot be merged into main yet.

unsigned

These commits carry no signature at all.

  • abb8d0fa fix(api): adapt floating rate form to generated request types

How to fix: Set up commit signing, then re-sign the commits already on this branch. CONTRIBUTING.md has the setup.

Re-signing

# only for the identity reasons above (no_user / unverified_email):
git config user.email "you@example.com"

# re-sign every commit on this branch:
git rebase --exec 'git commit --amend --no-edit --reset-author -S' origin/main
git push --force-with-lease

Force-pushing is expected here — re-signing rewrites the commits, so their hashes change.


This comment is posted automatically and updates itself when you push; it disappears once every commit verifies. If you believe this is wrong, say so on the pull request — a maintainer can check.

Please sign your commits.

@Aman-Mittal

Copy link
Copy Markdown
Member

Closing due to inctivity please recreate PR when you come back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regenerate Open API specs and fix compilation after breaking changes on fineract

2 participants