fix(api): adapt floating rate form to generated request types - #449
fix(api): adapt floating rate form to generated request types#449Whxuan0701 wants to merge 1 commit into
Conversation
Commits on this pull request are not verified1 of 1 commit is not showing as Verified on GitHub, so this pull request cannot be merged into
|
Please sign your commits. |
|
Closing due to inctivity please recreate PR when you come back |
Summary
FloatingRateRequestdependency from the floating-rate formApache Fineract's generated client now exposes separate request models for creating and updating
floating rates. This change keeps the consumer compatible with the current client and with the
model changes introduced by #447, without hand-editing generated files.
Validation
npm cinpm run format:checknpm run lintnpm run api:surfacenpm run verify-api-clientnpm run buildnpm test -- --watch=false --browsers=ChromeHeadless --include=src/app/features/products/floating-rates/floating-rate-form.component.spec.tsnpm run buildon a temporary worktree containing the generated client from chore(api): sync the Fineract OpenAPI spec #447The build reports the repository's existing header component style-budget warning. The focused
Karma run passes all 3 tests. The full Vitest command is currently environment-sensitive under
Node 26 because its file-backed
localStoragedatabase is shared by parallel workers; with theworkaround, 745 of 746 tests pass and the remaining failure is the SQLite lock in an unrelated
navigation test.
Fixes #448
OpenAI Codex (GPT-5) on behalf of Weihao Xuan (Whxuan0701)