Uh oh!
There was an error while loading. Please reload this page.
FINERACT-817: Provide values of entity property for Entity Data Table Checks - #6365
Open
Eyad-Sharkawy wants to merge 1 commit into
Open
FINERACT-817: Provide values of entity property for Entity Data Table Checks#6365Eyad-Sharkawy wants to merge 1 commit into
Eyad-Sharkawy wants to merge 1 commit into
Conversation
Eyad-Sharkawyforce-pushed
the
FINERACT-817-entity-datatable-checks
branch
from
September 1, 2026 21:14
fb89b27 to
6a7445dCompareAuthor
Hi team, the API compatibility check failed because changing the entity field from a String to an EnumOptionData object is a breaking change, as requested in FINERACT-817. How does the Fineract team prefer to handle intentional API contract changes? Should I add a label to bypass this, or preserve the original entity string and add a new field instead? |
Uh oh!
There was an error while loading. Please reload this page.
Eyad-Sharkawyforce-pushed
the
FINERACT-817-entity-datatable-checks
branch
from
September 2, 2026 14:32
bde1c6b to
a812c51Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the Entity Data Table Checks API (
/v1/entityDatatableChecks) only returned the internal table name string for theentityfield (e.g."m_client") instead of structured enum option data containing human-readable display values.This PR addresses FINERACT-817 by:
EntityTablesenum with human-readable display labels (e.g., "Client", "Loan") and adding atoEnumOptionData()method that returnsStringEnumOptionData(id,code,value).entityDataproperty toEntityDataTableChecksDatausingStringEnumOptionDatato provide the structured values to modern clients, while preserving the legacyentitystring property to maintain backward compatibility for existing deployments.EntityDatatableChecksReadPlatformServiceImplto populate the newentityDatafield usingEntityTables.fromEntityName(entity).toEnumOptionData().EntityDatatableChecksApiResourceSwaggerto reflect the newly addedentityDataobject.EntityTablesTestto verify enum option mapping and reverse lookup.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!