Display git build info (FINERACT-883) - #778

Merged
vorburger merged 3 commits into
apache:developfrom
xurror:FINERACT-883
Apr 26, 2020
Merged

Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom
xurror:FINERACT-883

Conversation

@xurror

@xurrorxurror commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Display fineracts git build info actuator/info endpoint

Description

Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

@vorburger

vorburger commented Apr 21, 2020

Copy link
Copy Markdown
Member

@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.

BTW this has nothing to do with FINERACT-905, confusion.

PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).

@xurror

xurror commented Apr 22, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).

Was wondering where it came from. Thanks for the notice

@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.

Looking into it. It's kind of weird rat-report.txt is getting checked for license.

@xurror
xurrorforce-pushed the FINERACT-883 branch 3 times, most recently from eb33555 to 639412dCompareApril 22, 2020 07:24
@xurror

xurror commented Apr 22, 2020

Copy link
Copy Markdown
ContributorAuthor

./gradlew rat passes locally.

@xurrorxurror closed this Apr 22, 2020
@xurrorxurror reopened this Apr 22, 2020
@xurror
xurrorforce-pushed the FINERACT-883 branch 6 times, most recently from c097c8c to bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror closed this Apr 23, 2020
@xurrorxurror reopened this Apr 23, 2020
@xurror
xurrorforce-pushed the FINERACT-883 branch 2 times, most recently from f2eea3a to d9103acCompareApril 25, 2020 06:20
@xurrorxurror changed the title FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror

xurror commented Apr 25, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored

This also fails with docker build.

@xurror

xurror commented Apr 25, 2020

Copy link
Copy Markdown
ContributorAuthor

It's hard for me to figure out how to pull this off.

I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.

@xurrorxurror closed this Apr 25, 2020
@xurrorxurror reopened this Apr 25, 2020
@nikpawar89

nikpawar89 commented Apr 26, 2020

Copy link
Copy Markdown
Member

@xurror i saw the build, in your case following test case is failing:
org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED
java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588

For now may be you want to ignore the the testcase . But definitely it is not a long time solution.
It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.

@vorburgervorburger changed the title Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger reviewed Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle Outdated
vorburger
vorburger reviewed Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle Outdated
vorburger
vorburger reviewed Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle Outdated
@vorburger

vorburger commented Apr 26, 2020

Copy link
Copy Markdown
Member

@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.

Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored

I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...

I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.

... therefore something like that would probably be acceptable / good idea; see FINERACT-911.

However I do not find an option failOnNoDotGitFound so I suspect this was a typo?

vorburger
vorburger requested changes Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle Outdated
@xurror

xurror commented Apr 26, 2020

Copy link
Copy Markdown
ContributorAuthor

@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.

Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored

I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...

I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.

... therefore something like that would probably be acceptable / good idea; see FINERACT-911.

However I do not find an option failOnNoDotGitFound so I suspect this was a typo?

Oops, typo. It's failOnNoGitDirectory.

@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror

xurror commented Apr 26, 2020

Copy link
Copy Markdown
ContributorAuthor

@vorburger, this passes now. Hope the you OK with the actual changes

vorburger
vorburger approved these changes Apr 26, 2020
View reviewed changes

@vorburgervorburger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vorburger
vorburger merged commit 394a7fb into apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Display git build info (FINERACT-883) - #778
Merged
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Apr 26, 2020
Merged
Display git build info (FINERACT-883)#778
vorburger merged 3 commits into
apache:developfrom 
xurror:FINERACT-883
Conversation
@xurror
@xurrorxurror
commented
Apr 21, 2020

Copy link


Copy Markdown

Contributor
Display fineracts git build info actuator/info endpoint
Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
@vorburger
vorburger
commented
Apr 21, 2020

Copy link


Copy Markdown

Member
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
BTW this has nothing to do with FINERACT-905, confusion.
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
@xurror
xurror
commented
Apr 22, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
PS please ignore the failed Build - Summary, and only look at Travis (see FINERACT-907).
Was wondering where it came from. Thanks for the notice
@xurror can you locally run and fix ./gradlew rat ? Some license header is missing.
Looking into it. It's kind of weird rat-report.txt is getting checked for license.
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
3 times, most recently
from
eb33555 to
639412dCompareApril 22, 2020 07:24
@xurror
xurror
commented
Apr 22, 2020

Copy link


Copy Markdown

ContributorAuthor
./gradlew rat passes locally.
@xurrorxurror
closed this
Apr 22, 2020
@xurrorxurror
reopened this
Apr 22, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
6 times, most recently
from
c097c8c to
bcb7ac3CompareApril 23, 2020 08:27
@xurrorxurror
closed this
Apr 23, 2020
@xurrorxurror
reopened this
Apr 23, 2020
@xurror
xurrorforce-pushed
the
FINERACT-883
branch
2 times, most recently
from
f2eea3a to
d9103acCompareApril 25, 2020 06:20
@xurrorxurror
changed the title
FINERACT-883Dispaly git build info(FINERACT-883)Apr 25, 2020
@xurror
xurror
commented
Apr 25, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
This also fails with docker build.
@xurror
xurror
commented
Apr 25, 2020

Copy link


Copy Markdown

ContributorAuthor
It's hard for me to figure out how to pull this off.
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
@xurrorxurror
closed this
Apr 25, 2020
@xurrorxurror
reopened this
Apr 25, 2020
@nikpawar89
nikpawar89
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror i saw the build, in your case following test case is failing:

org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED

java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588
For now may be you want to ignore the the testcase . But definitely it is not a long time solution.

It appears to me a concurrency issue on Loan entity object and is not limited to integration tests.
@vorburgervorburger
changed the title
Dispaly git build info(FINERACT-883)Display git build info (FINERACT-883)Apr 26, 2020
vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

vorburger
vorburger
reviewed
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@vorburger
vorburger
commented
Apr 26, 2020

Copy link


Copy Markdown

Member
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
vorburger
vorburger
requested changes
Apr 26, 2020
View reviewed changes
Comment threadfineract-provider/build.gradle
Outdated

@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@xurror re. test failure, follow #782 to find FINERACT-899 and note #774, I think if you rebase this, that will disappear.
Oh now this interesting. Seems .git directory cannot be found here since it is a file which is automatically ignored
I don't think the .git/is a file which is automatically ignored, but I suspect there are several situations where it's not present... this project certainly should still build even if there is no .git/ directory present. This could happen if someone builds from the Release ZIP, and a few other situations I can imagine...
I'm thinking to set the option failOnNoDotGitFound to false. @vorburger, @awasum do you think we can go with that.
... therefore something like that would probably be acceptable / good idea; see FINERACT-911.
However I do not find an option failOnNoDotGitFound so I suspect this was a typo?
Oops, typo. It's failOnNoGitDirectory.
@xurror
FINERACT-883
7a2c6be
Display fineracts git build info actuator/info endpoint
@xurror
Fix rat reports
5db628d
@xurror
IntegrationTests for git build info
6fbe4ed
@xurror
xurror
commented
Apr 26, 2020

Copy link


Copy Markdown

ContributorAuthor
@vorburger, this passes now. Hope the you OK with the actual changes
vorburger
vorburger
approved these changes
Apr 26, 2020
View reviewed changes
@vorburgervorburger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@vorburger
vorburger
merged commit 394a7fb
into
apache:developApr 26, 2020
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vorburgervorburgervorburger approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@xurror@vorburger@nikpawar89