[FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

[fpompermaier]

What is the purpose of the change

Fix error when handling numeric field types with precision 0, such as:

CREATETABLEorders(
ord_no integerPRIMARY KEY,
ord_date date,
item_name character(35),
item_grade character(1),
ord_qty numeric,
ord_amount numeric,
CONSTRAINT unq_ordno_itname UNIQUE(ord_qty,ord_amount)
);

This address the same problem of SPARK-26538 (apache/spark#23456), using the same fix.

Brief change log

In the PostgresCatalog.fromJDBCType, handle Decimal and Numeric types as follow:

if (precision > 0) {
returnDataTypes.DECIMAL(precision, metadata.getScale(colIndex));
}
returnDataTypes.DECIMAL(DecimalType.MAX_PRECISION, 18);

Verifying this change

This change is already covered by existing tests, such as PostgresCatalogITCase.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not documented

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5246f29 (Sun Apr 26 12:18:02 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 5246f29 Travis: FAILURE Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[wuchong]

cc @bowenli86 , would you like to review this?

[bowenli86]

LGTM, except that can you also add array tests in PostgresCatalogITCase#testArrayTypes()?

[fpompermaier]

@bowenli86 I'll add it within tomorrow hopefully

[fpompermaier]

@flinkbot run travis
@flinkbot run azure

[bowenli86]

@flinkbot run travis

[bowenli86]

LGTM.

BTW, next time, please remember to write jira number and tags in the commit message, e.g. "[FLINK-17385][jdbc][postgres]"