Uh oh!
There was an error while loading. Please reload this page.
[FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg - #14880
[FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg#14880beyond1920 wants to merge 1 commit into
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 72a1f4b (Fri May 28 09:13:36 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
godfreyhe
left a comment
There was a problem hiding this comment.
Thanks for the contribution @beyond1920 , It's better we make sure that the argIndexes is not null when AggregateInfo is created. That we can safely use the argIndexes anywhere.
beyond1920
commented
Apr 19, 2021
@godfreyhe Thanks for the review. I've addressed. |
beyond1920
commented
Apr 19, 2021
@flinkbot run azure |
55ad256 to
ebe907bCompare
godfreyhe
left a comment
There was a problem hiding this comment.
I think we need only make sure the argIndexes is not null when calling transformToAggregateInfo method. if that, there is only one place that needs to be changed.
beyond1920
commented
Apr 21, 2021
@flinkbot run azure |
…verAgg This closesapache#14880 (cherry picked from commit 293739d)
| "5,3", | ||
| "5,4", | ||
| "5,5") | ||
| assertEquals(expected, sink.getAppendResults) |
There was a problem hiding this comment.
No sort here, this case is unstable.
What is the purpose of the change
Fix NPE when use row_number() in over agg.
Brief change log
Minor update in
DeclarativeAggCodeGento take aggregate without parameters into consideration.Verifying this change
ITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation