Uh oh!
There was an error while loading. Please reload this page.
Keep local publish queue; rely on deploy-github-pages@asf for cross-repo races - #175
Merged
Merged
Conversation
Every publish rewrites /start, so same-repo serialization stays. Cross-repo races on grails-website are handled by deploy-github-pages@asf after apache/grails-github-actions#110. Assisted-by: Cursor:Grok-4.6
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited to comment updates in the workflow file and does not alter execution logic, permissions, or publish behavior.
Pull request overview
Updates the GitHub Actions publish workflow commentary to clarify why this repository keeps a local concurrency queue for /start publishes while relying on apache/grails-github-actions/deploy-github-pages@asf to handle cross-repo non-fast-forward races when pushing to apache/grails-website.
Changes:
- Rewords and expands the inline workflow comments explaining the purpose/scope of the
publish-grails-forge-uiconcurrency group. - Documents that cross-repo publish races are handled by
deploy-github-pages@asf(perapache/grails-github-actions#110) and that GitHub concurrency groups are repo-scoped.
File summaries
| File | Description |
|---|---|
| .github/workflows/publish.yml | Clarifies concurrency intent and cross-repo race handling via updated comments (no functional workflow changes). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apache/grails-github-actions/deploy-github-pages@asf. After apache/grails-github-actions#110, that action retries genuine non-fast-forward races onapache/grails-website(rebase the unpublished commit, never force-push).start/path. The repository-localpublish-grails-forge-uiconcurrency group is kept so twomainpublishes cannot overwrite/startout of order. GitHub concurrency groups are repo-scoped and cannot replace Update gradle action version to an approved ASF version #110 for grails-core / grails-static-website.GH_TOKEN: ${{ secrets.GRAILS_GHTOKEN }}. The defaultGITHUB_TOKENcannot writeapache/grails-website. Jobpermissions: contents: writeis unchanged as the action's same-repo fallback.GRAILS_GHTOKENis not a repo-level secret visible here; it is the same org/environment PAT grails-core and grails-static-website already use, and the last Publish run onmainsucceeded.Test plan
.github/workflows/publish.ymlstill callsdeploy-github-pages@asfwithTARGET_REPOSITORY: apache/grails-website,LAST_SNAPSHOT_FOLDER: start, andGRAILS_GHTOKEN.publish-grails-forge-uiconcurrency group remains (cancel-in-progress: false).workflow_dispatchand verify https://grails.apache.org/start/ updates.