Skip to content

HADOOP-11823: dont check for verifier in RpcDeniedReply - #106

Closed
pradeep1288 wants to merge 1 commit into
apache:trunkfrom
pradeep1288:hadoop-11823
Closed

HADOOP-11823: dont check for verifier in RpcDeniedReply#106
pradeep1288 wants to merge 1 commit into
apache:trunkfrom
pradeep1288:hadoop-11823

Conversation

@pradeep1288

Copy link
Copy Markdown

When RPC returns a denied reply, the code should not check for a verifier. It is a bug as it doesn't match the RPC protocol. (See Page 33 from NFS Illustrated book).

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec35Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1052trunk passed
+1compile1183trunk passed
+1checkstyle20trunk passed
+1mvnsite29trunk passed
+1shadedclient682branch has no errors when building and testing our client artifacts.
+1javadoc22trunk passed
0spotbugs39Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs38trunk passed
_ Patch Compile Tests _
+1mvninstall20the patch passed
+1compile996the patch passed
+1javac996the patch passed
+1checkstyle24the patch passed
+1mvnsite29the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient633patch has no errors when building and testing our client artifacts.
+1javadoc24the patch passed
+1findbugs50the patch passed
_ Other Tests _
+1unit42hadoop-nfs in the patch passed.
+1asflicense41The patch does not generate ASF License warnings.
5033
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/1/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 3f42594db77d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 7f1b76c
Default Java1.8.0_212
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/1/testReport/
Max. process+thread count447 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/1/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1029trunk passed
+1compile998trunk passed
+1checkstyle21trunk passed
+1mvnsite30trunk passed
+1shadedclient694branch has no errors when building and testing our client artifacts.
+1javadoc25trunk passed
0spotbugs38Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs35trunk passed
_ Patch Compile Tests _
+1mvninstall18the patch passed
+1compile972the patch passed
+1javac972the patch passed
+1checkstyle17the patch passed
+1mvnsite31the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient615patch has no errors when building and testing our client artifacts.
+1javadoc26the patch passed
+1findbugs43the patch passed
_ Other Tests _
+1unit41hadoop-nfs in the patch passed.
+1asflicense40The patch does not generate ASF License warnings.
4781
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/2/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 37a3bd54fe3c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 62efb63
Default Java1.8.0_212
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/2/testReport/
Max. process+thread count448 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/2/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec35Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1175trunk passed
+1compile1067trunk passed
+1checkstyle23trunk passed
+1mvnsite32trunk passed
+1shadedclient173branch has no errors when building and testing our client artifacts.
+1javadoc27trunk passed
0spotbugs43Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs41trunk passed
_ Patch Compile Tests _
+1mvninstall20the patch passed
+1compile1046the patch passed
+1javac1046the patch passed
+1checkstyle24the patch passed
+1mvnsite32the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient727patch has no errors when building and testing our client artifacts.
+1javadoc27the patch passed
+1findbugs51the patch passed
_ Other Tests _
+1unit48hadoop-nfs in the patch passed.
+1asflicense43The patch does not generate ASF License warnings.
4721
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/3/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 3f2d9f1b7eb0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / e872ceb
Default Java1.8.0_212
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/3/testReport/
Max. process+thread count315 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/3/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec69Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1068trunk passed
+1compile1031trunk passed
+1checkstyle26trunk passed
+1mvnsite29trunk passed
+1shadedclient785branch has no errors when building and testing our client artifacts.
+1javadoc27trunk passed
0spotbugs39Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs38trunk passed
_ Patch Compile Tests _
+1mvninstall21the patch passed
+1compile1009the patch passed
+1javac1009the patch passed
+1checkstyle25the patch passed
+1mvnsite31the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient634patch has no errors when building and testing our client artifacts.
+1javadoc27the patch passed
+1findbugs45the patch passed
_ Other Tests _
+1unit42hadoop-nfs in the patch passed.
+1asflicense39The patch does not generate ASF License warnings.
5070
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/4/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 8f7be2be646c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 00b5a27
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/4/testReport/
Max. process+thread count412 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/4/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1051trunk passed
+1compile1051trunk passed
+1checkstyle21trunk passed
+1mvnsite25trunk passed
+1shadedclient669branch has no errors when building and testing our client artifacts.
+1javadoc25trunk passed
0spotbugs38Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs37trunk passed
_ Patch Compile Tests _
+1mvninstall17the patch passed
+1compile989the patch passed
+1javac989the patch passed
+1checkstyle18the patch passed
+1mvnsite26the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient637patch has no errors when building and testing our client artifacts.
+1javadoc24the patch passed
+1findbugs49the patch passed
_ Other Tests _
+1unit43hadoop-nfs in the patch passed.
+1asflicense42The patch does not generate ASF License warnings.
4887
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/5/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux e81a9e50dca4 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 8943e13
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/5/testReport/
Max. process+thread count412 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/5/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec65Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1180trunk passed
+1compile1059trunk passed
+1checkstyle19trunk passed
+1mvnsite27trunk passed
+1shadedclient689branch has no errors when building and testing our client artifacts.
+1javadoc27trunk passed
0spotbugs43Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs40trunk passed
_ Patch Compile Tests _
+1mvninstall18the patch passed
+1compile1119the patch passed
+1javac1119the patch passed
+1checkstyle19the patch passed
+1mvnsite28the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient632patch has no errors when building and testing our client artifacts.
+1javadoc23the patch passed
+1findbugs47the patch passed
_ Other Tests _
+1unit44hadoop-nfs in the patch passed.
+1asflicense41The patch does not generate ASF License warnings.
5206
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/6/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux cee25b4ea04c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 4cb22cd
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/6/testReport/
Max. process+thread count447 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/6/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec158Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1406trunk passed
+1compile1347trunk passed
+1checkstyle32trunk passed
+1mvnsite39trunk passed
+1shadedclient907branch has no errors when building and testing our client artifacts.
+1javadoc29trunk passed
0spotbugs47Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs45trunk passed
_ Patch Compile Tests _
+1mvninstall24the patch passed
+1compile1079the patch passed
+1javac1079the patch passed
+1checkstyle24the patch passed
+1mvnsite29the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient717patch has no errors when building and testing our client artifacts.
+1javadoc28the patch passed
+1findbugs48the patch passed
_ Other Tests _
+1unit42hadoop-nfs in the patch passed.
+1asflicense57The patch does not generate ASF License warnings.
6151
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/7/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux da89ff560e7f 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / e04dcfd
Default Java1.8.0_212
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/7/testReport/
Max. process+thread count340 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/7/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec37Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1098trunk passed
+1compile1031trunk passed
+1checkstyle32trunk passed
+1mvnsite37trunk passed
+1shadedclient757branch has no errors when building and testing our client artifacts.
+1javadoc34trunk passed
0spotbugs48Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs45trunk passed
_ Patch Compile Tests _
+1mvninstall22the patch passed
+1compile994the patch passed
+1javac994the patch passed
+1checkstyle31the patch passed
+1mvnsite37the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient665patch has no errors when building and testing our client artifacts.
+1javadoc32the patch passed
+1findbugs55the patch passed
_ Other Tests _
+1unit50hadoop-nfs in the patch passed.
+1asflicense49The patch does not generate ASF License warnings.
5137
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/8/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux ada61698f5b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 3329257
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/8/testReport/
Max. process+thread count413 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/8/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec124Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1221trunk passed
+1compile1211trunk passed
+1checkstyle26trunk passed
+1mvnsite32trunk passed
+1shadedclient815branch has no errors when building and testing our client artifacts.
+1javadoc26trunk passed
0spotbugs45Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs41trunk passed
_ Patch Compile Tests _
+1mvninstall23the patch passed
+1compile1067the patch passed
+1javac1067the patch passed
+1checkstyle25the patch passed
+1mvnsite31the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient753patch has no errors when building and testing our client artifacts.
+1javadoc28the patch passed
+1findbugs51the patch passed
_ Other Tests _
+1unit44hadoop-nfs in the patch passed.
+1asflicense45The patch does not generate ASF License warnings.
5699
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-106/9/artifact/out/Dockerfile
GITHUB PR#106
JIRA IssueHADOOP-11823
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux c2582b257ed4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 915cbc9
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/9/testReport/
Max. process+thread count306 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-nfs U: hadoop-common-project/hadoop-nfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-106/9/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: Jacob Maes <jmaes@linkedin.com>
Reviewers: Prateek Maheshwari <pmaheshw@linkedin.com>,Xinyu Liu <xiliu@linkedin.com>
Closesapache#106 from jmakes/samza-1089-2
@github-actions

Copy link
Copy Markdown
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pradeep1288@hadoop-yetus