Skip to content

HADOOP-16888. [JDK11] Support JDK11 in the precommit job - #2012

Merged
aajisaka merged 10 commits into
apache:trunkfrom
aajisaka:HADOOP-16888
Jun 19, 2020
Merged

HADOOP-16888. [JDK11] Support JDK11 in the precommit job#2012
aajisaka merged 10 commits into
apache:trunkfrom
aajisaka:HADOOP-16888

Conversation

@aajisaka

@aajisakaaajisaka commented May 12, 2020

Copy link
Copy Markdown
Member

JIRA: https://issues.apache.org/jira/browse/HADOOP-16888

  • Install JDK 11 in the build image.
  • Run mvninstall, compile, javac, and javadoc with JDK 8 and JDK 11. (Now javadoc with JDK 11 is broken.)
  • Run the unit tests with JDK 8 only. This is because it takes too long to run unit tests with both JDK 8 and JDK 11.

After that, I'll prepare daily qbt jobs for JDK 11. The job will run full unit tests with JDK 11.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/1/console in case of problems.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec29m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
-1 ❌shadedclient19m 24sbranch has errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 2sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌shadedclient19m 14spatch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
70m 36s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/1/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux 22f82500c8bf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 936bf09
Max. process+thread count315 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/1/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka

Copy link
Copy Markdown
MemberAuthor

shaded client test is failing. Probably this is because JAVA_HOME is set to Java 11.

https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/1/console

02:35:43 WARNING: Setting /usr/lib/jvm/java-11-openjdk-amd64 as the JAVA_HOME.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/2/console in case of problems.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚shadedclient15m 59sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 3sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient15m 48spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
35m 53s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/2/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux c38e30b0faf0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / d60496e
Max. process+thread count309 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/2/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka

Copy link
Copy Markdown
MemberAuthor

The build timeout in #2013.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/3/console in case of problems.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚shadedclient15m 27sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 2sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient15m 40spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
34m 36s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/3/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux bd7715e4f38d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / d60496e
Max. process+thread count333 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/3/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/4/console in case of problems.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec29m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚shadedclient18m 1sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 4sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient17m 3spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
67m 9s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/4/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux 65d0f23ad560 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / b65815d
Max. process+thread count414 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/4/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/5/console in case of problems.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec26m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚shadedclient16m 0sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 3sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient15m 12spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
59m 22s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/5/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux 7066bf7bb680 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 7bb902b
Max. process+thread count340 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/5/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/6/console in case of problems.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec22m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚shadedclient14m 18sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 3sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient13m 46spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
53m 18s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/6/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux 2842cc4f4a40 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / cef0756
Max. process+thread count414 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/6/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka

Copy link
Copy Markdown
MemberAuthor

Full tests ran and it took 906 minutes. It seems that the timeout should be increased > 15 hours.
#2013 (comment)

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/7/console in case of problems.

@aajisaka

Copy link
Copy Markdown
MemberAuthor

Now I think the PR is ready for merge.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec27m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚shadedclient15m 58sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚hadolint0m 3sThere were no new hadolint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient15m 42spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
61m 18s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/7/artifact/out/Dockerfile
GITHUB PR#2012
Optional Testsdupname asflicense shellcheck shelldocs hadolint
unameLinux 048c2aa08103 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 6e04b00
Max. process+thread count309 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/7/console
versionsgit=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @aajisaka for the efforts here.
changes LGTM +1

  • I suppose the timeout is for testing purpose only and you will be reverting it, before pushing

@aajisaka

Copy link
Copy Markdown
MemberAuthor

Thank you @ayushtkn
Reverted the timeout change. I'll merge this.

@hadoop-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/8/console in case of problems.

@aajisaka
aajisaka merged commit 9821b94 into apache:trunkJun 19, 2020
@aajisaka
aajisaka deleted the HADOOP-16888 branch June 19, 2020 04:29
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec28m 0sDocker mode activated.
-1 ❌patch0m 5s#2012 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2012/8/artifact/out/Dockerfile
GITHUB PR#2012
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-2012/8/console
versionsgit=2.17.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@aajisaka@hadoop-yetus@ayushtkn