HDFS-15492. Make trash root inside each snapshottable directory by smengcl · Pull Request #2176 · apache/hadoop

smengcl · 2020-07-29T19:54:10Z

https://issues.apache.org/jira/browse/HDFS-15492

TODOs

Mod getTrashRoot
Make this a config and disable it by default
Mod getTrashRoots
Add unit test
Check result when both encryption zone and snapshot are enabled on the same directory
Possibly reduce overhead of calling getSnapshottableDirListing() every time because the snapshot list can be large if there are a lot of snapshots on a cluster
- Filed HDFS-15513

hadoop-yetus · 2020-07-29T21:10:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	23m 30s	trunk passed
+1 💚	compile	1m 2s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 49s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 24s	trunk passed
+1 💚	mvnsite	0m 51s	trunk passed
+1 💚	shadedclient	16m 50s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 37s	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 31s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 33s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 30s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 47s	the patch passed
+1 💚	compile	0m 52s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 52s	the patch passed
+1 💚	compile	0m 43s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	0m 43s	the patch passed
-0 ⚠️	checkstyle	0m 18s	hadoop-hdfs-project/hadoop-hdfs-client: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64)
+1 💚	mvnsite	0m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 28s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 33s	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 27s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 2s	hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		75m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/1/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 29d5cd719f3d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `5d8600e`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-client.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/1/testReport/
Max. process+thread count	311 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-07-30T00:33:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 2s	trunk passed
+1 💚	compile	0m 55s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 47s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 24s	trunk passed
+1 💚	mvnsite	0m 52s	trunk passed
+1 💚	shadedclient	16m 51s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 39s	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 30s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 29s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 27s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 48s	the patch passed
+1 💚	compile	0m 49s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 49s	the patch passed
+1 💚	compile	0m 42s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	0m 42s	the patch passed
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	mvnsite	0m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 22s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 32s	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 28s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 55s	hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		102m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/2/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 5bd346f89f5a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `5d8600e`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/2/testReport/
Max. process+thread count	306 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2176/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-07-31T05:52:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 0s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 13s	trunk passed
+1 💚	compile	0m 58s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 53s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 29s	trunk passed
+1 💚	mvnsite	0m 58s	trunk passed
+1 💚	shadedclient	15m 17s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 40s	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 36s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 22s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 20s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 47s	the patch passed
+1 💚	compile	0m 50s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 50s	the patch passed
+1 💚	compile	0m 43s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	0m 43s	the patch passed
+1 💚	checkstyle	0m 19s	the patch passed
+1 💚	mvnsite	0m 46s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 15s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 34s	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 32s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	2m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 59s	hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		97m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/2/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e3692f3aa35a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `05b3337`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/2/testReport/
Max. process+thread count	413 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-04T10:32:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	0m 53s	Maven dependency ordering for branch
+1 💚	mvninstall	20m 18s	trunk passed
+1 💚	compile	22m 24s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	18m 47s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	2m 53s	trunk passed
+1 💚	mvnsite	4m 25s	trunk passed
+1 💚	shadedclient	21m 42s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 43s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 52s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 28s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 27s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 56s	the patch passed
+1 💚	compile	22m 17s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌	cc	22m 17s	root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 38 new + 124 unchanged - 38 fixed = 162 total (was 162)
+1 💚	javac	22m 17s	the patch passed
+1 💚	compile	18m 27s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	cc	18m 27s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 23 new + 139 unchanged - 23 fixed = 162 total (was 162)
+1 💚	javac	18m 27s	the patch passed
-0 ⚠️	checkstyle	2m 55s	root: The patch generated 3 new + 826 unchanged - 0 fixed = 829 total (was 826)
+1 💚	mvnsite	3m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 5s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 39s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 49s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	8m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 21s	hadoop-common in the patch passed.
+1 💚	unit	2m 21s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	96m 9s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 7s	The patch does not generate ASF License warnings.
		292m 57s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.tools.TestHdfsConfigFields
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 40a24d11891b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `ab2b3df`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/testReport/
Max. process+thread count	4814 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/5/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-04T12:24:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	19m 15s	trunk passed
+1 💚	compile	21m 24s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	18m 12s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	2m 56s	trunk passed
+1 💚	mvnsite	4m 9s	trunk passed
+1 💚	shadedclient	21m 48s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 35s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 57s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 23s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 17s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s	the patch passed
+1 💚	compile	20m 25s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌	cc	20m 25s	root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 30 new + 132 unchanged - 30 fixed = 162 total (was 162)
+1 💚	javac	20m 25s	the patch passed
+1 💚	compile	18m 32s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	cc	18m 32s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 36 new + 126 unchanged - 36 fixed = 162 total (was 162)
+1 💚	javac	18m 32s	the patch passed
-0 ⚠️	checkstyle	3m 4s	root: The patch generated 3 new + 826 unchanged - 0 fixed = 829 total (was 826)
+1 💚	mvnsite	4m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 41s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 37s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 54s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	9m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 37s	hadoop-common in the patch passed.
+1 💚	unit	2m 18s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	150m 21s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 6s	The patch does not generate ASF License warnings.
		343m 53s

Reason	Tests
Failed junit tests	hadoop.tools.TestHdfsConfigFields
	hadoop.hdfs.TestStripedFileAppend
	hadoop.hdfs.TestDecommissionWithStriped
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.TestAclsEndToEnd
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.TestMaintenanceState
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.TestLeaseRecovery2
	hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
	hadoop.hdfs.TestDFSClientFailover
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestReservedRawPaths

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 1e62ed8ab7a6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `ab2b3df`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/testReport/
Max. process+thread count	3801 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/6/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-04T13:09:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	22m 34s	trunk passed
+1 💚	compile	20m 59s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	18m 33s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	3m 3s	trunk passed
+1 💚	mvnsite	4m 11s	trunk passed
+1 💚	shadedclient	22m 26s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 7s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 16s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	20m 27s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌	cc	20m 27s	root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 39 new + 123 unchanged - 39 fixed = 162 total (was 162)
+1 💚	javac	20m 27s	the patch passed
+1 💚	compile	18m 38s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	cc	18m 38s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 21 new + 141 unchanged - 21 fixed = 162 total (was 162)
+1 💚	javac	18m 38s	the patch passed
-0 ⚠️	checkstyle	3m 21s	root: The patch generated 3 new + 826 unchanged - 0 fixed = 829 total (was 826)
+1 💚	mvnsite	4m 3s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 57s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 43s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 7s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	9m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 13s	hadoop-common in the patch passed.
+1 💚	unit	2m 26s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	151m 58s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 3s	The patch does not generate ASF License warnings.
		354m 36s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
	hadoop.tools.TestHdfsConfigFields
	hadoop.hdfs.server.diskbalancer.TestDiskBalancerWithMockMover
	hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.server.balancer.TestBalancerRPCDelay
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
	hadoop.hdfs.server.blockmanagement.TestPendingDataNodeMessages
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
	hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
	hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
	hadoop.hdfs.server.datanode.TestBPOfferService
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 132b8352a85f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `ab2b3df`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/testReport/
Max. process+thread count	3804 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/7/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-04T23:00:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	19m 51s	trunk passed
+1 💚	compile	20m 15s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	17m 20s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	2m 57s	trunk passed
+1 💚	mvnsite	4m 2s	trunk passed
+1 💚	shadedclient	21m 30s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 42s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 53s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 14s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 3s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	compile	19m 57s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌	cc	19m 57s	root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 35 new + 127 unchanged - 35 fixed = 162 total (was 162)
+1 💚	javac	19m 57s	the patch passed
+1 💚	compile	17m 58s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	cc	17m 58s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 34 new + 128 unchanged - 34 fixed = 162 total (was 162)
+1 💚	javac	17m 58s	the patch passed
-0 ⚠️	checkstyle	2m 47s	root: The patch generated 1 new + 826 unchanged - 0 fixed = 827 total (was 826)
+1 💚	mvnsite	3m 59s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 56s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 43s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 53s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	8m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 50s	hadoop-common in the patch passed.
+1 💚	unit	2m 25s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	125m 40s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 5s	The patch does not generate ASF License warnings.
		315m 11s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestSnapshot
	hadoop.tools.TestHdfsConfigFields
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 6b2713f6389f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `0277856`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/testReport/
Max. process+thread count	3649 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/8/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bshashikant

The changes look good overall. The point of concern here is with each delete call with trash interval set on the filesystem, will potentially have one more rpc call to fetch the snapshottable dir list from namenode every time.

bshashikant · 2020-08-05T09:45:52Z

Let's say we have a structure like /dir1/dir2 where dir1 is ez enabled and dir2 is made snapshottable. In such cases, anything deleted under dir2 will be under trash location under dir2 while everything which is deleted within dir1 but not dir2, will exist in trash under dir1. Will it lead to any issues??

With a288110174c55b2c601b79b2beca9a27b2f34102, when a path given to getTrashRoot() is both inside an EZ and in a snapshottable dir, it should now choose the inner most trash.

hadoop-yetus · 2020-08-06T13:04:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 1s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 21s	Maven dependency ordering for branch
-1 ❌	mvninstall	28m 26s	root in trunk failed.
-1 ❌	compile	13m 23s	root in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	compile	10m 47s	root in trunk failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-0 ⚠️	checkstyle	2m 29s	The patch fails to run checkstyle in root
+1 💚	mvnsite	3m 37s	trunk passed
+1 💚	shadedclient	20m 23s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 14s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 23s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 30s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 36s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s	the patch passed
-1 ❌	compile	13m 19s	root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	cc	13m 19s	root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javac	13m 19s	root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	compile	17m 21s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	cc	17m 21s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 129 new + 33 unchanged - 0 fixed = 162 total (was 33)
-1 ❌	javac	17m 21s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 192 new + 1756 unchanged - 0 fixed = 1948 total (was 1756)
-0 ⚠️	checkstyle	2m 40s	The patch fails to run checkstyle in root
+1 💚	mvnsite	4m 0s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 3s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 52s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 3s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	findbugs	2m 51s	hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	unit	9m 32s	hadoop-common in the patch passed.
+1 💚	unit	2m 18s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	97m 9s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 9s	The patch does not generate ASF License warnings.
		274m 37s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs-client
	Load of known null value in org.apache.hadoop.hdfs.DistributedFileSystem.getTrashRoot(Path) At DistributedFileSystem.java:in org.apache.hadoop.hdfs.DistributedFileSystem.getTrashRoot(Path) At DistributedFileSystem.java:[line 3292]
Failed junit tests	hadoop.hdfs.TestGetFileChecksum
	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.tools.TestHdfsConfigFields

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 58fae0238d0e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `c7e71a6`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
mvninstall	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/branch-mvninstall-root.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/branch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/branch-compile-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/buildtool-branch-checkstyle-root.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/buildtool-patch-checkstyle-root.txt
findbugs	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/testReport/
Max. process+thread count	4450 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/9/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-06T13:47:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	26m 0s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 21s	Maven dependency ordering for branch
-1 ❌	mvninstall	25m 8s	root in trunk failed.
-1 ❌	compile	12m 40s	root in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	compile	10m 40s	root in trunk failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-0 ⚠️	checkstyle	2m 31s	The patch fails to run checkstyle in root
+1 💚	mvnsite	3m 32s	trunk passed
+1 💚	shadedclient	20m 42s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 17s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 22s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 38s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 44s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s	the patch passed
-1 ❌	compile	12m 46s	root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	cc	12m 46s	root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javac	12m 46s	root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	compile	11m 48s	root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-1 ❌	cc	11m 48s	root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-1 ❌	javac	11m 48s	root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-0 ⚠️	checkstyle	2m 40s	The patch fails to run checkstyle in root
+1 💚	mvnsite	3m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 32s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 11s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 11s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
-1 ❌	findbugs	2m 31s	hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	unit	9m 40s	hadoop-common in the patch passed.
+1 💚	unit	2m 6s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	99m 3s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		287m 15s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs-client
	Load of known null value in org.apache.hadoop.hdfs.DistributedFileSystem.getTrashRoot(Path) At DistributedFileSystem.java:in org.apache.hadoop.hdfs.DistributedFileSystem.getTrashRoot(Path) At DistributedFileSystem.java:[line 3292]
Failed junit tests	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
	hadoop.tools.TestHdfsConfigFields
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestDecommissioningStatus
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.datanode.TestBlockScanner

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 8f8155b72828 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `c7e71a6`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
mvninstall	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/branch-mvninstall-root.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/branch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/branch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/buildtool-branch-checkstyle-root.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/buildtool-patch-checkstyle-root.txt
findbugs	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/testReport/
Max. process+thread count	3891 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/10/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bshashikant · 2020-08-06T16:10:42Z

i guess we need to define these configs in SnapshotManager if we intend not add it in hdfs-default.xml(which i would prefer). It leads to test failure here "hadoop.tools.TestHdfsConfigFields"

Got it. I will put it in FSNameSystem as private config then as it is used there, similar to HDFS-15481 did.

Change-Id: I43aeb4959c5d0b9140eaed8f899b2f93f642eb04

Change-Id: I29120bf9c946841615c0e7efaac5c0056f1f795c

Change-Id: I7b497d7f10fcc9c37916abdab330c21c8bb05a16

…e on server-side only. Change-Id: I3d88fc5a437f8211755abe5d8b840de040a46099

Change-Id: Ic7c6078669925a3e13c6e462e6d0e51c3b9ff0fa

…ing snapshot on the test dir. Change-Id: I3dbe20785351b84375c644de6d06610c74d6e7d9

Change-Id: I6c65115eb8f176bc948f38f7c91e417391f8cab8

… null. Change-Id: Iff9a24d76966857340eacb8586c88d7b991468f9

…and EZ enabled to be added to the result twice; added test case for this. Change-Id: Iecad971f0712ad6d1183bdc14fc7a05864d9e84b

Change-Id: Ib023bd014afa1496b90c678645cb868d9056c9ed

…pshottable dir, it should choose the inner most trash. Change-Id: Ibf58de1031c94b0166f27f623eb5e9ea1669bac0

…eys, since it the NN will be the only source of truth for this config. Change-Id: I5247537803c2017b5af860e7eac057123031a86f

Change-Id: I6fd630e4d47fc9d403811d2bb92077322e7d4895

Change-Id: Id3c130c4f94508d21c656602a867fc59f2e6126a

…meSystem. Change-Id: Ife297d420156b9aafcb5d774ae419b6f3b6ce149

smengcl · 2020-08-07T20:20:59Z

I rebased the commits on to the latest trunk. Also made dfs.namenode.snapshot.trashroot.enabled a private config in FSNameSystem.

hadoop-yetus · 2020-08-08T01:34:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	26m 42s	trunk passed
+1 💚	compile	19m 26s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	16m 51s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	3m 7s	trunk passed
+1 💚	mvnsite	4m 5s	trunk passed
+1 💚	shadedclient	21m 42s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 53s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 0s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 35s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 50s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	18m 45s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌	cc	18m 45s	root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 11 new + 151 unchanged - 11 fixed = 162 total (was 162)
+1 💚	javac	18m 45s	the patch passed
+1 💚	compile	16m 46s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	cc	16m 46s	root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~~18.04-b09 generated 25 new + 137 unchanged - 25 fixed = 162 total (was 162)
+1 💚	javac	16m 46s	the patch passed
-0 ⚠️	checkstyle	2m 59s	root: The patch generated 1 new + 826 unchanged - 0 fixed = 827 total (was 826)
+1 💚	mvnsite	4m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 1s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 53s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 0s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	8m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 23s	hadoop-common in the patch passed.
+1 💚	unit	2m 20s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	114m 52s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 7s	The patch does not generate ASF License warnings.
		309m 49s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestDFSStorageStateRecovery
	hadoop.hdfs.server.namenode.TestFSEditLogLoader
	hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor
	hadoop.hdfs.server.namenode.TestQuotaByStorageType
	hadoop.hdfs.server.namenode.ha.TestStandbyInProgressTail
	hadoop.hdfs.server.namenode.TestFSDirectory
	hadoop.hdfs.server.namenode.TestFsck
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
	hadoop.hdfs.server.datanode.TestBPOfferService
	hadoop.hdfs.server.namenode.TestNamenodeRetryCache
	hadoop.hdfs.TestErasureCodeBenchmarkThroughput
	hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
	hadoop.hdfs.server.namenode.ha.TestHASafeMode
	hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 1720ab99aba2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `975b602`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/testReport/
Max. process+thread count	4146 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/13/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-11T02:55:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	34m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	buf	0m 0s	buf was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	48m 25s	trunk passed
+1 💚	compile	25m 45s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	21m 33s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	3m 41s	trunk passed
+1 💚	mvnsite	4m 22s	trunk passed
+1 💚	shadedclient	24m 54s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 28s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 33s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 36s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 4s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	20m 10s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
-1 ❌	cc	20m 10s	root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 27 new + 135 unchanged - 27 fixed = 162 total (was 162)
+1 💚	javac	20m 10s	the patch passed
+1 💚	compile	17m 42s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
-1 ❌	cc	17m 42s	root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~~18.04-b01 generated 25 new + 137 unchanged - 25 fixed = 162 total (was 162)
+1 💚	javac	17m 42s	the patch passed
-0 ⚠️	checkstyle	3m 35s	root: The patch generated 1 new + 826 unchanged - 0 fixed = 827 total (was 826)
+1 💚	mvnsite	3m 47s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 9s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 26s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 36s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	8m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 21s	hadoop-common in the patch passed.
+1 💚	unit	2m 9s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	121m 17s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 57s	The patch does not generate ASF License warnings.
		387m 35s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/artifact/out/Dockerfile
GITHUB PR	#2176
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc buflint bufcompat
uname	Linux 5425af46f42b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `5e0f879`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
cc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/testReport/
Max. process+thread count	2650 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2176/14/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

smengcl · 2020-08-11T15:52:07Z

Reran the test. Much less unrelated flaky test failures now.

I'm merging this PR in a minute.

jojochuang · 2020-08-28T17:50:07Z

I'm late to this. But we should verify to make sure httpfs also behaves the sames. Otherwise it'll break Hue.

smengcl · 2020-09-14T21:43:13Z

I'm late to this. But we should verify to make sure httpfs also behaves the sames. Otherwise it'll break Hue.

hey @jojochuang, thanks for checking in!

I have written a simple test for verifying HttpFS (over WebHDFS). HttpFS works as expected. But I haven't figured out how to add a config to the HDFS cluster that BaseTestHttpFSWith launches. Currently the config change for this test is a bit hacky. Ergo, I haven't submitted a patch for new jira to add this test. I would file a new jira to add it once this little problem is solved.

HDFS-15492.TestHttpFS.001.patch.txt

…he#2176) Conflicts: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java Change-Id: Ibe23d5760d61326865dad93460c6b426d002947d (cherry picked from commit 10ce000)

smengcl self-assigned this Aug 4, 2020

smengcl changed the title ~~[WIP] HDFS-15492. Make trash root inside each snapshottable directory~~HDFS-15492. Make trash root inside each snapshottable directoryAug 4, 2020

smengcl requested review from bshashikant and mukul1987 August 4, 2020 18:27

bshashikant reviewed Aug 5, 2020
View reviewed changes

Comment thread...ect/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java Outdated

bshashikant reviewed Aug 5, 2020
View reviewed changes

bshashikant reviewed Aug 6, 2020
View reviewed changes

Comment thread...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java Outdated

bshashikant reviewed Aug 6, 2020
View reviewed changes

Comment thread...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java Outdated

bshashikant reviewed Aug 6, 2020
View reviewed changes

smengcl added 12 commits August 7, 2020 12:03

First step, client shall now move to trash inside a snapshot.
1aeb21b
Change-Id: I43aeb4959c5d0b9140eaed8f899b2f93f642eb04

Fix javadoc.
265a17a
Change-Id: I29120bf9c946841615c0e7efaac5c0056f1f795c

Add new config key dfs.namenode.snapshot.trashroot.enabled.
35e8a17
Change-Id: I7b497d7f10fcc9c37916abdab330c21c8bb05a16

Make the config dfs.namenode.snapshot.trashroot.enabled configurabl…
6fa4aaf
…e on server-side only. Change-Id: I3d88fc5a437f8211755abe5d8b840de040a46099

Handle case where getSnapshottableDirListing gives null.
daa29f0
Change-Id: Ic7c6078669925a3e13c6e462e6d0e51c3b9ff0fa

Added basic test case with new config enabled, before and after allow…
5387f8a
…ing snapshot on the test dir. Change-Id: I3dbe20785351b84375c644de6d06610c74d6e7d9

getTrashRoots done.
7b7e88c
Change-Id: I6c65115eb8f176bc948f38f7c91e417391f8cab8

Added test for getTrashRoots; getSnapshottableDirListing could return…
9ec4658
… null. Change-Id: Iff9a24d76966857340eacb8586c88d7b991468f9

Use Set in DFS#getTrashRoots to avoid a directory with both snapshot …
1a7a275
…and EZ enabled to be added to the result twice; added test case for this. Change-Id: Iecad971f0712ad6d1183bdc14fc7a05864d9e84b

Remove unused imports.
e373f75
Change-Id: Ib023bd014afa1496b90c678645cb868d9056c9ed

When a path given to getTrashRoot() is both inside an EZ and in a sna…
534ebbb
…pshottable dir, it should choose the inner most trash. Change-Id: Ibf58de1031c94b0166f27f623eb5e9ea1669bac0

Remove dfs.namenode.snapshot.trashroot.enabled from HdfsClientConfigK…
26b7b4a
…eys, since it the NN will be the only source of truth for this config. Change-Id: I5247537803c2017b5af860e7eac057123031a86f

smengcl added 3 commits August 7, 2020 12:03

Make findbugs happy.
5b6fecb
Change-Id: I6fd630e4d47fc9d403811d2bb92077322e7d4895

startsWith -> equals in some tests.
577de51
Change-Id: Id3c130c4f94508d21c656602a867fc59f2e6126a

Make dfs.namenode.snapshot.trashroot.enabled a private config in FSNa…
56d3f18
…meSystem. Change-Id: Ife297d420156b9aafcb5d774ae419b6f3b6ce149

smengcl force-pushed the HDFS-15492 branch from 5ced0d8 to 56d3f18Compare August 7, 2020 20:20

bshashikant approved these changes Aug 10, 2020
View reviewed changes

smengcl merged commit 3fd3aeb into apache:trunkAug 11, 2020

Uh oh!

Conversation

smengcl commented Jul 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODOs

Uh oh!

hadoop-yetus commented Jul 29, 2020

Uh oh!

hadoop-yetus commented Jul 30, 2020

Uh oh!

hadoop-yetus commented Jul 31, 2020

Uh oh!

hadoop-yetus commented Aug 4, 2020

Uh oh!

hadoop-yetus commented Aug 4, 2020

Uh oh!

hadoop-yetus commented Aug 4, 2020

Uh oh!

hadoop-yetus commented Aug 4, 2020

Uh oh!

bshashikant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bshashikantAug 5, 2020

Choose a reason for hiding this comment

Uh oh!

smengclAug 6, 2020

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 6, 2020

Uh oh!

hadoop-yetus commented Aug 6, 2020

Uh oh!

Uh oh!

Uh oh!

bshashikantAug 6, 2020

Choose a reason for hiding this comment

Uh oh!

smengclAug 7, 2020

Choose a reason for hiding this comment

Uh oh!

smengcl commented Aug 7, 2020

Uh oh!

hadoop-yetus commented Aug 8, 2020

Uh oh!

hadoop-yetus commented Aug 11, 2020

Uh oh!

smengcl commented Aug 11, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jojochuang commented Aug 28, 2020

Uh oh!

smengcl commented Sep 14, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smengcl commented Jul 29, 2020•
edited
Loading

smengcl commented Aug 11, 2020•
edited
Loading

smengcl commented Sep 14, 2020•
edited
Loading