HADOOP-17358. Improve excessive reloading of Configurations - #2436
Merged
Merged
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
those two Junit test are broken
|
jojochuang
reviewed
Nov 5, 2020
Contributor
There was a problem hiding this comment.
I would really appreciate if you rewrite this so it doesn't use -1 as startIdx. A year from now I won't remember why we want to load from position -1.
Contributor
Author
There was a problem hiding this comment.
Good point @jojochuang .I will think about something. or maybe addd a comment.
amahussein
force-pushed
the
ahadoop-1353
branch
from
November 5, 2020 19:19
cd816f3 to
d6e5526
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Thanks @jojochuang . I updated the PR. |
Contributor
Author
|
There is an open jira to fix |
jojochuang
reviewed
Nov 10, 2020
| } | ||
| } | ||
| return properties; | ||
| return props; |
Contributor
There was a problem hiding this comment.
(I thought I posted a comment here, but somehow it got lost in github comments)
returning this object isn't necessary, and obviously the callers don't use the return value.
jojochuang
reviewed
Nov 10, 2020
| * @param startIdx the index where the new resource has been added. | ||
| * @param fullReload flag whether we do complete reload of the conf instead | ||
| * of just loading the new resource. | ||
| * @return the properties loaded from the resource. |
Contributor
There was a problem hiding this comment.
Could you also remove this @return? I am +1 once this is updated.
Contributor
Author
There was a problem hiding this comment.
Sorry . I overlooked that.
I added a new commit.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Merged into trunk. I'll cherry pick the commit into lower branches later. |
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2020
Co-authored-by: ahussein <ahmed.hussein@verizonmedia.com> (cherry picked from commit 71071e5)
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
) Co-authored-by: ahussein <ahmed.hussein@verizonmedia.com> (cherry picked from commit 71071e5) (cherry picked from commit 23fe3bd) (cherry picked from commit ac3e10a) (cherry picked from commit 487eaa6) Change-Id: Ia2c2f46f9437c70e1119ab8f0920aaeb5bb74a14 (cherry picked from commit 261437c7279b21e3190a2acbaba30fc0b21eb198)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute