Skip to content

YARN-8056. Fix possible NPE when start Application Master - #356

Closed
yuriymalygin wants to merge 1 commit into
apache:trunkfrom
yuriymalygin:patch-1
Closed

YARN-8056. Fix possible NPE when start Application Master#356
yuriymalygin wants to merge 1 commit into
apache:trunkfrom
yuriymalygin:patch-1

Conversation

@yuriymalygin

@yuriymalyginyuriymalygin commented Mar 21, 2018

Copy link
Copy Markdown

Fix possible NPE when yarn.resourcemanager.webapp.address or yarn.resourcemanager.webapp.https.address is not set in yarn-site.xml (incomplete configuration of HA).

@yuriymalygin
Fix possible NPE when start Application Master
0a6fef7
Fix possible NPE when yarn.resourcemanager.webapp.address or yarn.resourcemanager.webapp.https.address is not set in yarn-site.xml (incomplete configuration of HA).
@yuriymalygin

yuriymalygin commented Mar 21, 2018

Copy link
Copy Markdown
Author

Create issue - https://issues.apache.org/jira/browse/YARN-8056.

@bak12

This comment has been minimized.

Sign in to view
@bak12

This comment has been minimized.

Sign in to view
@bak12

This comment has been minimized.

Sign in to view
@yuriymalyginyuriymalygin changed the title Fix possible NPE when start Application MasterYARN-8056. Fix possible NPE when start Application MasterMar 22, 2018
@hadoop-yetus

hadoop-yetus commented Jul 19, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec71Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1220trunk passed
+1compile28trunk passed
+1checkstyle18trunk passed
+1mvnsite32trunk passed
+1shadedclient789branch has no errors when building and testing our client artifacts.
+1javadoc22trunk passed
0spotbugs48Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs46trunk passed
_ Patch Compile Tests _
+1mvninstall26the patch passed
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle12the patch passed
+1mvnsite27the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient880patch has no errors when building and testing our client artifacts.
+1javadoc19the patch passed
+1findbugs48the patch passed
_ Other Tests _
+1unit55hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense28The patch does not generate ASF License warnings.
3433
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux f7dd76f5eddb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 7f1b76c
Default Java1.8.0_212
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/testReport/
Max. process+thread count306 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/1/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Jul 26, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1067trunk passed
+1compile24trunk passed
+1checkstyle15trunk passed
+1mvnsite25trunk passed
+1shadedclient633branch has no errors when building and testing our client artifacts.
+1javadoc19trunk passed
0spotbugs37Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs35trunk passed
_ Patch Compile Tests _
+1mvninstall22the patch passed
+1compile19the patch passed
+1javac19the patch passed
+1checkstyle11the patch passed
+1mvnsite22the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient681patch has no errors when building and testing our client artifacts.
+1javadoc16the patch passed
+1findbugs40the patch passed
_ Other Tests _
+1unit52hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense26The patch does not generate ASF License warnings.
2830
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 80b088d0009a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / c01e137
Default Java1.8.0_212
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/testReport/
Max. process+thread count446 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/2/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 2, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec64Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1044trunk passed
+1compile30trunk passed
+1checkstyle17trunk passed
+1mvnsite29trunk passed
+1shadedclient711branch has no errors when building and testing our client artifacts.
+1javadoc18trunk passed
0spotbugs40Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs39trunk passed
_ Patch Compile Tests _
+1mvninstall22the patch passed
+1compile21the patch passed
+1javac21the patch passed
+1checkstyle11the patch passed
+1mvnsite22the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient704patch has no errors when building and testing our client artifacts.
+1javadoc16the patch passed
+1findbugs43the patch passed
_ Other Tests _
+1unit50hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense24The patch does not generate ASF License warnings.
2944
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux f95f6b6ab0fc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / e872ceb
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/testReport/
Max. process+thread count414 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/3/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 8, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec62Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1088trunk passed
+1compile33trunk passed
+1checkstyle18trunk passed
+1mvnsite27trunk passed
+1shadedclient711branch has no errors when building and testing our client artifacts.
+1javadoc16trunk passed
0spotbugs35Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs33trunk passed
_ Patch Compile Tests _
+1mvninstall18the patch passed
+1compile15the patch passed
+1javac15the patch passed
+1checkstyle11the patch passed
+1mvnsite18the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient699patch has no errors when building and testing our client artifacts.
+1javadoc15the patch passed
+1findbugs39the patch passed
_ Other Tests _
+1unit49hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense26The patch does not generate ASF License warnings.
2969
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 4544f37b3578 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 00b5a27
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/testReport/
Max. process+thread count413 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/4/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec42Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1052trunk passed
+1compile19trunk passed
+1checkstyle13trunk passed
+1mvnsite20trunk passed
+1shadedclient639branch has no errors when building and testing our client artifacts.
+1javadoc16trunk passed
0spotbugs32Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs31trunk passed
_ Patch Compile Tests _
+1mvninstall18the patch passed
+1compile14the patch passed
+1javac14the patch passed
+1checkstyle10the patch passed
+1mvnsite16the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient692patch has no errors when building and testing our client artifacts.
+1javadoc15the patch passed
+1findbugs36the patch passed
_ Other Tests _
+1unit45hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense22The patch does not generate ASF License warnings.
2785
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 4cf554282091 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / e356e4f
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/testReport/
Max. process+thread count412 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/5/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 20, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1056trunk passed
+1compile18trunk passed
+1checkstyle13trunk passed
+1mvnsite19trunk passed
+1shadedclient653branch has no errors when building and testing our client artifacts.
+1javadoc16trunk passed
0spotbugs31Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs29trunk passed
_ Patch Compile Tests _
+1mvninstall19the patch passed
+1compile14the patch passed
+1javac14the patch passed
+1checkstyle11the patch passed
+1mvnsite16the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient689patch has no errors when building and testing our client artifacts.
+1javadoc16the patch passed
+1findbugs38the patch passed
_ Other Tests _
+1unit47hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense25The patch does not generate ASF License warnings.
2809
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 2aeb23be1a97 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 094d736
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/testReport/
Max. process+thread count447 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/6/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 22, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec78Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1304trunk passed
+1compile22trunk passed
+1checkstyle18trunk passed
+1mvnsite23trunk passed
+1shadedclient786branch has no errors when building and testing our client artifacts.
+1javadoc21trunk passed
0spotbugs37Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs34trunk passed
_ Patch Compile Tests _
+1mvninstall23the patch passed
+1compile16the patch passed
+1javac16the patch passed
+1checkstyle12the patch passed
+1mvnsite18the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient855patch has no errors when building and testing our client artifacts.
+1javadoc19the patch passed
+1findbugs42the patch passed
_ Other Tests _
+1unit54hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense27The patch does not generate ASF License warnings.
3458
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 3aa0a6ddc7e8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 61b2df2
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/testReport/
Max. process+thread count306 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/7/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 27, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec179Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1300trunk passed
+1compile26trunk passed
+1checkstyle20trunk passed
+1mvnsite31trunk passed
+1shadedclient854branch has no errors when building and testing our client artifacts.
+1javadoc25trunk passed
0spotbugs41Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs39trunk passed
_ Patch Compile Tests _
+1mvninstall24the patch passed
+1compile20the patch passed
+1javac20the patch passed
+1checkstyle14the patch passed
+1mvnsite21the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient919patch has no errors when building and testing our client artifacts.
+1javadoc20the patch passed
+1findbugs48the patch passed
_ Other Tests _
+1unit59hadoop-yarn-server-web-proxy in the patch passed.
+1asflicense33The patch does not generate ASF License warnings.
3742
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 878d972a426d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 3329257
Default Java1.8.0_222
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/testReport/
Max. process+thread count411 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/8/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Sep 3, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch11#356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
SubsystemReport/Notes
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-356/9/console
versionsgit=2.17.1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@lindong28@prateekm
SAMZA-1490: Fix TestRepartitionJoinWindowApp
42c1940
Author: Dong Lin <lindong28@gmail.com>
Reviewers: Prateek Maheshwari <prateekm@apache.org>
Closesapache#356 from lindong28/SAMZA-1490
@hadoop-yetus

hadoop-yetus commented Jul 30, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚mvninstall21m 1strunk passed
+1 💚compile0m 29strunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚compile0m 23strunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚checkstyle0m 20strunk passed
+1 💚mvnsite0m 25strunk passed
+1 💚shadedclient14m 44sbranch has no errors when building and testing our client artifacts.
-1 ❌javadoc0m 25shadoop-yarn-server-web-proxy in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚javadoc0m 20strunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗spotbugs0m 48sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs0m 46strunk passed
_ Patch Compile Tests _
+1 💚mvninstall0m 22sthe patch passed
+1 💚compile0m 20sthe patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚javac0m 20sthe patch passed
+1 💚compile0m 17sthe patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚javac0m 17sthe patch passed
+1 💚checkstyle0m 12sthe patch passed
+1 💚mvnsite0m 20sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedclient14m 10spatch has no errors when building and testing our client artifacts.
-1 ❌javadoc0m 21shadoop-yarn-server-web-proxy in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚javadoc0m 23sthe patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚findbugs0m 46sthe patch passed
_ Other Tests _
+1 💚unit0m 54shadoop-yarn-server-web-proxy in the patch passed.
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
60m 48s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 26835a5fff23 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 5d8600e
Default JavaPrivate Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadochttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadochttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/testReport/
Max. process+thread count413 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/2/console
versionsgit=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka

aajisaka commented Jul 31, 2020

Copy link
Copy Markdown
Member

-1
I think MR AppMaster should fail to start if the HA configuration is incomplete.

AmFilterInitializer#initFilter should check if the URL is null but it should throw some RuntimeException if the URL is null. In addition, MRClientService#serviceStart should not catch exceptions when starting webapp.

@hadoop-yetus

hadoop-yetus commented Jan 27, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 53sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚mvninstall35m 49strunk passed
+1 💚compile0m 30strunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile0m 23strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle0m 23strunk passed
+1 💚mvnsite0m 30strunk passed
+1 💚javadoc0m 27strunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 24strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs0m 48strunk passed
+1 💚shadedclient23m 31sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚mvninstall0m 22sthe patch passed
+1 💚compile0m 21sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac0m 21sthe patch passed
+1 💚compile0m 19sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 19sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 12sthe patch passed
+1 💚mvnsite0m 33sthe patch passed
+1 💚javadoc0m 16sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 16sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs1m 15sthe patch passed
+1 💚shadedclient24m 25spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit1m 9shadoop-yarn-server-web-proxy in the patch passed.
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
94m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/artifact/out/Dockerfile
GITHUB PR#356
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
unameLinux 1c202eb2b3b3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / 0a6fef7
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/testReport/
Max. process+thread count521 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-356/1/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka

aajisaka commented Feb 25, 2022

Copy link
Copy Markdown
Member

Closing this due to no activity.

NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024
@hchaverri@snmvaughanSteve Vaughan Jr
HADOOP-18365. Update the remote address when a change is detected (ap…
b5e7f89
…ache#4… (apache#356)
* HADOOP-18365. Update the remote address when a change is detected (apache#4692) (apache#4768)
Back port to branch-3.3, to avoid reconnecting to the old address after detecting that the address has been updated.
* Use a stable hashCode to allow safe IP addr changes
* Add test that updated address is used
Once the address has been updated, it will be used in future calls. Test verifies that a second request succeeds and that it uses the existing updated address instead of having to re-resolve.
Co-authored-by: Steve Vaughan Jr <s_vaughan@apple.com>
* ACLOVERRIDE
---------
Co-authored-by: Steve Vaughan <email@stevevaughan.me>
Co-authored-by: Steve Vaughan Jr <s_vaughan@apple.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@GolfryGolfryGolfry approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuriymalygin@bak12@hadoop-yetus@aajisaka@Golfry