MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs by skysiders · Pull Request #4237 · apache/hadoop

skysiders · 2022-04-27T09:25:51Z

MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs

Description of PR

JobSubmissionFiles provide getStagingDir to get Staging Directory.If stagingArea missing, method will create new directory with this.
fs.mkdirs(stagingArea, new FsPermission(JOB_DIR_PERMISSION));
It seems create new directory with JOB_DIR_PERMISSION,but this permission will be apply by umask.If umask too strict , this permission may be 000(if umask is 700).So we should change permission after create.

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-04-27T11:10:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 14s		trunk passed
+1 💚	compile	1m 3s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 58s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 59s		trunk passed
+1 💚	mvnsite	1m 6s		trunk passed
+1 💚	javadoc	0m 48s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 41s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 49s		trunk passed
+1 💚	shadedclient	21m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s		the patch passed
+1 💚	compile	0m 45s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 45s		the patch passed
+1 💚	compile	0m 40s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 35s	/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 12 new + 1 unchanged - 0 fixed = 13 total (was 1)
+1 💚	mvnsite	0m 44s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 27s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 32s		the patch passed
+1 💚	shadedclient	20m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	6m 28s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 50s		The patch does not generate ASF License warnings.
		102m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/1/artifact/out/Dockerfile
GITHUB PR	#4237
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 7484c0f5ccc6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a272117`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/1/testReport/
Max. process+thread count	1286 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

skysiders · 2022-05-03T07:28:51Z

In this PR , I set permission for directory with special permission after mkdir, so that the directory can has right permission

skysiders · 2022-05-03T07:29:58Z

Hi @iwasakims ,could you please take a look? Thanks

skysiders · 2022-05-05T08:08:43Z

Hi @tomscut @aajisaka , could you please take a look this?Thanks!

skysiders · 2022-07-26T13:28:05Z

Hi @cnauroth .Could you please take a look? Thanks

cnauroth · 2022-07-28T18:42:05Z

@@ -160,6 +160,7 @@ public static Path getStagingDir(Cluster cluster, Configuration conf,
 }
 } catch (FileNotFoundException e) {
 fs.mkdirs(stagingArea, new FsPermission(JOB_DIR_PERMISSION));


I suggest using static method FileSystem.mkdirs(fs, stagingArea, new FsPermission(JOB_DIR_PERMISSION)). It's one less line of code and potentially one less remote call for certain FileSystem implementations.

cnauroth · 2022-07-28T21:33:20Z

+ @Test
+ public void testDirPermission() throws Exception {
+ Cluster cluster = mock(Cluster.class);
+ HdfsConfiguration CONF = new HdfsConfiguration();


Nitpick: lower-case conf for local variables.

cnauroth · 2022-07-28T21:33:57Z

+ public void testDirPermission() throws Exception {
+ Cluster cluster = mock(Cluster.class);
+ HdfsConfiguration CONF = new HdfsConfiguration();
+ MiniDFSCluster cluster1 = new MiniDFSCluster.Builder(CONF).numDataNodes(2).build();


Suggestion: different variable name for greater clarity, e.g. dfsCluster.
Also, please use a finally block to guarantee calling MiniDFSCluster#shutdown() at the end of the test.

cnauroth · 2022-07-28T21:35:58Z

+
+ when(cluster.getStagingAreaDir()).thenReturn(stagingPath);
+ Path res = JobSubmissionFiles.getStagingDir(cluster, CONF, user);
+ assertEquals(new FsPermission(0700),fs.getFileStatus(res).getPermission());


Nitpick: please add a single space after the comma.

hadoop-yetus · 2022-07-29T12:15:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 20s		trunk passed
+1 💚	compile	1m 2s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 58s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 1s		trunk passed
+1 💚	mvnsite	1m 4s		trunk passed
+1 💚	javadoc	0m 54s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 45s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 52s		trunk passed
+1 💚	shadedclient	21m 35s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s		the patch passed
+1 💚	compile	0m 46s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 46s		the patch passed
+1 💚	compile	0m 40s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 12 new + 1 unchanged - 0 fixed = 13 total (was 1)
+1 💚	mvnsite	0m 45s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 27s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 29s		the patch passed
+1 💚	shadedclient	20m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	7m 16s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		103m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/2/artifact/out/Dockerfile
GITHUB PR	#4237
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b08e174af63f 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9896814`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/2/testReport/
Max. process+thread count	1574 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

skysiders · 2022-07-29T12:52:56Z

Hi @cnauroth , thanks for your review. I'm sorry for the problems here, I've fixed them.

hadoop-yetus · 2022-07-29T14:27:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 17s		trunk passed
+1 💚	compile	1m 2s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 59s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 1s		trunk passed
+1 💚	mvnsite	1m 5s		trunk passed
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 45s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 50s		trunk passed
+1 💚	shadedclient	21m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s		the patch passed
+1 💚	compile	0m 45s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 45s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 34s	/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 10 new + 1 unchanged - 0 fixed = 11 total (was 1)
+1 💚	mvnsite	0m 45s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 27s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 30s		the patch passed
+1 💚	shadedclient	20m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	7m 18s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 50s		The patch does not generate ASF License warnings.
		103m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/3/artifact/out/Dockerfile
GITHUB PR	#4237
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c557d62437f5 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c075f59`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/3/testReport/
Max. process+thread count	1664 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-12-23T08:28:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 2s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	0m 41s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	0m 42s		trunk passed
+1 💚	mvnsite	0m 48s		trunk passed
+1 💚	javadoc	0m 38s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
-1 ❌	spotbugs	1m 35s	/branch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 1 extant spotbugs warnings.
+1 💚	shadedclient	20m 26s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 36s		the patch passed
+1 💚	compile	0m 38s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	0m 38s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	0m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 27s		the patch passed
+1 💚	mvnsite	0m 38s		the patch passed
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 21s		the patch passed
+1 💚	shadedclient	20m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	7m 16s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		110m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/4/artifact/out/Dockerfile
GITHUB PR	#4237
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux dfd5b4f73f07 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `98a9ffe`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/4/testReport/
Max. process+thread count	1611 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4237/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth

+1

I'll plan on committing this to trunk, branch-3.3 and branch-3.2 by next week. @skysiders , sorry for my delayed response. I was losing my GitHub notifications to the spam folder for a while.

…dirs (#4237) Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 36bf54a)

…dirs (#4237) Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 36bf54a) (cherry picked from commit eef2fdc)

cnauroth · 2023-01-12T21:50:40Z

I have committed this to trunk, branch-3.3 and branch-3.2. @skysiders , thank you for the contribution.

steveloughran · 2023-01-16T16:05:04Z

how important is this for the next 3.3.5 RC

cnauroth · 2023-01-17T20:04:39Z

@steveloughran , I don't think this one is a strong candidate for the next 3.3.5 RC.

steveloughran · 2023-01-30T16:46:18Z

okay, let's cherrypick.

…dirs (#4237) Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 36bf54a)

steveloughran · 2023-01-30T16:57:28Z

sorry, @cnauroth , misread your comment and put it in -i don't think it is worth reverting now

cnauroth · 2023-01-31T00:18:24Z

@steveloughran , no problem, thanks!

skysiders added 2 commits April 27, 2022 13:02

set permission for JobSubmissionFiles
4c06114

set permission for JobSubmissionFiles
a272117

skysiders changed the title ~~Mapreduce 7375 JobSubmissionFiles don't set right permission after mkdirs~~Mapreduce-7375 JobSubmissionFiles don't set right permission after mkdirsApr 27, 2022

skysiders changed the title ~~Mapreduce-7375 JobSubmissionFiles don't set right permission after mkdirs~~MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirsApr 27, 2022

cnauroth requested changes Jul 28, 2022
View reviewed changes

Merge branch 'apache:trunk' into MAPREDUCE-7375
9896814

fix some mistakes in test code
c075f59

skysiders requested a review from cnauroth July 29, 2022 13:08

cnauroth requested changes Jul 29, 2022
View reviewed changes

Comment thread...-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestJobSubmissionFiles.java Outdated

modify checkstyle
98a9ffe

skysiders requested a review from cnauroth December 23, 2022 08:39

cnauroth approved these changes Jan 7, 2023
View reviewed changes

cnauroth merged commit 36bf54a into apache:trunkJan 12, 2023

cnauroth pushed a commit that referenced this pull request Jan 12, 2023
MAPREDUCE-7375JobSubmissionFiles don't set right permission after mk…
eef2fdc
…dirs (#4237) Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 36bf54a)

cnauroth pushed a commit that referenced this pull request Jan 12, 2023
MAPREDUCE-7375JobSubmissionFiles don't set right permission after mk…
8973a59
…dirs (#4237) Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 36bf54a) (cherry picked from commit eef2fdc)

asfgit pushed a commit that referenced this pull request Jan 30, 2023
MAPREDUCE-7375JobSubmissionFiles don't set right permission after mk…
a2fc6ee
…dirs (#4237) Signed-off-by: Chris Nauroth <cnauroth@apache.org> (cherry picked from commit 36bf54a)

Uh oh!

Conversation

skysiders commented Apr 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Apr 27, 2022

Uh oh!

skysiders commented May 3, 2022

Uh oh!

skysiders commented May 3, 2022

Uh oh!

skysiders commented May 5, 2022

Uh oh!

skysiders commented Jul 26, 2022

Uh oh!

cnaurothJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

cnaurothJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

cnaurothJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

cnaurothJul 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hadoop-yetus commented Jul 29, 2022

Uh oh!

skysiders commented Jul 29, 2022

Uh oh!

hadoop-yetus commented Jul 29, 2022

Uh oh!

Uh oh!

hadoop-yetus commented Dec 23, 2022

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

cnauroth commented Jan 12, 2023

Uh oh!

steveloughran commented Jan 16, 2023

Uh oh!

cnauroth commented Jan 17, 2023

Uh oh!

steveloughran commented Jan 30, 2023

Uh oh!

steveloughran commented Jan 30, 2023

Uh oh!

cnauroth commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skysiders commented Apr 27, 2022•
edited
Loading