Skip to content

HADOOP-15980. Securing Hadoop RPC using SSL - #4638

Closed
vnhive wants to merge 1 commit into
apache:trunkfrom
vnhive:SSL/HADOOP-15980
Closed

HADOOP-15980. Securing Hadoop RPC using SSL#4638
vnhive wants to merge 1 commit into
apache:trunkfrom
vnhive:SSL/HADOOP-15980

Conversation

@vnhive

Copy link
Copy Markdown

The work done in this pull request implements SSL support for Hadoop RPC using the following steps,

  1. Add SSL support to the RPC server
    a. Creates a RPC server implementation (Server.java) to use Netty
    b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
    c. Add SSL Handlers to the Netty Pipeline
    d. Parameterizes the RPC unit tests to run with and without SSL.
    e. Split the new classes into the constituent source files to reduce the clutter in Server.java.

  2. Add Netty support to the RPC client
    a. Creates a RPC Client implementation (Client.java) to use Netty
    b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
    c. Add SSL Handlers to the Netty Pipeline
    d. Parameterizes the RPC unit tests to run with and without Netty.
    e. Split the new classes into the constituent source files to reduce the clutter in Client.java.

  3. Add configuration to turn Netty on and off.

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

The work done in this pull request implements SSL support for Hadoop RPC using the following steps,
1. Add SSL support to the RPC server
a. Creates a RPC server implementation (Server.java) to use Netty
b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
c. Add SSL Handlers to the Netty Pipeline
d. Parameterizes the RPC unit tests to run with and without SSL.
e. Split the new classes into the constituent source files to reduce the clutter in Server.java.
2. Add Netty support to the RPC client
a. Creates a RPC Client implementation (Client.java) to use Netty
b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
c. Add SSL Handlers to the Netty Pipeline
d. Parameterizes the RPC unit tests to run with and without Netty.
e. Split the new classes into the constituent source files to reduce the clutter in Client.java.
3. Add configuration to turn Netty on and off.
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 2sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗xmllint0m 0sxmllint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 16 new or modified test files.
_ trunk Compile Tests _
+0 🆗mvndep15m 23sMaven dependency ordering for branch
+1 💚mvninstall25m 17strunk passed
+1 💚compile23m 21strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile20m 54strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle4m 28strunk passed
+1 💚mvnsite5m 42strunk passed
+1 💚javadoc4m 41strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc4m 42strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs1m 13sbranch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+1 💚shadedclient21m 37sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 38sMaven dependency ordering for patch
+1 💚mvninstall6m 42sthe patch passed
+1 💚compile22m 35sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌javac22m 35s/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txtroot-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 3 new + 2879 unchanged - 1 fixed = 2882 total (was 2880)
+1 💚compile20m 57sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌javac20m 57s/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txtroot-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu120.04-b07 generated 3 new + 2674 unchanged - 1 fixed = 2677 total (was 2675)
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle4m 19s/results-checkstyle-root.txtroot: The patch generated 175 new + 642 unchanged - 129 fixed = 817 total (was 771)
+1 💚mvnsite5m 37sthe patch passed
-1 ❌javadoc1m 40s/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txthadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚javadoc4m 51sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌spotbugs3m 16s/new-spotbugs-hadoop-common-project_hadoop-common.htmlhadoop-common-project/hadoop-common generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+0 🆗spotbugs1m 13shadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚shadedclient21m 27spatch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌unit21m 11s/patch-unit-hadoop-common-project_hadoop-common.txthadoop-common in the patch passed.
-1 ❌unit383m 34s/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txthadoop-hdfs in the patch passed.
+1 💚unit1m 36shadoop-client-minicluster in the patch passed.
+1 💚asflicense2m 2sThe patch does not generate ASF License warnings.
651m 28s
ReasonTests
SpotBugsmodule:hadoop-common-project/hadoop-common
Self assignment of field Connection.isOnAuxiliaryPort in new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:in new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:[line 148]
Uninitialized read of isOnAuxiliaryPort in new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:[line 148]
Inconsistent synchronization of org.apache.hadoop.ipc.netty.server.NioListener.selector; locked 62% of time Unsynchronized access at NioListener.java:62% of time Unsynchronized access at NioListener.java:[line 115]
new org.apache.hadoop.ipc.netty.server.NioListener(Server, int) invokes org.apache.hadoop.ipc.netty.server.NioListener$Reader.start() At NioListener.java: At NioListener.java:[line 83]
Failed junit testshadoop.ipc.TestRPC
hadoop.ipc.TestProtoBufRpc
hadoop.hdfs.TestBlockTokenWrappingQOP
hadoop.hdfs.TestMultipleNNPortQOP
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4638/1/artifact/out/Dockerfile
GITHUB PR#4638
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
unameLinux e6cc1e47eb52 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / e25d4d0
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4638/1/testReport/
Max. process+thread count3448 (vs. ulimit of 5500)
modulesC: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-client-modules/hadoop-client-minicluster U: .
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4638/1/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@github-actions

Copy link
Copy Markdown
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vnhive@hadoop-yetus