HADOOP-11223. Create UnmodifiableConfiguration by milleruntime · Pull Request #473 · apache/hadoop

milleruntime · 2019-01-28T19:28:24Z

Fixes https://issues.apache.org/jira/browse/HADOOP-11223 by creating an immutable Configuration class. This class will throw UnsupportedOperationException on any mutable method calls.

I am not sure what branch or version this is appropriate to apply to so I am doing a pull request against trunk.

milleruntime · 2019-01-29T21:28:25Z

Renaming this class to UnmodifiableConfiguration since it is not immutable. It more closely resembles the java unmodifiable collections: https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html

ctubbsii · 2019-01-30T20:38:27Z

These are probably okay to proxy.

By that, I mean that is probably okay to provide an implementation that calls this.other.writeXml(...) instead of throwing UnsupportedOperationException for these methods.

apache-yetus · 2019-02-21T19:04:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#473 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#473
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-02-21T22:38:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#473 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#473
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-02-21T22:41:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	7	#473 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#473
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-02-21T22:45:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#473 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#473
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

apache-yetus · 2019-02-22T00:27:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	20	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1059	trunk passed
+1	compile	934	trunk passed
+1	checkstyle	52	trunk passed
+1	mvnsite	81	trunk passed
+1	shadedclient	813	branch has no errors when building and testing our client artifacts.
+1	findbugs	110	trunk passed
+1	javadoc	59	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	49	the patch passed
+1	compile	943	the patch passed
+1	javac	943	the patch passed
+1	checkstyle	56	the patch passed
+1	mvnsite	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	699	patch has no errors when building and testing our client artifacts.
+1	findbugs	109	the patch passed
+1	javadoc	59	the patch passed
		_ Other Tests _
+1	unit	522	hadoop-common in the patch passed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		5731

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/5/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 77967de197fe 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `28d0bf9`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/5/testReport/
Max. process+thread count	1461 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-19T15:58:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	35	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1085	trunk passed
+1	compile	1036	trunk passed
+1	checkstyle	39	trunk passed
+1	mvnsite	74	trunk passed
+1	shadedclient	778	branch has no errors when building and testing our client artifacts.
+1	javadoc	58	trunk passed
0	spotbugs	115	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	113	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	49	the patch passed
+1	compile	986	the patch passed
+1	javac	986	the patch passed
+1	checkstyle	34	the patch passed
+1	mvnsite	66	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	643	patch has no errors when building and testing our client artifacts.
+1	javadoc	56	the patch passed
+1	findbugs	135	the patch passed
		_ Other Tests _
-1	unit	531	hadoop-common in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		5807

Reason	Tests
Failed junit tests	hadoop.util.TestDiskCheckerWithDiskIo

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/6/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4cad6603451c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `cd967c7`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/6/testReport/
Max. process+thread count	1426 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-26T17:04:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1149	trunk passed
+1	compile	1121	trunk passed
+1	checkstyle	42	trunk passed
+1	mvnsite	76	trunk passed
+1	shadedclient	840	branch has no errors when building and testing our client artifacts.
+1	javadoc	61	trunk passed
0	spotbugs	123	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	121	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	48	the patch passed
+1	compile	1021	the patch passed
+1	javac	1021	the patch passed
+1	checkstyle	43	the patch passed
+1	mvnsite	73	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	710	patch has no errors when building and testing our client artifacts.
+1	javadoc	63	the patch passed
+1	findbugs	132	the patch passed
		_ Other Tests _
+1	unit	559	hadoop-common in the patch passed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6244

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/7/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux a2102aa3fd3e 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `c7c7a88`
Default Java	1.8.0_212
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/7/testReport/
Max. process+thread count	1348 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-02T04:01:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	83	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1095	trunk passed
+1	compile	1233	trunk passed
+1	checkstyle	52	trunk passed
+1	mvnsite	83	trunk passed
+1	shadedclient	802	branch has no errors when building and testing our client artifacts.
+1	javadoc	63	trunk passed
0	spotbugs	127	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	124	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	58	the patch passed
+1	compile	1356	the patch passed
+1	javac	1356	the patch passed
+1	checkstyle	50	the patch passed
+1	mvnsite	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	638	patch has no errors when building and testing our client artifacts.
+1	javadoc	57	the patch passed
+1	findbugs	122	the patch passed
		_ Other Tests _
+1	unit	526	hadoop-common in the patch passed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		6513

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/8/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6d295867db1b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `c2d00c8`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/8/testReport/
Max. process+thread count	1406 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T05:55:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1203	trunk passed
+1	compile	1118	trunk passed
+1	checkstyle	44	trunk passed
+1	mvnsite	77	trunk passed
+1	shadedclient	861	branch has no errors when building and testing our client artifacts.
+1	javadoc	68	trunk passed
0	spotbugs	128	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	126	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	51	the patch passed
+1	compile	1001	the patch passed
+1	javac	1001	the patch passed
+1	checkstyle	47	the patch passed
+1	mvnsite	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	747	patch has no errors when building and testing our client artifacts.
+1	javadoc	65	the patch passed
+1	findbugs	143	the patch passed
		_ Other Tests _
+1	unit	565	hadoop-common in the patch passed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		6332

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/9/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 546234c2dc1b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `b0131bc`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/9/testReport/
Max. process+thread count	1475 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

ctubbsii · 2019-08-08T15:15:43Z

Is Yetus just going to keep spamming this issue indefinitely, with it never being merged? If so, I'm going to stop following this issue.

hadoop-yetus · 2019-08-16T19:52:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1170	trunk passed
+1	compile	1138	trunk passed
+1	checkstyle	42	trunk passed
+1	mvnsite	75	trunk passed
+1	shadedclient	858	branch has no errors when building and testing our client artifacts.
+1	javadoc	61	trunk passed
0	spotbugs	123	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	121	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	48	the patch passed
+1	compile	1047	the patch passed
+1	javac	1047	the patch passed
+1	checkstyle	44	the patch passed
+1	mvnsite	74	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	734	patch has no errors when building and testing our client artifacts.
+1	javadoc	66	the patch passed
+1	findbugs	136	the patch passed
		_ Other Tests _
+1	unit	559	hadoop-common in the patch passed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6317

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/10/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0d6b8c5ad101 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `e356e4f`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/10/testReport/
Max. process+thread count	1476 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-20T17:36:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	134	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1432	trunk passed
+1	compile	1291	trunk passed
+1	checkstyle	61	trunk passed
+1	mvnsite	108	trunk passed
+1	shadedclient	1075	branch has no errors when building and testing our client artifacts.
+1	javadoc	82	trunk passed
0	spotbugs	164	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	161	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	64	the patch passed
+1	compile	1223	the patch passed
+1	javac	1223	the patch passed
+1	checkstyle	55	the patch passed
+1	mvnsite	87	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	756	patch has no errors when building and testing our client artifacts.
+1	javadoc	63	the patch passed
+1	findbugs	131	the patch passed
		_ Other Tests _
-1	unit	540	hadoop-common in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		7358

Reason	Tests
Failed junit tests	hadoop.security.TestRaceWhenRelogin

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/11/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 9b0e13b8901d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `094d736`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/11/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/11/testReport/
Max. process+thread count	1339 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/11/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-22T16:47:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	77	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1254	trunk passed
+1	compile	1233	trunk passed
+1	checkstyle	47	trunk passed
+1	mvnsite	78	trunk passed
+1	shadedclient	880	branch has no errors when building and testing our client artifacts.
+1	javadoc	61	trunk passed
0	spotbugs	124	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	122	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	52	the patch passed
+1	compile	1145	the patch passed
+1	javac	1145	the patch passed
+1	checkstyle	49	the patch passed
+1	mvnsite	94	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	775	patch has no errors when building and testing our client artifacts.
+1	javadoc	64	the patch passed
+1	findbugs	131	the patch passed
		_ Other Tests _
-1	unit	585	hadoop-common in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		6753

Reason	Tests
Failed junit tests	hadoop.security.TestRaceWhenRelogin

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/12/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux dbfcfbd04a9e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 69ddb36
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/12/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/12/testReport/
Max. process+thread count	1341 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/12/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

ctubbsii · 2019-08-22T20:31:07Z

I think I might actually have to block @hadoop-yetus and @apache-yetus . It's so spammy and drowns out human conversation. I don't see value in its checks as a bot commenting in the thread for humans. It should run as an app instead, like Travis CI, etc.

EDIT: blocking doesn't seem to remove the spammy comments from my view.

hadoop-yetus · 2019-08-27T13:12:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	52	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1091	trunk passed
+1	compile	1080	trunk passed
+1	checkstyle	48	trunk passed
+1	mvnsite	86	trunk passed
+1	shadedclient	791	branch has no errors when building and testing our client artifacts.
+1	javadoc	65	trunk passed
0	spotbugs	129	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	126	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	46	the patch passed
+1	compile	1029	the patch passed
+1	javac	1029	the patch passed
+1	checkstyle	48	the patch passed
+1	mvnsite	78	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	672	patch has no errors when building and testing our client artifacts.
+1	javadoc	72	the patch passed
+1	findbugs	140	the patch passed
		_ Other Tests _
+1	unit	590	hadoop-common in the patch passed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		6135

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-473/13/artifact/out/Dockerfile
GITHUB PR	#473
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 1d05847d1084 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3329257`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/13/testReport/
Max. process+thread count	1378 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-473/13/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

ctubbsii · 2019-08-27T17:23:31Z

Can somebody from Hadoop respond to this PR? Please either merge it or close it as rejected. The spam from the yetus bot is overwhelming, annoying, and unnecessary.

milleruntime · 2019-08-27T19:35:00Z

Closing to stop the yetus spam.

ctubbsii · 2019-08-27T21:16:39Z

Thanks @milleruntime ; while I would have preferred a response from the Hadoop developers, I suppose that is the second best option.

* Tests to benchmark the performance of the system consumers and producers. * Config to test the benchmark for the event hub system producer and consumer. SystemConsumerBench and SystemProducerBench provides base generic implementation to test the benchmark for the system producers and consumers. Any new system that needs benchmark test needs a properties file. The benchmark test itself is single threaded in the way it consumes and produces events. Scaling the benchmark tests right now involves running multiple processes of these tests in parallel. Right now we just calculate the event rate, But in future we could create a logging metrics registry to hookup other metrics and log them in console along with event rate while the benchmark tests are being run. Author: Srinivasulu Punuru <spunuru@linkedin.com> Reviewers: Jagadish <jagadish@apache.org>, Wei Song<wsong@linkedin.com> Closesapache#473 from srinipunuru/benchmark.1

milleruntime changed the title ~~HADOOP-11223. Create ImmutableConfiguration~~HADOOP-11223. Create UnmodifiableConfigurationJan 29, 2019

ctubbsii reviewed Jan 30, 2019
View reviewed changes

milleruntime closed this Feb 12, 2019

milleruntime reopened this Feb 21, 2019

HADOOP-11223. Create UnmodifiableConfiguration
e9a2ba3

milleruntime force-pushed the immutable-conf branch from de10b99 to e9a2ba3Compare February 21, 2019 22:51

milleruntime closed this Aug 27, 2019

Uh oh!

Conversation

milleruntime commented Jan 28, 2019

Uh oh!

milleruntime commented Jan 29, 2019

Uh oh!

ctubbsiiJan 30, 2019

Choose a reason for hiding this comment

Uh oh!

ctubbsiiSep 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apache-yetus commented Feb 21, 2019

Uh oh!

apache-yetus commented Feb 21, 2019

Uh oh!

apache-yetus commented Feb 21, 2019

Uh oh!

apache-yetus commented Feb 21, 2019

Uh oh!

apache-yetus commented Feb 22, 2019

Uh oh!

hadoop-yetus commented Jul 19, 2019

Uh oh!

hadoop-yetus commented Jul 26, 2019

Uh oh!

hadoop-yetus commented Aug 2, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

ctubbsii commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 16, 2019

Uh oh!

hadoop-yetus commented Aug 20, 2019

Uh oh!

hadoop-yetus commented Aug 22, 2019

Uh oh!

ctubbsii commented Aug 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Aug 27, 2019

Uh oh!

ctubbsii commented Aug 27, 2019

Uh oh!

milleruntime commented Aug 27, 2019

Uh oh!

ctubbsii commented Aug 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ctubbsiiSep 4, 2019•
edited
Loading

ctubbsii commented Aug 22, 2019•
edited
Loading