Skip to content

YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore. - #4741

Merged
goiri merged 5 commits into
apache:trunkfrom
slfan1989:YARN-11252
Aug 19, 2022
Merged

YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.#4741
goiri merged 5 commits into
apache:trunkfrom
slfan1989:YARN-11252

Conversation

@slfan1989

@slfan1989slfan1989 commented Aug 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

JIRA:YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.

@slfan1989slfan1989 changed the title YARN-11252. Yarn Federation Router Supports Update /Delete Reservation in MemoryStore.YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.Aug 14, 2022
@hadoop-yetus

hadoop-yetus commented Aug 14, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗mvndep14m 51sMaven dependency ordering for branch
+1 💚mvninstall25m 25strunk passed
+1 💚compile4m 5strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile3m 23strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 33strunk passed
+1 💚mvnsite2m 19strunk passed
+1 💚javadoc2m 5strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 55strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 57strunk passed
+1 💚shadedclient21m 45sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for patch
+1 💚mvninstall1m 38sthe patch passed
+1 💚compile3m 49sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌javac3m 49s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 6 new + 443 unchanged - 6 fixed = 449 total (was 449)
+1 💚compile3m 16sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌javac3m 16s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu120.04-b07 generated 6 new + 367 unchanged - 6 fixed = 373 total (was 373)
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle1m 7s/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txthadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11)
+1 💚mvnsite1m 47sthe patch passed
+1 💚javadoc1m 30sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 27sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 39sthe patch passed
+1 💚shadedclient21m 24spatch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌unit3m 1s/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txthadoop-yarn-server-common in the patch passed.
+1 💚unit98m 32shadoop-yarn-server-resourcemanager in the patch passed.
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
225m 8s
ReasonTests
Failed junit testshadoop.yarn.server.federation.policies.router.TestRejectRouterPolicy
hadoop.yarn.server.federation.policies.router.TestLoadBasedRouterPolicy
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/1/artifact/out/Dockerfile
GITHUB PR#4741
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 7a6bc526b942 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / dfec706
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/1/testReport/
Max. process+thread count953 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/1/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 14, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗mvndep14m 50sMaven dependency ordering for branch
+1 💚mvninstall25m 31strunk passed
+1 💚compile4m 3strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile3m 32strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 31strunk passed
+1 💚mvnsite2m 15strunk passed
+1 💚javadoc2m 7strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 55strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 59strunk passed
+1 💚shadedclient21m 41sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for patch
+1 💚mvninstall1m 39sthe patch passed
+1 💚compile3m 48sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌javac3m 48s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 6 new + 443 unchanged - 6 fixed = 449 total (was 449)
+1 💚compile3m 17sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌javac3m 17s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu120.04-b07 generated 6 new + 367 unchanged - 6 fixed = 373 total (was 373)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 25sthe patch passed
+1 💚mvnsite1m 59sthe patch passed
+1 💚javadoc1m 34sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 23sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs4m 1sthe patch passed
+1 💚shadedclient22m 14spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit3m 3shadoop-yarn-server-common in the patch passed.
+1 💚unit98m 14shadoop-yarn-server-resourcemanager in the patch passed.
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
225m 58s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/2/artifact/out/Dockerfile
GITHUB PR#4741
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux d29c72836f81 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / 6d11426
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/2/testReport/
Max. process+thread count959 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/2/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989

slfan1989 commented Aug 15, 2022

Copy link
Copy Markdown
ContributorAuthor

@goiri Please help to review the code, this part of the code completes the operations of update and delete Reservation.Thank you very much!

@hadoop-yetus

hadoop-yetus commented Aug 15, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗mvndep14m 50sMaven dependency ordering for branch
+1 💚mvninstall25m 3strunk passed
+1 💚compile4m 7strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile3m 31strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 29strunk passed
+1 💚mvnsite2m 17strunk passed
+1 💚javadoc2m 8strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 54strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 56strunk passed
+1 💚shadedclient21m 37sbranch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for patch
+1 💚mvninstall1m 40sthe patch passed
+1 💚compile3m 48sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javac3m 48sthe patch passed
+1 💚compile3m 17sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac3m 17sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 13sthe patch passed
+1 💚mvnsite1m 50sthe patch passed
+1 💚javadoc1m 28sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 27sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 40sthe patch passed
+1 💚shadedclient21m 34spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit3m 2shadoop-yarn-server-common in the patch passed.
+1 💚unit98m 39shadoop-yarn-server-resourcemanager in the patch passed.
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
225m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/3/artifact/out/Dockerfile
GITHUB PR#4741
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux acea50bd79f9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / f75a555
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/3/testReport/
Max. process+thread count993 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/3/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

goiri
goiri approved these changes Aug 15, 2022
View reviewed changes
Comment thread...src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java
TResult invoke(T input) throws Exception;
}


@goirigoiriAug 15, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid

@slfan1989slfan1989Aug 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your help reviewing the code, I will fix it.

@hadoop-yetus

hadoop-yetus commented Aug 16, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗mvndep14m 51sMaven dependency ordering for branch
+1 💚mvninstall25m 17strunk passed
+1 💚compile4m 4strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile3m 34strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 31strunk passed
+1 💚mvnsite2m 21strunk passed
+1 💚javadoc2m 8strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 56strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 55strunk passed
+1 💚shadedclient21m 46sbranch has no errors when building and testing our client artifacts.
-0 ⚠️patch22m 14sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for patch
+1 💚mvninstall1m 39sthe patch passed
+1 💚compile3m 50sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌javac3m 50s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 6 new + 443 unchanged - 6 fixed = 449 total (was 449)
+1 💚compile3m 17sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌javac3m 17s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu120.04-b07 generated 6 new + 367 unchanged - 6 fixed = 373 total (was 373)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 11sthe patch passed
+1 💚mvnsite1m 47sthe patch passed
+1 💚javadoc1m 31sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 27sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 38sthe patch passed
+1 💚shadedclient21m 28spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit3m 15shadoop-yarn-server-common in the patch passed.
+1 💚unit98m 49shadoop-yarn-server-resourcemanager in the patch passed.
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
226m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/4/artifact/out/Dockerfile
GITHUB PR#4741
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux 9fb7c0f636df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / 0c23966
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/4/testReport/
Max. process+thread count949 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/4/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Aug 18, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗mvndep15m 18sMaven dependency ordering for branch
+1 💚mvninstall26m 7strunk passed
+1 💚compile4m 23strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile3m 41strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 30strunk passed
+1 💚mvnsite2m 7strunk passed
+1 💚javadoc1m 50strunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 34strunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 47strunk passed
+1 💚shadedclient22m 11sbranch has no errors when building and testing our client artifacts.
-0 ⚠️patch22m 37sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for patch
+1 💚mvninstall1m 35sthe patch passed
+1 💚compile4m 15sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌javac4m 15s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 6 new + 443 unchanged - 6 fixed = 449 total (was 449)
+1 💚compile3m 35sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌javac3m 35s/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txthadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu120.04-b07 generated 6 new + 367 unchanged - 6 fixed = 373 total (was 373)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 12sthe patch passed
+1 💚mvnsite1m 56sthe patch passed
+1 💚javadoc1m 28sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc1m 21sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚spotbugs3m 48sthe patch passed
+1 💚shadedclient23m 1spatch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚unit3m 5shadoop-yarn-server-common in the patch passed.
+1 💚unit98m 44shadoop-yarn-server-resourcemanager in the patch passed.
+1 💚asflicense0m 46sThe patch does not generate ASF License warnings.
229m 7s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/5/artifact/out/Dockerfile
GITHUB PR#4741
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
unameLinux e41a05447740 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/bin/hadoop.sh
git revisiontrunk / bd8240b
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/5/testReport/
Max. process+thread count950 (vs. ulimit of 5500)
modulesC: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4741/5/console
versionsgit=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989

slfan1989 commented Aug 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@goiri Can you help merge this pr into trunk branch? I will follow up with YARN-11177. Thank you very much!

@goiri
goiri merged commit f75c58a into apache:trunkAug 19, 2022
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@slfan1989HarshitGupta11
YARN-11252. Yarn Federation Router Supports Update / Delete Reservati…
a2c2eac
…on in MemoryStore. (apache#4741)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goirigoirigoiri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slfan1989@hadoop-yetus@goiri