Skip to content

HDDS-1151. Propagate the tracing id in ScmBlockLocationProtocol - #508

Closed
elek wants to merge 2 commits into
apache:trunkfrom
elek:HDDS-1151
Closed

HDDS-1151. Propagate the tracing id in ScmBlockLocationProtocol#508
elek wants to merge 2 commits into
apache:trunkfrom
elek:HDDS-1151

Conversation

@elek

@elekelek commented Feb 21, 2019

Copy link
Copy Markdown
Member

The tracing propagation is not yet enabled for the ScmBlockLocationProtocol. We can't see the internal calls between OM and SCM. We need to propagate it at least for the allocateBlock call.

See: https://issues.apache.org/jira/browse/HDDS-1151

@elekelek added the ozone label Feb 21, 2019
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec535Docker mode activated.
_ Prechecks _
+1@author1The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0mvndep79Maven dependency ordering for branch
+1mvninstall1244trunk passed
-1compile211root in trunk failed.
+1checkstyle212trunk passed
-1mvnsite20server-scm in trunk failed.
-1mvnsite18objectstore-service in trunk failed.
-1mvnsite16ozone-manager in trunk failed.
+1shadedclient1076branch has no errors when building and testing our client artifacts.
-1findbugs14server-scm in trunk failed.
-1findbugs14objectstore-service in trunk failed.
-1findbugs14ozone-manager in trunk failed.
-1javadoc13server-scm in trunk failed.
-1javadoc14objectstore-service in trunk failed.
-1javadoc14ozone-manager in trunk failed.
_ Patch Compile Tests _
0mvndep23Maven dependency ordering for patch
-1mvninstall10server-scm in the patch failed.
-1mvninstall11objectstore-service in the patch failed.
-1mvninstall10ozone-manager in the patch failed.
+1compile988the patch passed
-1cc988root generated 7 new + 2 unchanged - 0 fixed = 9 total (was 2)
-1javac988root generated 660 new + 831 unchanged - 0 fixed = 1491 total (was 831)
+1checkstyle203the patch passed
-1mvnsite23server-scm in the patch failed.
-1mvnsite22objectstore-service in the patch failed.
-1mvnsite19ozone-manager in the patch failed.
+1whitespace0The patch has no whitespace issues.
+1shadedclient711patch has no errors when building and testing our client artifacts.
-1findbugs23server-scm in the patch failed.
-1findbugs22objectstore-service in the patch failed.
-1findbugs22ozone-manager in the patch failed.
-1javadoc23server-scm in the patch failed.
-1javadoc22objectstore-service in the patch failed.
-1javadoc23ozone-manager in the patch failed.
_ Other Tests _
-1unit86common in the patch failed.
-1unit22server-scm in the patch failed.
-1unit22objectstore-service in the patch failed.
-1unit23ozone-manager in the patch failed.
+1asflicense40The patch does not generate ASF License warnings.
6161
ReasonTests
Failed junit testshadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/Dockerfile
GITHUB PR#508
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux ad263b04c014 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 6cec906
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-compile-root.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugsv3.1.0-RC1
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-findbugs-hadoop-ozone_objectstore-service.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-javadoc-hadoop-hdds_server-scm.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-javadoc-hadoop-ozone_objectstore-service.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/branch-javadoc-hadoop-ozone_ozone-manager.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-mvninstall-hadoop-ozone_objectstore-service.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt
cchttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/diff-compile-cc-root.txt
javachttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/diff-compile-javac-root.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-findbugs-hadoop-ozone_objectstore-service.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-javadoc-hadoop-hdds_server-scm.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-javadoc-hadoop-ozone_objectstore-service.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-unit-hadoop-hdds_common.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-unit-hadoop-ozone_objectstore-service.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/testReport/
Max. process+thread count305 (vs. ulimit of 5500)
modulesC: hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-508/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@elekelek closed this Mar 7, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Need to add override keyword for overriding a method in scala 2.12.
Author: xiliu <xiliu@linkedin.com>
Reviewers: Prateek M <prateekm@apache.org>
Closesapache#508 from xinyuiscool/SAMZA-1704
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@elek@hadoop-yetus