Skip to content

HDDS-1148. After allocating container, we are not adding to container DB. - #511

Merged
nandakumar131 merged 2 commits into
apache:trunkfrom
bharatviswa504:HDDS-1148
Feb 22, 2019
Merged

HDDS-1148. After allocating container, we are not adding to container DB.#511
nandakumar131 merged 2 commits into
apache:trunkfrom
bharatviswa504:HDDS-1148

Conversation

@bharatviswa504

@bharatviswa504bharatviswa504 commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

No description provided.

nandakumar131
nandakumar131 reviewed Feb 21, 2019
View reviewed changes
Comment thread...-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java Outdated
Comment thread...-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
Comment thread...-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java Outdated
@apache-yetus

apache-yetus commented Feb 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec26Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1340trunk passed
-1compile28server-scm in trunk failed.
-0checkstyle17The patch fails to run checkstyle in server-scm
-1mvnsite13server-scm in trunk failed.
+1shadedclient734branch has no errors when building and testing our client artifacts.
-1findbugs13server-scm in trunk failed.
-1javadoc21server-scm in trunk failed.
_ Patch Compile Tests _
-1mvninstall11server-scm in the patch failed.
-1compile10server-scm in the patch failed.
-1javac10server-scm in the patch failed.
-0checkstyle9The patch fails to run checkstyle in server-scm
-1mvnsite11server-scm in the patch failed.
+1whitespace0The patch has no whitespace issues.
+1shadedclient791patch has no errors when building and testing our client artifacts.
-1findbugs12server-scm in the patch failed.
-1javadoc13server-scm in the patch failed.
_ Other Tests _
-1unit15server-scm in the patch failed.
+1asflicense27The patch does not generate ASF License warnings.
3191
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 4426ca5c8520 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / b17a260
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/branch-compile-hadoop-hdds_server-scm.txt
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out//testptch/patchprocess/maven-branch-checkstyle-hadoop-hdds_server-scm.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/branch-javadoc-hadoop-hdds_server-scm.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-compile-hadoop-hdds_server-scm.txt
javachttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-compile-hadoop-hdds_server-scm.txt
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out//testptch/patchprocess/maven-patch-checkstyle-hadoop-hdds_server-scm.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-javadoc-hadoop-hdds_server-scm.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/testReport/
Max. process+thread count339 (vs. ulimit of 5500)
modulesC: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apache-yetus

apache-yetus commented Feb 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec41Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1068trunk passed
-1compile25server-scm in trunk failed.
-0checkstyle14The patch fails to run checkstyle in server-scm
-1mvnsite15server-scm in trunk failed.
+1shadedclient722branch has no errors when building and testing our client artifacts.
-1findbugs15server-scm in trunk failed.
-1javadoc17server-scm in trunk failed.
_ Patch Compile Tests _
-1mvninstall11server-scm in the patch failed.
-1compile10server-scm in the patch failed.
-1javac10server-scm in the patch failed.
-0checkstyle9The patch fails to run checkstyle in server-scm
-1mvnsite11server-scm in the patch failed.
+1whitespace0The patch has no whitespace issues.
+1shadedclient764patch has no errors when building and testing our client artifacts.
-1findbugs14server-scm in the patch failed.
-1javadoc13server-scm in the patch failed.
_ Other Tests _
-1unit15server-scm in the patch failed.
+1asflicense27The patch does not generate ASF License warnings.
2889
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/Dockerfile
GITHUB PR#511
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 29030c11742b 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / d33f066
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/branch-compile-hadoop-hdds_server-scm.txt
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out//testptch/patchprocess/maven-branch-checkstyle-hadoop-hdds_server-scm.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/branch-javadoc-hadoop-hdds_server-scm.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-compile-hadoop-hdds_server-scm.txt
javachttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-compile-hadoop-hdds_server-scm.txt
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out//testptch/patchprocess/maven-patch-checkstyle-hadoop-hdds_server-scm.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-javadoc-hadoop-hdds_server-scm.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/testReport/
Max. process+thread count339 (vs. ulimit of 5500)
modulesC: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-511/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@nandakumar131
nandakumar131 merged commit 7057980 into apache:trunkFeb 22, 2019
@bharatviswa504
bharatviswa504 deleted the HDDS-1148 branch February 23, 2019 19:23
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@lhaiesp@jagadish-v0
SAMZA-1706: lazy initialization for eventhub system producer
9d404bc
We are seeing slow shutdown issue for eventhub system producers for users who only use eventhub consumer (but then Samza system creates both consumer and producer together no matter what). As a workaround, add lazy initialization to the producer to avoid the slow shutdown
Author: Hai Lu <halu@linkedin.com>
Reviewers: Jagadish <jagadish@apache.org>
Closesapache#511 from lhaiesp/master
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandakumar131nandakumar131nandakumar131 left review comments

Assignees

@bharatviswa504bharatviswa504

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bharatviswa504@apache-yetus@nandakumar131