Skip to content

HDDS-1158. TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error. - #512

Merged
bharatviswa504 merged 1 commit into
apache:trunkfrom
hanishakoneru:HDDS-1158
Feb 23, 2019
Merged

HDDS-1158. TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error.#512
bharatviswa504 merged 1 commit into
apache:trunkfrom
hanishakoneru:HDDS-1158

Conversation

@hanishakoneru

@hanishakoneruhanishakoneru commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Fixes failing test TestOzoneManagerHA#testTwoOMNodesDown()

@apache-yetus

apache-yetus commented Feb 21, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec25Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1mvninstall1193trunk passed
-1compile34integration-test in trunk failed.
-0checkstyle10The patch fails to run checkstyle in integration-test
-1mvnsite12integration-test in trunk failed.
+1shadedclient628branch has no errors when building and testing our client artifacts.
0findbugs0Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1findbugs0trunk passed
-1javadoc13integration-test in trunk failed.
_ Patch Compile Tests _
-1mvninstall9integration-test in the patch failed.
-1compile9integration-test in the patch failed.
-1javac9integration-test in the patch failed.
-0checkstyle7The patch fails to run checkstyle in integration-test
-1mvnsite9integration-test in the patch failed.
+1whitespace0The patch has no whitespace issues.
+1shadedclient697patch has no errors when building and testing our client artifacts.
0findbugs0Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1findbugs0the patch passed
-1javadoc14integration-test in the patch failed.
_ Other Tests _
-1unit12integration-test in the patch failed.
+1asflicense25The patch does not generate ASF License warnings.
2786
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/Dockerfile
GITHUB PR#512
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux a13b17ebb2b0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / b17a260
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/branch-compile-hadoop-ozone_integration-test.txt
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out//testptch/patchprocess/maven-branch-checkstyle-hadoop-ozone_integration-test.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
compilehttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
javachttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out//testptch/patchprocess/maven-patch-checkstyle-hadoop-ozone_integration-test.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/testReport/
Max. process+thread count446 (vs. ulimit of 5500)
modulesC: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-512/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504

bharatviswa504 commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

I am +1 with the change.
Will commit it shortly.

@bharatviswa504
bharatviswa504 merged commit d0e21ac into apache:trunkFeb 23, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@cameronlee314@xinyuiscool
SAMZA-1709: Use lazy creation for SystemAdmins in ApplicationRunners
7fc39e5
An instance of SystemAdmins is created when instantiating any AbstractApplicationRunner, but the SystemAdmins is only actually needed for some of the methods for some of the runners. For example, LocalApplicationRunner.kill does not need SystemAdmins, and LocalContainerRunner does not need SystemAdmins for anything.
Doing lazy instantiation allows us to more easily manage the SystemAdmins lifecycle, since it removes the need to add lifecycle hooks for the ApplicationRunner.
This also fixes the lifecycle management for SystemAdmins in ApplicationRunners.
Author: Cameron Lee <calee@linkedin.com>
Reviewers: Xinyu Liu <xinyu@apache.org>
Closesapache#512 from cameronlee314/runnner_system_admins
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharatviswa504bharatviswa504bharatviswa504 left review comments

Assignees

No one assigned

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanishakoneru@apache-yetus@bharatviswa504