Skip to content

HDDS-1120. Add a config to disable checksum verification during read … - #513

Merged
bharatviswa504 merged 2 commits into
apache:trunkfrom
bharatviswa504:HDDS-1120
Feb 24, 2019
Merged

HDDS-1120. Add a config to disable checksum verification during read …#513
bharatviswa504 merged 2 commits into
apache:trunkfrom
bharatviswa504:HDDS-1120

Conversation

@bharatviswa504

Copy link
Copy Markdown
Contributor

…even though checksum data is present in the persisted data.

@apache-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec29Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0mvndep164Maven dependency ordering for branch
+1mvninstall1085trunk passed
+1compile1046trunk passed
+1checkstyle192trunk passed
-1mvnsite32client in trunk failed.
-1mvnsite26client in trunk failed.
-1mvnsite27integration-test in trunk failed.
-1mvnsite22objectstore-service in trunk failed.
-1mvnsite22ozone-manager in trunk failed.
-1shadedclient1092branch has errors when building and testing our client artifacts.
0findbugs0Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1findbugs22client in trunk failed.
-1findbugs20client in trunk failed.
-1findbugs23objectstore-service in trunk failed.
-1findbugs26ozone-manager in trunk failed.
-1javadoc31client in trunk failed.
-1javadoc19client in trunk failed.
-1javadoc21integration-test in trunk failed.
-1javadoc25objectstore-service in trunk failed.
-1javadoc22ozone-manager in trunk failed.
_ Patch Compile Tests _
0mvndep23Maven dependency ordering for patch
-1mvninstall9client in the patch failed.
-1mvninstall13client in the patch failed.
-1mvninstall11integration-test in the patch failed.
-1mvninstall11objectstore-service in the patch failed.
-1mvninstall11ozone-manager in the patch failed.
+1compile896the patch passed
+1javac896the patch passed
+1checkstyle186the patch passed
-1mvnsite30client in the patch failed.
-1mvnsite34client in the patch failed.
-1mvnsite29integration-test in the patch failed.
-1mvnsite28objectstore-service in the patch failed.
-1mvnsite28ozone-manager in the patch failed.
+1whitespace0The patch has no whitespace issues.
+1xml1The patch has no ill-formed XML file.
+1shadedclient639patch has no errors when building and testing our client artifacts.
0findbugs0Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1findbugs25client in the patch failed.
-1findbugs20client in the patch failed.
-1findbugs26objectstore-service in the patch failed.
-1findbugs22ozone-manager in the patch failed.
-1javadoc24client in the patch failed.
-1javadoc28client in the patch failed.
-1javadoc19integration-test in the patch failed.
-1javadoc20objectstore-service in the patch failed.
-1javadoc21ozone-manager in the patch failed.
_ Other Tests _
-1unit18client in the patch failed.
-1unit72common in the patch failed.
-1unit26client in the patch failed.
-1unit26integration-test in the patch failed.
-1unit26objectstore-service in the patch failed.
-1unit27ozone-manager in the patch failed.
+1asflicense49The patch does not generate ASF License warnings.
6636
ReasonTests
Failed junit testshadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/Dockerfile
GITHUB PR#513
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
unameLinux b57bbaf70983 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / b17a260
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-hdds_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugsv3.1.0-RC1
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-hdds_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-ozone_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-ozone_objectstore-service.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-hdds_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_objectstore-service.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/branch-javadoc-hadoop-ozone_ozone-manager.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-hdds_client.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_client.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_objectstore-service.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-hdds_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-hdds_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-ozone_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-ozone_objectstore-service.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-hdds_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_objectstore-service.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-hdds_client.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-hdds_common.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_client.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_objectstore-service.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/testReport/
Max. process+thread count444 (vs. ulimit of 5500)
modulesC: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apache-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec23Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0mvndep23Maven dependency ordering for branch
+1mvninstall1004trunk passed
+1compile933trunk passed
+1checkstyle190trunk passed
-1mvnsite39client in trunk failed.
-1mvnsite25client in trunk failed.
-1mvnsite25integration-test in trunk failed.
-1mvnsite21objectstore-service in trunk failed.
-1mvnsite18ozone-manager in trunk failed.
+1shadedclient1040branch has no errors when building and testing our client artifacts.
0findbugs0Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1findbugs20client in trunk failed.
-1findbugs20client in trunk failed.
-1findbugs17objectstore-service in trunk failed.
-1findbugs16ozone-manager in trunk failed.
-1javadoc19client in trunk failed.
-1javadoc21client in trunk failed.
-1javadoc22integration-test in trunk failed.
-1javadoc18objectstore-service in trunk failed.
-1javadoc20ozone-manager in trunk failed.
_ Patch Compile Tests _
0mvndep23Maven dependency ordering for patch
-1mvninstall9client in the patch failed.
-1mvninstall10client in the patch failed.
-1mvninstall10integration-test in the patch failed.
-1mvninstall10objectstore-service in the patch failed.
-1mvninstall11ozone-manager in the patch failed.
+1compile908the patch passed
+1javac908the patch passed
+1checkstyle185the patch passed
-1mvnsite27client in the patch failed.
-1mvnsite28client in the patch failed.
-1mvnsite27integration-test in the patch failed.
-1mvnsite27objectstore-service in the patch failed.
-1mvnsite27ozone-manager in the patch failed.
+1whitespace0The patch has no whitespace issues.
+1xml2The patch has no ill-formed XML file.
+1shadedclient670patch has no errors when building and testing our client artifacts.
0findbugs0Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1findbugs27client in the patch failed.
-1findbugs29client in the patch failed.
-1findbugs27objectstore-service in the patch failed.
-1findbugs28ozone-manager in the patch failed.
-1javadoc28client in the patch failed.
-1javadoc28client in the patch failed.
-1javadoc27integration-test in the patch failed.
-1javadoc29objectstore-service in the patch failed.
-1javadoc27ozone-manager in the patch failed.
_ Other Tests _
-1unit28client in the patch failed.
-1unit86common in the patch failed.
-1unit27client in the patch failed.
-1unit27integration-test in the patch failed.
-1unit28objectstore-service in the patch failed.
-1unit28ozone-manager in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
6289
ReasonTests
Failed junit testshadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/Dockerfile
GITHUB PR#513
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
unameLinux e71be91c9703 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / ed13cf8
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-hdds_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugsv3.1.0-RC1
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-hdds_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-ozone_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-ozone_objectstore-service.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-hdds_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_integration-test.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_objectstore-service.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/branch-javadoc-hadoop-ozone_ozone-manager.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-hdds_client.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_client.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_objectstore-service.txt
mvninstallhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-hdds_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_client.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_objectstore-service.txt
mvnsitehttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-hdds_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-ozone_client.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-ozone_objectstore-service.txt
findbugshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-hdds_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_client.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_objectstore-service.txt
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-hdds_client.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-hdds_common.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_client.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_objectstore-service.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/testReport/
Max. process+thread count411 (vs. ulimit of 5500)
modulesC: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager U: .
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-513/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
bharatviswa504 merged commit 106bdc6 into apache:trunkFeb 24, 2019
@bharatviswa504
bharatviswa504 deleted the HDDS-1120 branch February 24, 2019 05:38
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
RocksDB Snapshots and any iterators obtained from them need to be closed before the store is closed.
Otherwise the process aborts with the following message (at least on OSX):
`Assertion failed: (is_last_reference), function ~ColumnFamilyData, file db/column_family.cc, line 457.`
Author: Prateek Maheshwari <pmaheshw@linkedin.com>
Reviewers: Jagadish V <vjagadish1989@gmail.com>
Closesapache#513 from prateekm/rocksdb-test-fi
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bharatviswa504@apache-yetus