Uh oh!
There was an error while loading. Please reload this page.
HDDS-1180. TestRandomKeyGenerator fails with NPE - #519
Closed
elek wants to merge 1 commit into
Closed
Conversation
hadoop-yetus
commented
Feb 26, 2019
💔 -1 overall
This message was automatically generated. |
elek
commented
Feb 26, 2019
MemberAuthor
See the ci/ozone/unit: Only one unit tests are failed: TestRandomKeyGenerator.ratisTest3 which is not a NPE any more. |
bharatviswa504
commented
Feb 27, 2019
Contributor
+1 LGTM. |
bharatviswa504
commented
Feb 27, 2019
Contributor
This has been already fixed and committed by HDDS-1174. |
shanthoosh added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…rrupts. **Problem:** If a thread executing zkClient.close is interrupted, currently we swallow the ZkInterruptedException and proceed without closing the zookeeper connection. This leads to ephemeral nodes of StreamProcessor lurking around in zookeeper after StreamProcessor shutdown. Users had to wait till zookeeper server session timeout for the ephemeral nodes to get deleted. **Change:** Retry once on InterruptedException when closing the zkClient. Misc changes: * Remove unnecessary null checks. * Remove unnecessary typecasts. Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com> Reviewers: Jagadish <jagadish@apache.org> Closesapache#519 from shanthoosh/handle_interrupted_exception_in_zkclient_close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://issues.apache.org/jira/browse/HDDS-1180