Skip to content

HDDS-1182. Pipeline Rule where atleast one datanode is reported in the pipeline. - #528

Merged
bharatviswa504 merged 3 commits into
apache:trunkfrom
bharatviswa504:HDDS-1182
Mar 1, 2019
Merged

HDDS-1182. Pipeline Rule where atleast one datanode is reported in the pipeline.#528
bharatviswa504 merged 3 commits into
apache:trunkfrom
bharatviswa504:HDDS-1182

Conversation

@bharatviswa504

@bharatviswa504bharatviswa504 commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@bharatviswa504bharatviswa504 self-assigned this Feb 28, 2019
@hadoop-yetus

hadoop-yetus commented Feb 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec24Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0mvndep30Maven dependency ordering for branch
+1mvninstall983trunk passed
+1compile76trunk passed
+1checkstyle32trunk passed
+1mvnsite77trunk passed
+1shadedclient760branch has no errors when building and testing our client artifacts.
+1findbugs110trunk passed
+1javadoc61trunk passed
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
+1mvninstall76the patch passed
+1compile67the patch passed
+1javac67the patch passed
+1checkstyle24the patch passed
+1mvnsite62the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml1The patch has no ill-formed XML file.
+1shadedclient739patch has no errors when building and testing our client artifacts.
+1findbugs121the patch passed
+1javadoc57the patch passed
_ Other Tests _
-1unit70common in the patch failed.
+1unit137server-scm in the patch passed.
+1asflicense29The patch does not generate ASF License warnings.
3593
ReasonTests
Failed junit testshadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-528/1/artifact/out/Dockerfile
GITHUB PR#528
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
unameLinux 561cb5a46c9b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 1779fc5
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
findbugsv3.1.0-RC1
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/1/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/1/testReport/
Max. process+thread count543 (vs. ulimit of 5500)
modulesC: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Feb 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec25Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0mvndep34Maven dependency ordering for branch
+1mvninstall1186trunk passed
+1compile76trunk passed
+1checkstyle29trunk passed
+1mvnsite71trunk passed
+1shadedclient809branch has no errors when building and testing our client artifacts.
+1findbugs111trunk passed
+1javadoc58trunk passed
_ Patch Compile Tests _
0mvndep11Maven dependency ordering for patch
+1mvninstall74the patch passed
+1compile72the patch passed
+1javac72the patch passed
+1checkstyle24the patch passed
+1mvnsite62the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml1The patch has no ill-formed XML file.
+1shadedclient793patch has no errors when building and testing our client artifacts.
+1findbugs140the patch passed
+1javadoc66the patch passed
_ Other Tests _
-1unit89common in the patch failed.
+1unit143server-scm in the patch passed.
+1asflicense28The patch does not generate ASF License warnings.
3958
ReasonTests
Failed junit testshadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-528/2/artifact/out/Dockerfile
GITHUB PR#528
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
unameLinux a90d96c64096 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 0feba43
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
findbugsv3.1.0-RC1
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/2/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/2/testReport/
Max. process+thread count477 (vs. ulimit of 5500)
modulesC: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

arp7
arp7 approved these changes Mar 1, 2019
View reviewed changes

@arp7arp7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadoop-yetus

hadoop-yetus commented Mar 1, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec26Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0mvndep27Maven dependency ordering for branch
+1mvninstall989trunk passed
+1compile76trunk passed
+1checkstyle31trunk passed
+1mvnsite73trunk passed
+1shadedclient735branch has no errors when building and testing our client artifacts.
+1findbugs100trunk passed
+1javadoc52trunk passed
_ Patch Compile Tests _
0mvndep9Maven dependency ordering for patch
+1mvninstall65the patch passed
+1compile65the patch passed
+1javac65the patch passed
+1checkstyle21the patch passed
+1mvnsite58the patch passed
+1whitespace0The patch has no whitespace issues.
+1xml1The patch has no ill-formed XML file.
+1shadedclient663patch has no errors when building and testing our client artifacts.
+1findbugs113the patch passed
+1javadoc48the patch passed
_ Other Tests _
-1unit68common in the patch failed.
+1unit123server-scm in the patch passed.
+1asflicense23The patch does not generate ASF License warnings.
3401
ReasonTests
Failed junit testshadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-528/3/artifact/out/Dockerfile
GITHUB PR#528
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
unameLinux de32c33a8a2a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / eae3db9
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
findbugsv3.1.0-RC1
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/3/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/3/testReport/
Max. process+thread count537 (vs. ulimit of 5500)
modulesC: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-528/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504

bharatviswa504 commented Mar 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank You @arp7 for review.
Test failures are not related to the patch.
Ran tests locally and they passed.
I will commit this shortly.

@bharatviswa504
bharatviswa504 merged commit 77b23c8 into apache:trunkMar 1, 2019
@bharatviswa504
bharatviswa504 deleted the HDDS-1182 branch March 1, 2019 05:41
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@srinipunuru@xinyuiscool
Implementing the fetchSinkInfo in ConfigBasedIOResolver
171793b
1. I think we missed implementing the fetchSinkInfo method in the ConfigBasedResolver when the API was introduced which is breaking the samza sql console tool. This fixes it.
2. latest release of mac removed realpath so the command line tools are broken. Removed the usage of realpath to fix these tools.
Thanks to nickpan47 for identifying these problems.
Author: Srinivasulu Punuru <spunuru@linkedin.com>
Reviewers: Yi Pan <nickpan47@gmail.com>
Closesapache#528 from srinipunuru/release-fix.1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arp7arp7arp7 approved these changes
@nandakumar131nandakumar131Awaiting requested review from nandakumar131

Assignees

@bharatviswa504bharatviswa504

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bharatviswa504@hadoop-yetus@arp7