Uh oh!
There was an error while loading. Please reload this page.
HADOOP-14630 Contract Tests to verify create, mkdirs and rename under a file is forbidden - #533
Closed
steveloughran wants to merge 6 commits into
Closed
Conversation
hadoop-yetus
commented
Feb 28, 2019
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
commented
Mar 4, 2019
💔 -1 overall
This message was automatically generated. |
steveloughran
commented
Mar 4, 2019
ContributorAuthor
Whitespace is from an error file. I deny (direct) responsibility |
steveloughranforce-pushed
the
filesystem/HADOOP-14630-create-under-file
branch
from
March 9, 2019 16:15
10fd31d to
2615fb3Comparehadoop-yetus
commented
Mar 9, 2019
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
commented
Jul 19, 2019
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
commented
Jul 26, 2019
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
commented
Aug 2, 2019
💔 -1 overall
This message was automatically generated. |
… a file is forbidden
…nting createNonRecursive Change-Id: If826ad1d893c8c9733d6259cb5d7e4d986df49e4
…leSystemMetricsSystem; intermittent failure during testing Change-Id: I884de58f555908fbd867f82a078e04bf86849413
…ion if the direct parent is a file Change-Id: Id53f1245068a078d682c37391b618b9de64db52a
this has happened in 2 places now; I'm going to make it something which stores can declare they do Change-Id: I60aa2d68cd2f9f2e511972b6c799d10348d82578
…d a new switch to allow filesystems to delcare they permit this. S3A contact XML adds the flag; Swift does not -it does check, at a cost in performance. Change-Id: Ifd40c6a58f6ac8cc9eeb83168e0449de59313dfd tested: s3a, abfs, swift. my ADL login is no longer valid.
steveloughranforce-pushed
the
filesystem/HADOOP-14630-create-under-file
branch
from
August 23, 2019 18:56
2615fb3 to
fac64e5Compare| The path must either be a directory or not exist | ||
| No ancestor may be a file | ||
| forall d = ancestors(FS, p) : |
| No ancestor may be a file | ||
| forall d = ancestors(FS, p) : |
hadoop-yetus
commented
Aug 23, 2019
💔 -1 overall
This message was automatically generated. |
| The path must either be a directory or not exist | ||
| No ancestor may be a file | ||
| forall d = ancestors(FS, p) : |
| No ancestor may be a file | ||
| forall d = ancestors(FS, p) : |
hadoop-yetus
commented
Aug 27, 2019
💔 -1 overall
This message was automatically generated. |
| The path must either be a directory or not exist | ||
| No ancestor may be a file | ||
| forall d = ancestors(FS, p) : |
| No ancestor may be a file | ||
| forall d = ancestors(FS, p) : |
hadoop-yetus
commented
Sep 3, 2019
💔 -1 overall
This message was automatically generated. |
shanthoosh pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…g partition while choosing. Author: Aditya Toomula <atoomula@linkedin.com> Reviewers: Jagadish<jagadish@apache.org> Closesapache#533 from atoomula/chooser
liuml07
approved these changes
Mar 7, 2020
liuml07
left a comment
Member
There was a problem hiding this comment.
+1 once rebased again and a QA. Do you think we can backport this to all 2.10+ branches?
| expectMkdirsUnderFileFails("mkdirs() file/dir", | ||
| grandparent, child); | ||
| try { |
Member
There was a problem hiding this comment.
Do we need another mkdirs(child) test here? I thought it's already tested in above expectMkdirsUnderFileFails().
Is this for verbose logging output? I mean,
handleRelaxedException(action,
"ParentNotDirectoryException",
e);
v.s.
handleRelaxedException("creating a file under a subdirectory of a file ",
"FileAlreadyExistsException",
e);
ContributorAuthor
There was a problem hiding this comment.
just being curious about deeper creation .. those object stores are so troublesome here
Member
There was a problem hiding this comment.
Yes I think this test testMkdirUnderFileSubdir makes perfect sense. In this test, I was assuming the whole try-catch clause is having the same logic (except exception handling) as the call to expectMkdirsUnderFileFails() in LoC 376 in this method.
steveloughran
commented
Mar 9, 2020
ContributorAuthor
thx for the merge -no obvious issues with a backport |
steveloughran
commented
Mar 9, 2020
ContributorAuthor
merged; closing. Thanks for looking @ this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HADOOP-14630. Contract Tests to verify create, mkdirs and rename under a file is forbidden