Skip to content

HDFS-14350:dfs.datanode.ec.reconstruction.threads not take effect - #582

Closed
hunshenshi wants to merge 2 commits into
apache:trunkfrom
hunshenshi:HDFS-14350
Closed

HDFS-14350:dfs.datanode.ec.reconstruction.threads not take effect#582
hunshenshi wants to merge 2 commits into
apache:trunkfrom
hunshenshi:HDFS-14350

Conversation

@hunshenshi

Copy link
Copy Markdown
Contributor

In ErasureCodingWorker, stripedReconstructionPool is create by

initializeStripedBlkReconstructionThreadPool(conf.getInt(
DFSConfigKeys.DFS_DN_EC_RECONSTRUCTION_THREADS_KEY,
DFSConfigKeys.DFS_DN_EC_RECONSTRUCTION_THREADS_DEFAULT));
privatevoidinitializeStripedBlkReconstructionThreadPool(intnumThreads) {
LOG.debug("Using striped block reconstruction; pool threads={}",
numThreads);
stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
numThreads, 60, newLinkedBlockingQueue<>(),
"StripedBlockReconstruction-", false);
stripedReconstructionPool.allowCoreThreadTimeOut(true);
}

so stripedReconstructionPool is a ThreadPoolExecutor, and the queue is a LinkedBlockingQueue, then the active thread is awalys 2, the dfs.datanode.ec.reconstruction.threads not take effect.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec27Docker mode activated.
_ Prechecks _
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1017trunk passed
+1compile61trunk passed
+1checkstyle53trunk passed
+1mvnsite66trunk passed
+1shadedclient767branch has no errors when building and testing our client artifacts.
+1findbugs118trunk passed
+1javadoc48trunk passed
_ Patch Compile Tests _
+1mvninstall56the patch passed
+1compile52the patch passed
+1javac52the patch passed
+1checkstyle42the patch passed
+1mvnsite56the patch passed
+1whitespace1The patch has no whitespace issues.
+1shadedclient673patch has no errors when building and testing our client artifacts.
+1findbugs125the patch passed
+1javadoc48the patch passed
_ Other Tests _
-1unit4591hadoop-hdfs in the patch failed.
+1asflicense38The patch does not generate ASF License warnings.
7886
ReasonTests
Failed junit testshadoop.hdfs.web.TestWebHdfsTimeouts
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/1/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux ac62574b9078 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / c072458
mavenversion: Apache Maven 3.3.9
Default Java1.8.0_191
findbugsv3.1.0-RC1
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/1/testReport/
Max. process+thread count4795 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec92Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1240trunk passed
+1compile64trunk passed
+1checkstyle41trunk passed
+1mvnsite67trunk passed
+1shadedclient821branch has no errors when building and testing our client artifacts.
+1javadoc56trunk passed
0spotbugs190Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs188trunk passed
_ Patch Compile Tests _
+1mvninstall70the patch passed
+1compile63the patch passed
+1javac63the patch passed
+1checkstyle39the patch passed
+1mvnsite66the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient778patch has no errors when building and testing our client artifacts.
+1javadoc54the patch passed
+1findbugs202the patch passed
_ Other Tests _
-1unit6634hadoop-hdfs in the patch failed.
+1asflicense34The patch does not generate ASF License warnings.
10582
ReasonTests
Failed junit testshadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
hadoop.hdfs.server.namenode.ha.TestEditLogTailer
hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
hadoop.hdfs.server.datanode.TestDirectoryScanner
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/2/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 4f713509fdb7 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / cd967c7
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/2/testReport/
Max. process+thread count2861 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/2/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec85Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1112trunk passed
+1compile64trunk passed
+1checkstyle41trunk passed
+1mvnsite69trunk passed
+1shadedclient762branch has no errors when building and testing our client artifacts.
-1javadoc24hadoop-hdfs in trunk failed.
0spotbugs166Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs164trunk passed
_ Patch Compile Tests _
+1mvninstall65the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle36the patch passed
+1mvnsite62the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient678patch has no errors when building and testing our client artifacts.
+1javadoc50the patch passed
+1findbugs169the patch passed
_ Other Tests _
-1unit6382hadoop-hdfs in the patch failed.
-1asflicense33The patch generated 1 ASF License warnings.
9894
ReasonTests
Failed junit testshadoop.hdfs.server.namenode.TestAuditLoggerWithCommands
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/3/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 6ff9f36636f3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / c7c7a88
Default Java1.8.0_212
javadochttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/3/testReport/
asflicensehttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/3/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4578 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/3/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec78Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1209trunk passed
+1compile71trunk passed
+1checkstyle50trunk passed
+1mvnsite81trunk passed
+1shadedclient903branch has no errors when building and testing our client artifacts.
+1javadoc52trunk passed
0spotbugs188Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs185trunk passed
_ Patch Compile Tests _
+1mvninstall75the patch passed
+1compile66the patch passed
+1javac66the patch passed
+1checkstyle39the patch passed
+1mvnsite70the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient807patch has no errors when building and testing our client artifacts.
+1javadoc51the patch passed
+1findbugs182the patch passed
_ Other Tests _
-1unit6367hadoop-hdfs in the patch failed.
+1asflicense34The patch does not generate ASF License warnings.
10365
ReasonTests
Failed junit testshadoop.hdfs.server.datanode.TestLargeBlockReport
hadoop.hdfs.tools.TestDFSZKFailoverController
hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
hadoop.hdfs.server.namenode.ha.TestHASafeMode
hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
hadoop.hdfs.server.namenode.TestDecommissioningStatus
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/4/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux d40cb95b3f21 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / e20b195
Default Java1.8.0_222
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/4/testReport/
Max. process+thread count3634 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/4/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec52Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1073trunk passed
+1compile57trunk passed
+1checkstyle42trunk passed
+1mvnsite65trunk passed
+1shadedclient732branch has no errors when building and testing our client artifacts.
+1javadoc48trunk passed
0spotbugs170Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs167trunk passed
_ Patch Compile Tests _
+1mvninstall60the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle36the patch passed
+1mvnsite63the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient721patch has no errors when building and testing our client artifacts.
+1javadoc52the patch passed
+1findbugs169the patch passed
_ Other Tests _
-1unit4974hadoop-hdfs in the patch failed.
-1asflicense31The patch generated 4 ASF License warnings.
8479
ReasonTests
Failed junit testshadoop.hdfs.server.datanode.TestLargeBlockReport
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.datanode.TestDirectoryScanner
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/5/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 007c7e0882a6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / b0131bc
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/5/testReport/
asflicensehttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/5/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4338 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/5/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1173trunk passed
+1compile52trunk passed
+1checkstyle38trunk passed
+1mvnsite58trunk passed
+1shadedclient722branch has no errors when building and testing our client artifacts.
+1javadoc48trunk passed
0spotbugs159Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs157trunk passed
_ Patch Compile Tests _
+1mvninstall56the patch passed
+1compile49the patch passed
+1javac49the patch passed
+1checkstyle34the patch passed
+1mvnsite56the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient685patch has no errors when building and testing our client artifacts.
+1javadoc45the patch passed
+1findbugs176the patch passed
_ Other Tests _
-1unit5151hadoop-hdfs in the patch failed.
+1asflicense29The patch does not generate ASF License warnings.
8650
ReasonTests
Failed junit testshadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/6/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 2f8024efd289 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / e356e4f
Default Java1.8.0_222
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/6/testReport/
Max. process+thread count4151 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/6/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang

Copy link
Copy Markdown
Contributor

I am not sure this is the right fix -- reading at the code, clients keeps 2 threads even during idle, and dfs.datanode.ec.reconstruction.threads specifies the max number of threads. That looks reasonable.
Perhaps all we should do is to update the description of the configuration key in hdfs-default.xml.

@hunshenshi

Copy link
Copy Markdown
ContributorAuthor

hi, @jojochuang Thanks for review.
The queue of ThreadPoolExecutor is a LinkedBlockingQueue, the queue will not be filled, so the max num will not take effect. So I think the active thread is awalys 2, dfs.datanode.ec.reconstruction.threads not take effect.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec33Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1222trunk passed
+1compile64trunk passed
+1checkstyle46trunk passed
+1mvnsite71trunk passed
+1shadedclient845branch has no errors when building and testing our client artifacts.
+1javadoc53trunk passed
0spotbugs174Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs171trunk passed
_ Patch Compile Tests _
+1mvninstall65the patch passed
+1compile57the patch passed
+1javac57the patch passed
+1checkstyle42the patch passed
+1mvnsite69the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient809patch has no errors when building and testing our client artifacts.
+1javadoc53the patch passed
+1findbugs183the patch passed
_ Other Tests _
-1unit5277hadoop-hdfs in the patch failed.
-1asflicense37The patch generated 1 ASF License warnings.
9149
ReasonTests
Failed junit testshadoop.hdfs.server.namenode.ha.TestPipelinesFailover
hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
hadoop.hdfs.server.namenode.ha.TestHASafeMode
hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
hadoop.hdfs.server.namenode.TestFsck
hadoop.hdfs.tools.TestDFSZKFailoverController
hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/7/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux e0a6ef064c5d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 094d736
Default Java1.8.0_222
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/7/testReport/
asflicensehttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/7/artifact/out/patch-asflicense-problems.txt
Max. process+thread count3364 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/7/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec46Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1047trunk passed
+1compile58trunk passed
+1checkstyle40trunk passed
+1mvnsite62trunk passed
+1shadedclient738branch has no errors when building and testing our client artifacts.
+1javadoc47trunk passed
0spotbugs162Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs160trunk passed
_ Patch Compile Tests _
+1mvninstall61the patch passed
+1compile53the patch passed
+1javac53the patch passed
+1checkstyle39the patch passed
+1mvnsite59the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient675patch has no errors when building and testing our client artifacts.
+1javadoc50the patch passed
+1findbugs158the patch passed
_ Other Tests _
-1unit4839hadoop-hdfs in the patch failed.
-1asflicense31The patch generated 1 ASF License warnings.
8210
ReasonTests
Failed junit testshadoop.hdfs.server.namenode.TestSaveNamespace
hadoop.hdfs.server.namenode.ha.TestHASafeMode
hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/8/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux 26c166f75554 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 69ddb36
Default Java1.8.0_222
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/8/testReport/
asflicensehttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/8/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4421 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/8/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec38Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1030trunk passed
+1compile65trunk passed
+1checkstyle45trunk passed
+1mvnsite70trunk passed
+1shadedclient783branch has no errors when building and testing our client artifacts.
+1javadoc54trunk passed
0spotbugs159Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs156trunk passed
_ Patch Compile Tests _
+1mvninstall62the patch passed
+1compile57the patch passed
+1javac57the patch passed
+1checkstyle40the patch passed
+1mvnsite65the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient728patch has no errors when building and testing our client artifacts.
+1javadoc54the patch passed
+1findbugs162the patch passed
_ Other Tests _
-1unit5070hadoop-hdfs in the patch failed.
+1asflicense42The patch does not generate ASF License warnings.
8590
ReasonTests
Failed junit testshadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
hadoop.hdfs.server.namenode.TestAddStripedBlocks
hadoop.hdfs.TestErasureCodingExerciseAPIs
hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/9/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux c49c2b7bea1a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 3329257
Default Java1.8.0_222
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/9/testReport/
Max. process+thread count5101 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/9/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec52Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
-1test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1mvninstall1293trunk passed
+1compile68trunk passed
+1checkstyle49trunk passed
+1mvnsite78trunk passed
+1shadedclient970branch has no errors when building and testing our client artifacts.
+1javadoc63trunk passed
0spotbugs169Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs167trunk passed
_ Patch Compile Tests _
+1mvninstall65the patch passed
+1compile63the patch passed
+1javac63the patch passed
+1checkstyle40the patch passed
+1mvnsite68the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient739patch has no errors when building and testing our client artifacts.
+1javadoc54the patch passed
+1findbugs171the patch passed
_ Other Tests _
-1unit5279hadoop-hdfs in the patch failed.
+1asflicense37The patch does not generate ASF License warnings.
9324
ReasonTests
Failed junit testshadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
hadoop.hdfs.TestMultipleNNPortQOP
hadoop.hdfs.server.datanode.TestBPOfferService
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-582/10/artifact/out/Dockerfile
GITHUB PR#582
JIRA IssueHDFS-14350
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
unameLinux b4895b1fe5a4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 915cbc9
Default Java1.8.0_222
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/10/testReport/
Max. process+thread count4181 (vs. ulimit of 5500)
modulesC: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-582/10/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Handle end of stream envelopes in bootstrap chooser and don't invoke check offsets since offset of end of stream are not comparable.
Author: Bharath Kumarasubramanian <bkumaras@linkedin.com>
Reviewers: Xinyu Liu <xinyu@apache.org>
Closesapache#582 from bharathkk/end-of-stream
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 5s#582 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
SubsystemReport/Notes
GITHUB PR#582
JIRA IssueHDFS-14350
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-582/3/console
versionsgit=2.17.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 4s#582 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
SubsystemReport/Notes
GITHUB PR#582
JIRA IssueHDFS-14350
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-582/4/console
versionsgit=2.17.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 6s#582 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
SubsystemReport/Notes
GITHUB PR#582
JIRA IssueHDFS-14350
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-582/1/console
versionsgit=2.17.1
Powered byApache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 18s#582 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
SubsystemReport/Notes
GITHUB PR#582
JIRA IssueHDFS-14350
Console outputhttps://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-582/1/console
versionsgit=2.17.1
Powered byApache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@github-actions

Copy link
Copy Markdown
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hunshenshi@hadoop-yetus@jojochuang