HDDS-1119. DN get OM certificate from SCM CA for block token validat… by ajayydv · Pull Request #601 · apache/hadoop

ajayydv · 2019-03-13T18:48:22Z

…ion. Contributed by Ajay Kumar.

hadoop-yetus · 2019-03-13T18:50:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	8	#601 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#601
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-13T18:58:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	8	#601 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#601
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-13T22:04:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#601 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#601
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-13T22:34:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#601 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#601
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao · 2019-03-13T22:47:08Z

NIT: @return should be updated.

xiaoyuyao · 2019-03-13T22:47:28Z

Javadoc copy paste error like above, this one set and does not return.

hadoop-yetus · 2019-03-14T03:49:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	7	#601 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#601
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/8/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-14T16:04:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	11	#601 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#601
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/11/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-14T18:46:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	28	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 23 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	22	Maven dependency ordering for branch
+1	mvninstall	982	trunk passed
+1	compile	959	trunk passed
+1	checkstyle	194	trunk passed
+1	mvnsite	323	trunk passed
+1	shadedclient	1244	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	60	hadoop-hdds/container-service in trunk has 1 extant Findbugs warnings.
+1	javadoc	264	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
-1	mvninstall	19	dist in the patch failed.
-1	mvninstall	25	integration-test in the patch failed.
+1	compile	925	the patch passed
+1	cc	925	the patch passed
+1	javac	925	the patch passed
+1	checkstyle	193	the patch passed
+1	mvnsite	307	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	676	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	301	the patch passed
+1	javadoc	210	the patch passed
		_ Other Tests _
+1	unit	88	common in the patch passed.
-1	unit	73	container-service in the patch failed.
+1	unit	114	server-scm in the patch passed.
+1	unit	47	common in the patch passed.
+1	unit	35	dist in the patch passed.
-1	unit	697	integration-test in the patch failed.
+1	unit	57	ozone-manager in the patch passed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		8118

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 11395b071d45 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d60673c
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/testReport/
Max. process+thread count	3477 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/14/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-14T18:48:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
0	yamllint	1	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 23 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	62	Maven dependency ordering for branch
+1	mvninstall	1047	trunk passed
+1	compile	1100	trunk passed
+1	checkstyle	204	trunk passed
+1	mvnsite	338	trunk passed
+1	shadedclient	1295	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	58	hadoop-hdds/container-service in trunk has 1 extant Findbugs warnings.
+1	javadoc	241	trunk passed
		_ Patch Compile Tests _
0	mvndep	19	Maven dependency ordering for patch
-1	mvninstall	17	dist in the patch failed.
-1	mvninstall	24	integration-test in the patch failed.
+1	compile	930	the patch passed
+1	cc	930	the patch passed
+1	javac	930	the patch passed
+1	checkstyle	199	the patch passed
+1	mvnsite	282	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	699	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	326	the patch passed
-1	javadoc	48	hadoop-hdds_common generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
		_ Other Tests _
+1	unit	100	common in the patch passed.
+1	unit	76	container-service in the patch passed.
+1	unit	118	server-scm in the patch passed.
+1	unit	44	common in the patch passed.
+1	unit	31	dist in the patch passed.
-1	unit	847	integration-test in the patch failed.
+1	unit	70	ozone-manager in the patch passed.
+1	asflicense	48	The patch does not generate ASF License warnings.
		8626

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.om.TestOmInit

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux c5a38e9be3b0 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d60673c
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/artifact/out/diff-javadoc-javadoc-hadoop-hdds_common.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/testReport/
Max. process+thread count	3859 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/13/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-14T22:59:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
0	yamllint	1	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	65	Maven dependency ordering for branch
+1	mvninstall	986	trunk passed
+1	compile	969	trunk passed
+1	checkstyle	190	trunk passed
+1	mvnsite	351	trunk passed
+1	shadedclient	1260	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	59	hadoop-hdds/container-service in trunk has 1 extant Findbugs warnings.
+1	javadoc	266	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
-1	mvninstall	19	dist in the patch failed.
-1	mvninstall	25	integration-test in the patch failed.
+1	compile	919	the patch passed
+1	cc	919	the patch passed
+1	javac	919	the patch passed
+1	checkstyle	189	the patch passed
+1	mvnsite	308	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	658	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	344	the patch passed
+1	javadoc	264	the patch passed
		_ Other Tests _
+1	unit	74	common in the patch passed.
-1	unit	84	container-service in the patch failed.
+1	unit	122	server-scm in the patch passed.
+1	unit	47	common in the patch passed.
+1	unit	34	dist in the patch passed.
-1	unit	702	integration-test in the patch failed.
+1	unit	58	ozone-manager in the patch passed.
+1	asflicense	52	The patch does not generate ASF License warnings.
		8284

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.TestDatanodeStateMachine
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux f91e458bcc76 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `091a664`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/testReport/
Max. process+thread count	3922 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/15/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-14T23:40:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	21	Maven dependency ordering for branch
+1	mvninstall	1044	trunk passed
+1	compile	966	trunk passed
+1	checkstyle	203	trunk passed
-1	mvnsite	36	container-service in trunk failed.
-1	mvnsite	38	server-scm in trunk failed.
-1	mvnsite	37	integration-test in trunk failed.
-1	mvnsite	35	ozone-manager in trunk failed.
+1	shadedclient	1214	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	32	container-service in trunk failed.
-1	findbugs	31	server-scm in trunk failed.
-1	findbugs	32	ozone-manager in trunk failed.
+1	javadoc	240	trunk passed
		_ Patch Compile Tests _
0	mvndep	19	Maven dependency ordering for patch
-1	mvninstall	17	dist in the patch failed.
+1	compile	930	the patch passed
+1	cc	930	the patch passed
+1	javac	930	the patch passed
+1	checkstyle	203	the patch passed
+1	mvnsite	283	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	695	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	320	the patch passed
+1	javadoc	239	the patch passed
		_ Other Tests _
+1	unit	99	common in the patch passed.
-1	unit	77	container-service in the patch failed.
+1	unit	115	server-scm in the patch passed.
+1	unit	44	common in the patch passed.
+1	unit	30	dist in the patch passed.
-1	unit	881	integration-test in the patch failed.
+1	unit	69	ozone-manager in the patch passed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		8309

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.TestDatanodeStateMachine
	hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.client.rpc.TestBCSID

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux e0ab2a69d251 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `091a664`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/testReport/
Max. process+thread count	4157 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/16/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-15T01:17:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	59	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	41	Maven dependency ordering for branch
+1	mvninstall	1324	trunk passed
+1	compile	1429	trunk passed
+1	checkstyle	265	trunk passed
+1	mvnsite	368	trunk passed
+1	shadedclient	1504	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	63	hadoop-hdds/container-service in trunk has 1 extant Findbugs warnings.
+1	javadoc	245	trunk passed
		_ Patch Compile Tests _
0	mvndep	28	Maven dependency ordering for patch
-1	mvninstall	18	dist in the patch failed.
-1	mvninstall	31	integration-test in the patch failed.
+1	compile	970	the patch passed
+1	cc	970	the patch passed
+1	javac	970	the patch passed
+1	checkstyle	250	the patch passed
+1	mvnsite	330	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	766	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	375	the patch passed
+1	javadoc	271	the patch passed
		_ Other Tests _
+1	unit	90	common in the patch passed.
-1	unit	86	container-service in the patch failed.
-1	unit	153	server-scm in the patch failed.
+1	unit	54	common in the patch passed.
+1	unit	39	dist in the patch passed.
-1	unit	950	integration-test in the patch failed.
-1	unit	65	ozone-manager in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		10006

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineUtils
	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.security.TestOzoneDelegationTokenSecretManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 657729f16ec8 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `091a664`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/testReport/
Max. process+thread count	2780 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/17/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-15T02:08:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	20	Maven dependency ordering for branch
+1	mvninstall	1030	trunk passed
+1	compile	964	trunk passed
+1	checkstyle	237	trunk passed
-1	mvnsite	40	container-service in trunk failed.
-1	mvnsite	40	server-scm in trunk failed.
-1	mvnsite	38	integration-test in trunk failed.
-1	mvnsite	34	ozone-manager in trunk failed.
+1	shadedclient	1281	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	31	container-service in trunk failed.
-1	findbugs	34	server-scm in trunk failed.
-1	findbugs	37	ozone-manager in trunk failed.
+1	javadoc	243	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
-1	mvninstall	17	dist in the patch failed.
+1	compile	932	the patch passed
+1	cc	932	the patch passed
+1	javac	932	the patch passed
+1	checkstyle	204	the patch passed
+1	mvnsite	285	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	704	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	324	the patch passed
+1	javadoc	241	the patch passed
		_ Other Tests _
+1	unit	100	common in the patch passed.
-1	unit	78	container-service in the patch failed.
+1	unit	116	server-scm in the patch passed.
+1	unit	44	common in the patch passed.
+1	unit	29	dist in the patch passed.
-1	unit	880	integration-test in the patch failed.
-1	unit	72	ozone-manager in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		8504

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.TestDatanodeStateMachine
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.security.TestOzoneDelegationTokenSecretManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 40797069f256 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `091a664`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/testReport/
Max. process+thread count	5044 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/18/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao · 2019-03-15T03:33:19Z

Should we loadAllCertificates() again only if the map does not contain it?
Also, in the contsructor when we call loadAllCertificates(), should we asset the passing in certSerialId is loaded into the map from file system?

initialized local certificate during initial call to loadAllCertificates. Now if it is null at L202 than it is also not present in map, so loading it again from filesystem and checking it again is the only option.

We can assert in constructor if certSerialId is not null than its corresponding certificate should not be null as well after loading from memory but if we fail than it will become catch 22 for some recovery scenarios. (Ex we can't even create instance of CertificateClient to call init which may handle some of the automatic recovery in future)

Let's discuss and file follow up JIRAs. I'm OK with the current approach as-is.

xiaoyuyao · 2019-03-15T03:38:29Z

why do we need to change s3secret manager here from interface to impl? seems not relate to this ticket.

S3SecretManagerImpl has helper function to return OMMetadataManager required in secret store. Its interface doesn't. Since it is returning a dependency i think its better to not push it to interface itself.

xiaoyuyao · 2019-03-15T03:40:59Z

Thanks @ajayydv for the update. We are almost there. Just few last issues as commented inline.

hadoop-yetus · 2019-03-15T08:01:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	19	Maven dependency ordering for branch
+1	mvninstall	1029	trunk passed
+1	compile	961	trunk passed
+1	checkstyle	201	trunk passed
-1	mvnsite	37	container-service in trunk failed.
-1	mvnsite	39	server-scm in trunk failed.
-1	mvnsite	36	integration-test in trunk failed.
-1	mvnsite	34	ozone-manager in trunk failed.
+1	shadedclient	1212	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	32	container-service in trunk failed.
-1	findbugs	32	server-scm in trunk failed.
-1	findbugs	32	ozone-manager in trunk failed.
+1	javadoc	238	trunk passed
		_ Patch Compile Tests _
0	mvndep	19	Maven dependency ordering for patch
-1	mvninstall	17	dist in the patch failed.
-1	mvninstall	22	integration-test in the patch failed.
+1	compile	923	the patch passed
+1	cc	923	the patch passed
+1	javac	923	the patch passed
+1	checkstyle	199	the patch passed
+1	mvnsite	279	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	705	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	83	hadoop-hdds/common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	javadoc	238	the patch passed
		_ Other Tests _
+1	unit	102	common in the patch passed.
-1	unit	78	container-service in the patch failed.
+1	unit	115	server-scm in the patch passed.
+1	unit	43	common in the patch passed.
+1	unit	30	dist in the patch passed.
-1	unit	879	integration-test in the patch failed.
-1	unit	69	ozone-manager in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		8265

Reason	Tests
FindBugs	module:hadoop-hdds/common
	Return value of putIfAbsent is ignored, but cert is reused in org.apache.hadoop.hdds.security.x509.certificate.client.DefaultCertificateClient.loadAllCertificates() At DefaultCertificateClient.java:ignored, but cert is reused in org.apache.hadoop.hdds.security.x509.certificate.client.DefaultCertificateClient.loadAllCertificates() At DefaultCertificateClient.java:[line 126]
Failed junit tests	hadoop.ozone.container.common.TestDatanodeStateMachine
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.security.TestOzoneDelegationTokenSecretManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux c0d94c7854e5 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `9001508`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/new-findbugs-hadoop-hdds_common.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/testReport/
Max. process+thread count	3808 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/19/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao · 2019-03-15T18:17:55Z

Thanks @ajayydv for the update. +1 the latest push, pending fix of the related findbugs issue and unit test results.

hadoop-yetus · 2019-03-15T18:39:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	59	Maven dependency ordering for branch
+1	mvninstall	1025	trunk passed
+1	compile	951	trunk passed
+1	checkstyle	191	trunk passed
+1	mvnsite	356	trunk passed
+1	shadedclient	1280	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	60	hadoop-hdds/container-service in trunk has 1 extant Findbugs warnings.
+1	javadoc	267	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
-1	mvninstall	19	dist in the patch failed.
-1	mvninstall	24	integration-test in the patch failed.
+1	compile	916	the patch passed
+1	cc	916	the patch passed
+1	javac	916	the patch passed
+1	checkstyle	194	the patch passed
+1	mvnsite	310	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	705	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	86	hadoop-hdds/common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	javadoc	266	the patch passed
		_ Other Tests _
+1	unit	89	common in the patch passed.
-1	unit	73	container-service in the patch failed.
+1	unit	114	server-scm in the patch passed.
+1	unit	48	common in the patch passed.
+1	unit	35	dist in the patch passed.
-1	unit	690	integration-test in the patch failed.
+1	unit	55	ozone-manager in the patch passed.
+1	asflicense	48	The patch does not generate ASF License warnings.
		8352

Reason	Tests
FindBugs	module:hadoop-hdds/common
	Possible null pointer dereference of cert in org.apache.hadoop.hdds.security.x509.certificate.client.DefaultCertificateClient.loadAllCertificates() Dereferenced at DefaultCertificateClient.java:cert in org.apache.hadoop.hdds.security.x509.certificate.client.DefaultCertificateClient.loadAllCertificates() Dereferenced at DefaultCertificateClient.java:[line 130]
Failed junit tests	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 7cf37c6f3d64 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / a7f5e74
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/new-findbugs-hadoop-hdds_common.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/testReport/
Max. process+thread count	4512 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/20/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-15T23:46:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	22	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	21	Maven dependency ordering for branch
+1	mvninstall	979	trunk passed
+1	compile	970	trunk passed
+1	checkstyle	193	trunk passed
+1	mvnsite	259	trunk passed
+1	shadedclient	1103	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	51	hadoop-hdds/container-service in trunk has 1 extant Findbugs warnings.
+1	javadoc	216	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
-1	mvninstall	18	dist in the patch failed.
-1	mvninstall	23	integration-test in the patch failed.
-1	compile	50	root in the patch failed.
-1	cc	50	root in the patch failed.
-1	javac	50	root in the patch failed.
+1	checkstyle	189	the patch passed
+1	mvnsite	189	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedclient	187	patch has errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	8	common in the patch failed.
-1	findbugs	11	container-service in the patch failed.
-1	findbugs	8	server-scm in the patch failed.
-1	findbugs	22	common in the patch failed.
-1	findbugs	22	ozone-manager in the patch failed.
-1	javadoc	23	common in the patch failed.
-1	javadoc	21	container-service in the patch failed.
-1	javadoc	21	server-scm in the patch failed.
-1	javadoc	22	common in the patch failed.
-1	javadoc	21	dist in the patch failed.
-1	javadoc	22	integration-test in the patch failed.
-1	javadoc	21	ozone-manager in the patch failed.
		_ Other Tests _
-1	unit	21	common in the patch failed.
-1	unit	21	container-service in the patch failed.
-1	unit	22	server-scm in the patch failed.
-1	unit	21	common in the patch failed.
-1	unit	21	dist in the patch failed.
-1	unit	21	integration-test in the patch failed.
-1	unit	22	ozone-manager in the patch failed.
+1	asflicense	35	The patch does not generate ASF License warnings.
		5086

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 36fe025e3c7a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `03f3c8a`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-compile-root.txt
cc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-compile-root.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-compile-root.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-findbugs-hadoop-hdds_common.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-findbugs-hadoop-hdds_container-service.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-findbugs-hadoop-ozone_common.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-hdds_common.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-hdds_container-service.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-hdds_server-scm.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-ozone_common.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-ozone_dist.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-ozone_integration-test.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-hdds_common.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-ozone_common.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-ozone_dist.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/testReport/
Max. process+thread count	398 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/22/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-03-16T00:22:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	24	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	22	Maven dependency ordering for branch
+1	mvninstall	978	trunk passed
+1	compile	920	trunk passed
+1	checkstyle	192	trunk passed
-1	mvnsite	41	container-service in trunk failed.
-1	mvnsite	43	server-scm in trunk failed.
-1	mvnsite	41	integration-test in trunk failed.
-1	mvnsite	37	ozone-manager in trunk failed.
+1	shadedclient	1218	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	35	container-service in trunk failed.
-1	findbugs	36	server-scm in trunk failed.
-1	findbugs	36	ozone-manager in trunk failed.
+1	javadoc	263	trunk passed
		_ Patch Compile Tests _
0	mvndep	24	Maven dependency ordering for patch
-1	mvninstall	19	dist in the patch failed.
+1	compile	893	the patch passed
+1	cc	893	the patch passed
+1	javac	893	the patch passed
+1	checkstyle	186	the patch passed
+1	mvnsite	308	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	682	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
-1	findbugs	91	hadoop-hdds/common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	javadoc	261	the patch passed
		_ Other Tests _
+1	unit	87	common in the patch passed.
-1	unit	72	container-service in the patch failed.
-1	unit	93	server-scm in the patch failed.
+1	unit	49	common in the patch passed.
+1	unit	21	dist in the patch passed.
-1	unit	261	integration-test in the patch failed.
+1	unit	43	ozone-manager in the patch passed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		7582

Reason	Tests
FindBugs	module:hadoop-hdds/common
	Possible null pointer dereference of cert in org.apache.hadoop.hdds.security.x509.certificate.client.DefaultCertificateClient.loadAllCertificates() Dereferenced at DefaultCertificateClient.java:cert in org.apache.hadoop.hdds.security.x509.certificate.client.DefaultCertificateClient.loadAllCertificates() Dereferenced at DefaultCertificateClient.java:[line 130]
Failed junit tests	hadoop.hdds.scm.node.TestSCMNodeManager
	hadoop.ozone.ozShell.TestOzoneDatanodeShell
	hadoop.ozone.web.client.TestBuckets
	hadoop.ozone.scm.TestSCMMXBean
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.TestContainerStateMachineIdempotency
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.om.TestOzoneManagerConfiguration
	hadoop.ozone.om.TestOmMetrics
	hadoop.ozone.TestContainerOperations
	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.om.TestOmAcls
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics
	hadoop.ozone.om.TestMultipleContainerReadWrite
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.om.TestOMDbCheckpointServlet
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean
	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.web.TestOzoneVolumes
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.web.TestOzoneWebAccess
	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.web.client.TestVolume
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.om.TestContainerReportWithKeys
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.om.TestOmBlockVersioning
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.web.client.TestOzoneClient
	hadoop.ozone.scm.node.TestSCMNodeMetrics
	hadoop.ozone.om.TestOzoneManagerRestInterface
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.scm.TestAllocateContainer
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
	hadoop.ozone.om.TestOmInit
	hadoop.ozone.web.client.TestKeysRatis
	hadoop.ozone.ozShell.TestS3Shell
	hadoop.ozone.scm.TestXceiverClientManager
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.scm.TestXceiverClientMetrics
	hadoop.hdds.scm.container.TestContainerStateManagerIntegration
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 5dd5f163a382 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `03f3c8a`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-mvnsite-hadoop-hdds_container-service.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-findbugs-hadoop-hdds_container-service.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/new-findbugs-hadoop-hdds_common.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/testReport/
Max. process+thread count	4491 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/21/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…ion. Contributed by Ajay Kumar.

hadoop-yetus · 2019-03-19T00:49:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	58	Docker mode activated.
		_ Prechecks _
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 25 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	30	Maven dependency ordering for branch
+1	mvninstall	1329	trunk passed
+1	compile	1334	trunk passed
+1	checkstyle	236	trunk passed
+1	mvnsite	363	trunk passed
+1	shadedclient	1431	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	317	trunk passed
+1	javadoc	283	trunk passed
		_ Patch Compile Tests _
0	mvndep	28	Maven dependency ordering for patch
-1	mvninstall	19	dist in the patch failed.
-1	mvninstall	28	integration-test in the patch failed.
+1	compile	1258	the patch passed
+1	cc	1258	the patch passed
+1	javac	1258	the patch passed
+1	checkstyle	259	the patch passed
+1	mvnsite	359	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	771	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/dist hadoop-ozone/integration-test
+1	findbugs	348	the patch passed
+1	javadoc	246	the patch passed
		_ Other Tests _
+1	unit	105	common in the patch passed.
+1	unit	86	container-service in the patch passed.
+1	unit	128	server-scm in the patch passed.
+1	unit	48	common in the patch passed.
+1	unit	33	dist in the patch passed.
-1	unit	1043	integration-test in the patch failed.
+1	unit	73	ozone-manager in the patch passed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		10205

Reason	Tests
Failed junit tests	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.om.TestScmChillMode
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.om.TestOzoneManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-601/23/artifact/out/Dockerfile
GITHUB PR	#601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc yamllint
uname	Linux 105276f79bfc 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `ae3a2c3`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/23/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/23/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/23/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/23/testReport/
Max. process+thread count	4074 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/common hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-601/23/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

ajayydv · 2019-03-19T06:09:28Z

@xiaoyuyao thanks for continuous reviews of this long patch. UT failures looks unrelated.

…ion. Contributed by Ajay Kumar. (#601) (cherry picked from commit f10d493)

- Fix getSystemStreamMetadata in InMemoryManager to filter based on the system name on top of stream names Author: Bharath Kumarasubramanian <bkumaras@linkedin.com> Reviewers: Xinyu Liu <xinyuiscool@github.com> Closesapache#601 from bharathkk/in-memory-fix

ajayydv added the ozone label Mar 13, 2019

ajayydv self-assigned this Mar 13, 2019

ajayydv requested a review from xiaoyuyao March 13, 2019 18:48

ajayydv force-pushed the HDDS-1119-2 branch from cc8743a to 2b742fdCompare March 13, 2019 22:01

ajayydv force-pushed the HDDS-1119-2 branch from 4d21cff to 2b742fdCompare March 13, 2019 22:27

xiaoyuyao reviewed Mar 13, 2019
View reviewed changes

Comment threadhadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/token/BlockTokenVerifier.java Outdated

ajayydv force-pushed the HDDS-1119-2 branch 2 times, most recently from 02166c1 to 2b742fdCompare March 14, 2019 03:46

ajayydv force-pushed the HDDS-1119-2 branch from 2b742fd to 24d8836Compare March 14, 2019 15:51

ajayydv force-pushed the HDDS-1119-2 branch 3 times, most recently from a015644 to 0b57d76Compare March 14, 2019 16:30

ajayydv force-pushed the HDDS-1119-2 branch 2 times, most recently from e44820d to 02392daCompare March 14, 2019 22:29

ajayydv force-pushed the HDDS-1119-2 branch from 02392da to 44042bcCompare March 14, 2019 23:46

xiaoyuyao reviewed Mar 15, 2019
View reviewed changes

Comment thread...n/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java Outdated

xiaoyuyao reviewed Mar 15, 2019
View reviewed changes

Comment threadhadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/LongCodec.java Outdated

xiaoyuyao reviewed Mar 15, 2019
View reviewed changes

ajayydv force-pushed the HDDS-1119-2 branch from 44042bc to 29100feCompare March 15, 2019 05:42

ajayydv force-pushed the HDDS-1119-2 branch from 29100fe to 1ae6f99Compare March 15, 2019 16:19

ajayydv force-pushed the HDDS-1119-2 branch 2 times, most recently from bb81529 to 9f59f08Compare March 15, 2019 22:20

HDDS-1119. DN get OM certificate from SCM CA for block token validat…
446b6fe
…ion. Contributed by Ajay Kumar.

ajayydv force-pushed the HDDS-1119-2 branch from 9f59f08 to 446b6feCompare March 18, 2019 21:58

ajayydv merged commit f10d493 into apache:trunkMar 19, 2019

ajayydv added a commit that referenced this pull request Mar 19, 2019
HDDS-1119. DN get OM certificate from SCM CA for block token validat…
d2e115d
…ion. Contributed by Ajay Kumar. (#601) (cherry picked from commit f10d493)

ajayydv deleted the HDDS-1119-2 branch March 21, 2019 22:28

Uh oh!

Conversation

ajayydv commented Mar 13, 2019

Uh oh!

hadoop-yetus commented Mar 13, 2019

Uh oh!

hadoop-yetus commented Mar 13, 2019

Uh oh!

hadoop-yetus commented Mar 13, 2019

Uh oh!

hadoop-yetus commented Mar 13, 2019

Uh oh!

xiaoyuyaoMar 13, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyaoMar 13, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 14, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

xiaoyuyaoMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

ajayydvMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

ajayydvMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyaoMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xiaoyuyaoMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

ajayydvMar 15, 2019

Choose a reason for hiding this comment

Uh oh!

xiaoyuyao commented Mar 15, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

xiaoyuyao commented Mar 15, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

hadoop-yetus commented Mar 15, 2019

Uh oh!

hadoop-yetus commented Mar 16, 2019

Uh oh!

hadoop-yetus commented Mar 19, 2019

Uh oh!

ajayydv commented Mar 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xiaoyuyaoMar 13, 2019•
edited
Loading