You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JIRA: MAPREDUCE-7522. Fix SpotBugs issues in hadoop-mapreduce-client-app module.
After upgrading SpotBugs to version 4.9.7 in #8028, the new analysis rules identified several code quality issues in the hadoop-mapreduce-client-app module.
This update focuses on fixing these newly reported SpotBugs warnings to eliminate potential risks such as null pointer exceptions and resource leaks, ensuring successful builds and maintaining code consistency.
How was this patch tested?
CI.
For code changes:
Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
35m 53s
trunk passed
+1 💚
compile
0m 38s
trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚
compile
0m 38s
trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚
checkstyle
0m 35s
trunk passed
+1 💚
mvnsite
0m 39s
trunk passed
+1 💚
javadoc
0m 38s
trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚
javadoc
0m 33s
trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗
mvndep
7m 46s
Maven dependency ordering for branch
+1 💚
mvninstall
28m 7s
trunk passed
+1 💚
compile
1m 45s
trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚
compile
1m 47s
trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚
checkstyle
0m 51s
trunk passed
+1 💚
mvnsite
2m 10s
trunk passed
+1 💚
javadoc
2m 3s
trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚
javadoc
1m 53s
trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:[line 2170]
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:[line 2171]
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl, Task) At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl, Task) At JobImpl.java:[line 2065]
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl, JobEvent) At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl, JobEvent) At JobImpl.java:[line 1980]
Unknown bug pattern AT_STALE_THREAD_WRITE_OF_PRIMITIVE in org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int) At RMContainerAllocator.java:org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int) At RMContainerAllocator.java:[line 1068]
SpotBugs
module:hadoop-mapreduce-project
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:[line 2170]
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.decrementSucceededMapperCount() At JobImpl.java:[line 2171]
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.succeededMapTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl, Task) At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.taskSucceeded(JobImpl, Task) At JobImpl.java:[line 2065]
Increment of volatile field org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl.completedTaskCount in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl, JobEvent) At JobImpl.java:in org.apache.hadoop.mapreduce.v2.app.job.impl.JobImpl$TaskCompletedTransition.transition(JobImpl, JobEvent) At JobImpl.java:[line 1980]
Unknown bug pattern AT_STALE_THREAD_WRITE_OF_PRIMITIVE in org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int) At RMContainerAllocator.java:org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator$ScheduledRequests.setNumOpportunisticMapsPercent(int) At RMContainerAllocator.java:[line 1068]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: MAPREDUCE-7522. Fix SpotBugs issues in hadoop-mapreduce-client-app module.
After upgrading SpotBugs to version
4.9.7in #8028, the new analysis rules identified several code quality issues in thehadoop-mapreduce-client-appmodule.This update focuses on fixing these newly reported SpotBugs warnings to eliminate potential risks such as null pointer exceptions and resource leaks, ensuring successful builds and maintaining code consistency.
How was this patch tested?
CI.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?