Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
My JIRA id is deepujain |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
CI is green on the current head, and this one still has not had a human review. @steveloughran @EnricoMi, when you have a moment, could you please take a look? Happy to make any follow-up changes. |
Contributor
|
@deepujain I'm sorry, I'm really cutting back on my involvement in hadoop almost entirely. don't be afraid to get on the hadoop common dev list and ask for humans -it's what I do |
Contributor
Author
ctubbsii
approved these changes
Jun 16, 2026
ctubbsii
left a comment
Member
There was a problem hiding this comment.
The changes here look fine. However, the linked JIRA issue is already marked closed. I'm not sure if that's a problem or not. I don't know the Hadoop community norms for ticket management.
Also, @deepujain as I mentioned on another issue, please don't tag me randomly. Please don't tag me again unless I've shown an interest in a topic. I am not a committer on Hadoop and cannot merge your PRs.
Contributor
|
catching up on this #8231 added this, but it didn't do the http signer, did it? so this is a followup pr. create a whole new jira and link it as related to HADOOP-19085 |
Contributor
Author
|
Thanks, this makes sense. This is follow-up work beyond HADOOP-19085 and #8231, so I need to move it to a new related JIRA before this can go further. I cannot create the replacement JIRA from this environment, so this PR is blocked on that ticket-management step for now. |
Contributor
Author
|
Closing this PR because HADOOP-19805 is closed and the requested replacement JIRA has not been created. The code can be brought back under a new related JIRA once that ticket exists, rather than leaving this branch in a blocked state. |
Member
|
@deepujain I don't think you need to close this. The changes are still valid... they are just saying to create a new JIRA issue for tracking purposes. I don't agree with it, personally (the PR itself is already sufficient for tracking, IMO). But you don't need to close the PR. Just create a blank issue in JIRA and update this ticket to refer to it. That's all you need to do. Do you not have access to JIRA? (Note to Hadoop PMC: I think if you're rejecting, or failing to accept, legitimate contributions because the contributor didn't do the busy work of creating a separate JIRA tracking ticket... which may not even be very easy to do, since spam protections have made JIRA sign-ups more difficult, then I think you're failing your community. Instead of letting the contributor abandon their contribution, you should be fostering contributors, and encouraging contributors. If that means create the required JIRA ticket yourself, then so be it. But please don't just let good contributions get dropped, and discourage contributors because of non-technical bureaucracy reasons.) |
Contributor
|
ℹ️ Cloud-AWS manual trigger instructions: S3A tests must be manually triggered for fork pull requests. A maintainer should:
fork head: |
Contributor
Author
|
@ctubbsii Thanks for the guidance. Created HADOOP-19991 (https://issues.apache.org/jira/browse/HADOOP-19991), updated the PR title and description to reference it, and reopened the PR. |
|
🎊 +1 overall
This message was automatically generated. |
…config. In createHttpSigner, call setConf(conf) when the HTTP signer implements Configurable; use getDeclaredConstructor().newInstance() and ReflectiveOperationException.
…r is Configurable
deepujain
force-pushed
the
HADOOP-19805-signer-configurable-set-config
branch
from
September 19, 2026 14:47
82202ff to
2d18068
Compare
Contributor
Author
|
Rebased onto trunk
The previous Build check reported workflow-run detection failure, not a test failure. Fork Actions are enabled. On the new head, Build is queued and Jenkins is pending; the old detection-error state has cleared. |
Contributor
Author
|
FYI, I have sent a review request to the Hadoop developer mailing list, following the recommendation here. Thanks for pointing me to that channel. |
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Pass the caller's Hadoop configuration to custom HTTP signers that implement
Configurable.SignerFactory.createHttpSignercurrently constructs the signer without callingsetConf, so it cannot read that configuration.Tracked by HADOOP-19991. This follows up on HADOOP-19805, which is already resolved.
How was this patch tested?
On
2d180683, ran the following in a Docker container using Maven 3.9.15 and JDK 17:All 10
TestSignerManagertests passed, with zero failures, errors, or skips. The configurable-signer regression verifies that the factory passes the same configuration instance to the signer. Maven usedMAVEN_OPTS=-Xmx1024mand a container-local source copy.Rebased onto trunk
a3febb258. Updated the regression's JIRA references to HADOOP-19991 and made its recorded configuration field private to address the Yetus visibility warning.git diff --check apache/trunk...HEADpassed.A separate module-only Checkstyle attempt could not resolve reactor snapshot dependencies, so fresh CI must verify that check. No object-store endpoint was exercised; cloud integration validation remains outstanding.
For code changes:
AI Tooling
Contains content generated by Codex.