HDFS-17971. Fix RAT check failure for vendored JSON.java in hadoop-hdfs-rbf. - #8708
Merged
Merged
Conversation
Merged
6 tasks
Contributor
Author
|
@zhtttylz Could you please help review this PR? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@zhtttylz Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HDFS-17971. Fix RAT check failure for vendored JSON.java in hadoop-hdfs-rbf.
The Apache RAT check fails in the
hadoop-hdfs-rbfmodulebecause
src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.javais reported as an unapproved license file.
This class was copied from Jetty and intentionally retains its original dual EPL/Apache license header. It is already documented in
LICENSE.txtand excluded from the root-level RAT check.However,
hadoop-hdfs-rbfdefines its own RAT exclusion list, which did not include this file.This patch adds
JSON.javato the module-level RAT exclusion list. It does not modify the source file or its original license header.This is a follow-up to HADOOP-19951 and #8654.
How was this patch tested?
The failure was reproduced before applying the patch:
The following command was run after applying the patch:
Result:
For code changes:
declared according to the connector-specific documentation? Note: Automated CI
testing doesn't cover all cases so manual testing with cloud storage is still
required.
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html