Skip to content

HDDS-1541. Implement addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat. - #885

Merged
xiaoyuyao merged 5 commits into
apache:trunkfrom
ajayydv:HDDS-1541
Jun 5, 2019
Merged

HDDS-1541. Implement addAcl,removeAcl,setAcl,getAcl for Key. Contributed by Ajay Kumat.#885
xiaoyuyao merged 5 commits into
apache:trunkfrom
ajayydv:HDDS-1541

Conversation

@ajayydv

@ajayydvajayydv commented Jun 1, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@ajayydv
ajayydv requested a review from xiaoyuyaoJune 1, 2019 02:45
@ajayydvajayydv self-assigned this Jun 1, 2019
hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

hadoop-yetus
hadoop-yetus reviewed Jun 1, 2019
View reviewed changes
Comment threadhadoop-ozone/integration-test/hs_err_pid1948.log Outdated

@hadoop-yetushadoop-yetusJun 1, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:tabs in line

@hadoop-yetus

hadoop-yetus commented Jun 1, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec81Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0mvndep42Maven dependency ordering for branch
+1mvninstall556trunk passed
+1compile301trunk passed
+1checkstyle88trunk passed
+1mvnsite0trunk passed
+1shadedclient885branch has no errors when building and testing our client artifacts.
+1javadoc181trunk passed
0spotbugs329Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs520trunk passed
_ Patch Compile Tests _
0mvndep27Maven dependency ordering for patch
+1mvninstall503the patch passed
+1compile308the patch passed
+1cc308the patch passed
+1javac308the patch passed
-0checkstyle49hadoop-ozone: The patch generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0)
+1mvnsite0the patch passed
-1whitespace0The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1whitespace0The patch 460 line(s) with tabs.
+1shadedclient679patch has no errors when building and testing our client artifacts.
+1javadoc181the patch passed
+1findbugs535the patch passed
_ Other Tests _
-1unit281hadoop-hdds in the patch failed.
-1unit57hadoop-ozone in the patch failed.
+1asflicense49The patch does not generate ASF License warnings.
5692
ReasonTests
Failed junit testshadoop.hdds.scm.block.TestBlockManager
hadoop.ozone.om.helpers.TestOmKeyInfo
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/Dockerfile
GITHUB PR#885
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux 27bf8a3f3475 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 2210897
Default Java1.8.0_212
checkstylehttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
whitespacehttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/whitespace-eol.txt
whitespacehttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/whitespace-tabs.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/patch-unit-hadoop-hdds.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/testReport/
Max. process+thread count495 (vs. ulimit of 5500)
modulesC: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/1/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao
xiaoyuyao reviewed Jun 3, 2019
View reviewed changes
Comment threadhadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java Outdated

@xiaoyuyaoxiaoyuyaoJun 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to recreate a new UGI instead of using ugi.getGroups() here?

@hadoop-yetus

hadoop-yetus commented Jun 4, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec954Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 6 new or modified test files.
_ trunk Compile Tests _
0mvndep129Maven dependency ordering for branch
+1mvninstall577trunk passed
+1compile276trunk passed
+1checkstyle78trunk passed
+1mvnsite0trunk passed
+1shadedclient1030branch has no errors when building and testing our client artifacts.
+1javadoc184trunk passed
0spotbugs390Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs614trunk passed
_ Patch Compile Tests _
0mvndep20Maven dependency ordering for patch
+1mvninstall512the patch passed
+1compile289the patch passed
+1cc289the patch passed
+1javac289the patch passed
+1checkstyle86the patch passed
+1mvnsite0the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient723patch has no errors when building and testing our client artifacts.
+1javadoc175the patch passed
+1findbugs655the patch passed
_ Other Tests _
+1unit358hadoop-hdds in the patch passed.
-1unit214hadoop-ozone in the patch failed.
+1asflicense54The patch does not generate ASF License warnings.
7122
ReasonTests
Failed junit testshadoop.ozone.om.TestKeyDeletingService
SubsystemReport/Notes
DockerClient=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/artifact/out/Dockerfile
GITHUB PR#885
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux 5dc0efbfcb6e 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 277e9a8
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/testReport/
Max. process+thread count1228 (vs. ulimit of 5500)
modulesC: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/4/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao
xiaoyuyao reviewed Jun 4, 2019
View reviewed changes
Comment thread...ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockOutputStreamEntryPool.java Outdated
.setType(type).setFactor(factor).setDataSize(info.getDataSize())
.setIsMultipartKey(isMultipart).setMultipartUploadID(uploadID)
.setMultipartUploadPartNumber(partNumber).build();
.setMultipartUploadPartNumber(partNumber)

@xiaoyuyaoxiaoyuyaoJun 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: unnecessary change can be avoided.

xiaoyuyao
xiaoyuyao reviewed Jun 4, 2019
View reviewed changes
Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmOzoneAclMap.java Outdated
bits.and(aclRights);

if (bits.equals(ZERO_BITSET)) {
// throw exception if acl is already added.

@xiaoyuyaoxiaoyuyaoJun 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments does not match with code.

xiaoyuyao
xiaoyuyao reviewed Jun 4, 2019
View reviewed changes
Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmOzoneAclMap.java Outdated
getMap(aclType).remove(acl.getName());
}
} else {
// throw exception if acl is already added.

@xiaoyuyaoxiaoyuyaoJun 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be acl does not exist?

@ajayydvajayydvJun 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point all rights are already set to 0, so we are removing the entry from map.

@ajayydvajayydvJun 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

xiaoyuyao
xiaoyuyao reviewed Jun 4, 2019
View reviewed changes

@xiaoyuyaoxiaoyuyao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajayydv for the patch. LGTM overall, a few comments added inline...

@xiaoyuyao

xiaoyuyao commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Also, CI test failures in TestKeyDeletingService are related. Please fix them in next update.

java.lang.NullPointerException: Default acls should be set.

@hadoop-yetus

hadoop-yetus commented Jun 4, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec117Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 6 new or modified test files.
_ trunk Compile Tests _
0mvndep19Maven dependency ordering for branch
+1mvninstall661trunk passed
+1compile357trunk passed
+1checkstyle100trunk passed
+1mvnsite0trunk passed
+1shadedclient1135branch has no errors when building and testing our client artifacts.
+1javadoc216trunk passed
0spotbugs404Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs641trunk passed
_ Patch Compile Tests _
0mvndep27Maven dependency ordering for patch
+1mvninstall608the patch passed
+1compile349the patch passed
+1cc349the patch passed
+1javac349the patch passed
+1checkstyle121the patch passed
+1mvnsite0the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient848patch has no errors when building and testing our client artifacts.
+1javadoc205the patch passed
+1findbugs720the patch passed
_ Other Tests _
+1unit291hadoop-hdds in the patch passed.
-1unit171hadoop-ozone in the patch failed.
+1asflicense42The patch does not generate ASF License warnings.
6864
ReasonTests
Failed junit testshadoop.ozone.om.TestKeyDeletingService
SubsystemReport/Notes
DockerClient=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/artifact/out/Dockerfile
GITHUB PR#885
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux 2ca7b4d927de 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 580b639
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/testReport/
Max. process+thread count1178 (vs. ulimit of 5500)
modulesC: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/5/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Jun 4, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec52Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 7 new or modified test files.
_ trunk Compile Tests _
0mvndep46Maven dependency ordering for branch
+1mvninstall553trunk passed
+1compile297trunk passed
+1checkstyle83trunk passed
+1mvnsite0trunk passed
+1shadedclient912branch has no errors when building and testing our client artifacts.
+1javadoc177trunk passed
0spotbugs366Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs578trunk passed
_ Patch Compile Tests _
0mvndep20Maven dependency ordering for patch
+1mvninstall507the patch passed
+1compile307the patch passed
+1cc307the patch passed
+1javac307the patch passed
+1checkstyle85the patch passed
+1mvnsite0the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient729patch has no errors when building and testing our client artifacts.
+1javadoc181the patch passed
+1findbugs594the patch passed
_ Other Tests _
-1unit185hadoop-hdds in the patch failed.
-1unit1559hadoop-ozone in the patch failed.
+1asflicense66The patch does not generate ASF License warnings.
7119
ReasonTests
Failed junit testshadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.ozone.om.TestOmMetrics
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/artifact/out/Dockerfile
GITHUB PR#885
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux 45aa29b5598d 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 580b639
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/artifact/out/patch-unit-hadoop-hdds.txt
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/testReport/
Max. process+thread count4615 (vs. ulimit of 5500)
modulesC: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/6/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus

hadoop-yetus commented Jun 5, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec29Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 7 new or modified test files.
_ trunk Compile Tests _
0mvndep15Maven dependency ordering for branch
+1mvninstall605trunk passed
+1compile321trunk passed
+1checkstyle84trunk passed
+1mvnsite0trunk passed
+1shadedclient977branch has no errors when building and testing our client artifacts.
+1javadoc182trunk passed
0spotbugs415Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs648trunk passed
_ Patch Compile Tests _
0mvndep34Maven dependency ordering for patch
+1mvninstall483the patch passed
+1compile290the patch passed
+1cc290the patch passed
+1javac290the patch passed
+1checkstyle84the patch passed
+1mvnsite0the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient717patch has no errors when building and testing our client artifacts.
+1javadoc163the patch passed
+1findbugs559the patch passed
_ Other Tests _
+1unit238hadoop-hdds in the patch passed.
-1unit1259hadoop-ozone in the patch failed.
+1asflicense47The patch does not generate ASF License warnings.
6925
ReasonTests
Failed junit testshadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.om.TestOmBlockVersioning
hadoop.ozone.om.TestOzoneManager
hadoop.ozone.om.TestOmAcls
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.om.TestMultipleContainerReadWrite
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.TestStorageContainerManager
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.om.TestScmSafeMode
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/artifact/out/Dockerfile
GITHUB PR#885
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux b4b57e1ee059 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 1a78794
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/testReport/
Max. process+thread count4364 (vs. ulimit of 5500)
modulesC: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/8/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao
xiaoyuyao approved these changes Jun 5, 2019
View reviewed changes

@xiaoyuyaoxiaoyuyao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, Pending CI.

@hadoop-yetus

hadoop-yetus commented Jun 5, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec73Docker mode activated.
_ Prechecks _
+1dupname1No case conflicting files found.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 7 new or modified test files.
_ trunk Compile Tests _
0mvndep12Maven dependency ordering for branch
+1mvninstall564trunk passed
+1compile298trunk passed
+1checkstyle93trunk passed
+1mvnsite0trunk passed
+1shadedclient897branch has no errors when building and testing our client artifacts.
+1javadoc181trunk passed
0spotbugs335Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs527trunk passed
_ Patch Compile Tests _
0mvndep28Maven dependency ordering for patch
+1mvninstall498the patch passed
+1compile313the patch passed
+1cc313the patch passed
+1javac313the patch passed
+1checkstyle99the patch passed
+1mvnsite0the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedclient683patch has no errors when building and testing our client artifacts.
+1javadoc179the patch passed
+1findbugs539the patch passed
_ Other Tests _
+1unit290hadoop-hdds in the patch passed.
-1unit1511hadoop-ozone in the patch failed.
+1asflicense46The patch does not generate ASF License warnings.
7031
ReasonTests
Failed junit testshadoop.ozone.scm.node.TestSCMNodeMetrics
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/artifact/out/Dockerfile
GITHUB PR#885
Optional Testsdupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
unameLinux 8586a60de279 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/hadoop.sh
git revisiontrunk / 0b1e288
Default Java1.8.0_212
unithttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Resultshttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/testReport/
Max. process+thread count4369 (vs. ulimit of 5500)
modulesC: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone
Console outputhttps://builds.apache.org/job/hadoop-multibranch/job/PR-885/9/console
versionsgit=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@ajayydv

ajayydv commented Jun 5, 2019

Copy link
Copy Markdown
ContributorAuthor

Both test failures pass locally, seems unrelated.

@xiaoyuyao
xiaoyuyao merged commit 3b1c257 into apache:trunkJun 5, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@srinipunuru
SAMZA-2081: Type system for Samza SQL and Support for types in UDFS
759b778
This checkin adds
1. Type system for Samza SQL. Previously Samza SQL was using Calcite's relational type system. We need an intermediate type system that is specific to Samza SQL so that we could support Beam SQL in future. This intermediate type system also allows to provide typing to Samza SQL UDFs.
2. Java annotations for Samza SQL that allows us to discover the Samza SQL UDFs easily and also provide users to configure name of the UDF, whether it is disabled.
3. Initial support for adding types in Samza SQL UDFs. Right now we are not using these types for validations. Future checkin will add that capability.
Author: Srinivasulu Punuru <spunuru@linkedin.com>
Reviewers: Weiqing <wiyang@linkedin.com>, Shenoda <sguirgui@linkedin.com>
Closesapache#885 from srinipunuru/sql-schema.2 and squashes the following commits:
61e03b9a [Srinivasulu Punuru] Removing Metadata from SamzaSQLRelMessage
f713cae5 [Srinivasulu Punuru] Address review comments
60d2614a [Srinivasulu Punuru] Adding license and documentation
a3af257 [Srinivasulu Punuru] Support for types in UDFS
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoyuyaoxiaoyuyaoxiaoyuyao approved these changes
+1 more reviewer
@hadoop-yetushadoop-yetushadoop-yetus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ajayydvajayydv

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajayydv@hadoop-yetus@xiaoyuyao