Refactoring: Enhance Maintainability Without Functional Changes

[PreetPatel45]

Refactoring: Enhance Maintainability Without Functional Changes

✅ Validation

✔ All existing tests pass (unit/integration)
✔ Build succeeds (mvn clean install)
✔ Manual verification of HBCK2 commands → No behavioral changes

🔧 Improvements

1. Reduced code duplication
   • New BaseMaintenanceTool abstract class for shared logic between RegionMerger and MissingRegionDirsTool.
2. Simplified complex logic
   • Extracted HBCK2CommandUsage (reduced HBCK2 by 300+ LOC).
   • Decomposed doCommandLine (cyclomatic complexity ↓ from 17).
3. Clearer threading logic
   • Introduced explaining variables (availableProcessors, threadPoolSize).

📌 Why Merge This?

• Zero-risk refactoring → Pure structural changes, no side effects.
• Easier to debug/extend → Better encapsulation, less duplication.
• Follows SOLID principles → More modular design.

💡 Review focus: Verify thread pool changes and new class structure.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	spotbugs	0m 0s	spotbugs executables are not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	0m 34s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	checkstyle	0m 12s	master passed
+1 💚	spotless	0m 7s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 22s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
-1 ❌	checkstyle	0m 9s	hbase-hbck2: The patch generated 362 new + 0 unchanged - 0 fixed = 362 total (was 0)
-1 ❌	checkstyle	0m 5s	hbase-tools: The patch generated 52 new + 0 unchanged - 0 fixed = 52 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
-1 ❌	spotless	0m 4s	patch has 34 errors when running spotless:check, run spotless:apply to fix.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 48s	hbase-hbck2 in the patch passed.
+1 💚	unit	1m 42s	hbase-tools in the patch passed.
-1 ❌	asflicense	0m 11s	The patch generated 5 ASF License warnings.
		11m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#148
Optional Tests	dupname asflicense javac javadoc unit spotless xml compile spotbugs findbugs checkstyle
uname	Linux b0dff839a928 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / fd5a5fb
Default Java	Oracle Corporation-1.8.0_342-b07
checkstyle	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-tools.txt
spotless	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/patch-spotless.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/testReport/
asflicense	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/patch-asflicense-problems.txt
Max. process+thread count	1279 (vs. ulimit of 5000)
modules	C: hbase-hbck2hbase-tools U: .
Console output	https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-148/1/console
versions	git=2.30.2 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.