Skip to content

HBASE-28407 [thirdparty] Update release instructions - #113

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:28407-release-instructions
Mar 4, 2024
Merged

HBASE-28407 [thirdparty] Update release instructions#113
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:28407-release-instructions

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

@Apache9@busbey This is the processes that I (eventually) sorted out. Does it look about right from your recollection?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗markdownlint0m 1smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+0 🆗asflicense0m 18sASF License check generated no output?
2m 8s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-113/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#113
Optional Testsdupname asflicense markdownlint
unameLinux 90af66ffd0c2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 293203f
Max. process+thread count8 (vs. ulimit of 1000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-113/1/console
versionsgit=2.20.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@busbeybusbey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start for sure.

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Comment threadREADME.md
Comment threadREADME.md
have in hbase-unsafe is using old APIs that have been removed from more
modern JDKs. Due to a bug in JDK, we cannot generate this code using a more
modern version of the JDK. See
[HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I hit https://issues.apache.org/jira/browse/HBASE-28380, while trying to build with JDK17. This doc helps me understand why we have hbase-unsafe module and how to release. Very useful. Thanks a ton :)

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews. I'll merge this after the current RC vote is finished.

Comment threadREADME.md
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
@ndimiduk
ndimidukforce-pushed the 28407-release-instructions branch from 5c18bb3 to 362130dCompareMarch 4, 2024 11:26
@ndimiduk
ndimiduk merged commit 726f60d into apache:masterMar 4, 2024
@ndimiduk
ndimiduk deleted the 28407-release-instructions branch March 4, 2024 11:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ndimiduk@Apache-HBase@busbey@NihalJain@chrajeshbabu@Apache9