Skip to content

HBASE-28493 [hbase-thirdparty] Bump protobuf version - #117

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28493
Apr 10, 2024
Merged

HBASE-28493 [hbase-thirdparty] Bump protobuf version#117
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28493

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Apr 9, 2024
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall0m 42smaster passed
+1 💚compile0m 25smaster passed
+1 💚javadoc0m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚mvninstall0m 48sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 11sthe patch passed
_ Other Tests _
+1 💚unit0m 10shbase-shaded-protobuf in the patch passed.
+1 💚unit0m 34sroot in the patch passed.
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
5m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-117/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#117
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux ad424a5fdee1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 59dd9e3
Default JavaTemurin-1.8.0_402-b06
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-117/1/testReport/
Max. process+thread count370 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-117/1/console
versionsgit=2.34.1 maven=3.9.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to re-engage with the protobuf team about accepting some version of these patches?

@Apache9

Copy link
Copy Markdown
ContributorAuthor

Is it time to re-engage with the protobuf team about accepting some version of these patches?

I think first we need to check whether protobuf has already provided these abilities in newer versions. If not, we could try to contact with the protobuf team again.

@Apache9
Apache9 merged commit d7883b5 into apache:masterApr 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@ndimiduk@apurtell