Skip to content

HBASE-29343 Stop versioning protobuf patches in hbase-thirdparty - #138

Merged
NihalJain merged 1 commit into
apache:masterfrom
NihalJain:HBASE-29343
May 21, 2025
Merged

HBASE-29343 Stop versioning protobuf patches in hbase-thirdparty#138
NihalJain merged 1 commit into
apache:masterfrom
NihalJain:HBASE-29343

Conversation

@NihalJain

Copy link
Copy Markdown
Contributor
  • It is not very useful to version the patch files as we already are under version control via git.

@NihalJain
NihalJain requested review from ndimiduk and stotyMay 20, 2025 17:49
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 55sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗markdownlint0m 1smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall0m 48smaster passed
+1 💚javadoc0m 15smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
+1 💚mvninstall0m 51sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 14sthe patch passed
_ Other Tests _
+1 💚unit0m 12shbase-shaded-protobuf in the patch passed.
+1 💚unit0m 48sroot in the patch passed.
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
4m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-138/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#138
Optional Testsdupname asflicense javac javadoc unit markdownlint
unameLinux ac731265e6ef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / ad09819
Default JavaTemurin-1.8.0_452-b09
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-138/1/testReport/
Max. process+thread count386 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-138/1/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@NihalJain
NihalJain merged commit 223f4c6 into apache:masterMay 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@NihalJain@Apache-HBase@stoty