Uh oh!
There was an error while loading. Please reload this page.
HBASE-29545 [hbase-thirdparty] Remove usage of Unsafe.defineClass - #148
Merged
Conversation
Apache-HBase
commented
Aug 25, 2025
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 26, 2025
🎊 +1 overall
This message was automatically generated. |
richardantal
commented
Aug 26, 2025
ContributorAuthor
ContributorAuthor
It would help if we want to build hbase-thirdparty with only java 17 |
richardantal
commented
Aug 26, 2025
ContributorAuthor
should we adapt these functions to use java.lang.invoke.MethodHandles.Lookup.defineClass instead? |
stoty
commented
Aug 26, 2025
Contributor
That would alleviate concerns about removing methods in a patch release. |
richardantal
commented
Aug 26, 2025
ContributorAuthor
The problem is that Lookup.defineClass is only available since JDK 9 |
Apache9
commented
Mar 2, 2026
Contributor
This library is for internal use only and I do not think we need to use defineClass in HBase. So let's get this in. |
Apache9
approved these changes
Mar 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.