Skip to content

HBASE-29685 [hbase-thirdparty] Bump netty4 to 4.1.127.Final - #150

Merged
chandrasekhar-188k merged 2 commits into
apache:masterfrom
CHarrod283:ch/bump-shaded-netty
Oct 31, 2025
Merged

HBASE-29685 [hbase-thirdparty] Bump netty4 to 4.1.127.Final #150
chandrasekhar-188k merged 2 commits into
apache:masterfrom
CHarrod283:ch/bump-shaded-netty

Conversation

@CHarrod283

@CHarrod283CHarrod283 commented Oct 6, 2025•
edited by NihalJain
Loading

Copy link
Copy Markdown
Contributor

Fixes following CVEs:

@Apache-HBase

Apache-HBase commented Oct 6, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall1m 10smaster passed
+1 💚compile0m 16smaster passed
+1 💚javadoc0m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 41sthe patch passed
+1 💚compile0m 17sthe patch passed
+1 💚javac0m 17sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 1sNo new issues.
+1 💚javadoc0m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 47sroot in the patch passed.
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
5m 49s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#150
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux db543745fa15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-150/yetus-precommit-check/src/.yetus/personality.sh
git revisionmaster / f4300ee
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/1/testReport/
Max. process+thread count415 (vs. ulimit of 2000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/1/console
versionsgit=2.34.1 maven=called xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@CHarrod283

CHarrod283 commented Oct 8, 2025

Copy link
Copy Markdown
ContributorAuthor

regarding test4tests, theres no code updates so no new tests required

@chandrasekhar-188k

chandrasekhar-188k commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

@CHarrod283 , please create a JIRA issue for this and use the same in the PR description

chandrasekhar-188k
chandrasekhar-188k reviewed Oct 9, 2025
View reviewed changes
Comment threadpom.xml Outdated
@CHarrod283

CHarrod283 commented Oct 16, 2025

Copy link
Copy Markdown
ContributorAuthor

needed to request an account on hbase jira, waiting for that to create an issue

@Apache-HBase

Apache-HBase commented Oct 16, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall1m 3smaster passed
+1 💚compile0m 16smaster passed
+1 💚javadoc0m 6smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 40sthe patch passed
+1 💚compile0m 16sthe patch passed
+1 💚javac0m 16sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚javadoc0m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 56sroot in the patch passed.
+1 💚asflicense0m 6sThe patch does not generate ASF License warnings.
5m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#150
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux 18c11522cd1b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-150/yetus-precommit-check/src/.yetus/personality.sh
git revisionmaster / 69014a2
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/2/testReport/
Max. process+thread count417 (vs. ulimit of 2000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-150/2/console
versionsgit=2.34.1 maven=called xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

chandrasekhar-188k
chandrasekhar-188k approved these changes Oct 17, 2025
View reviewed changes

@chandrasekhar-188kchandrasekhar-188k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CHarrod283

CHarrod283 commented Oct 23, 2025

Copy link
Copy Markdown
ContributorAuthor

@CHarrod283 , please create a JIRA issue for this and use the same in the PR description

updated desc with linked jira ticket

@CHarrod283CHarrod283 changed the title Update Netty and Netty TCNative versionsHBASE-29685 Update Netty and Netty TCNative versionsOct 27, 2025
@CHarrod283CHarrod283 changed the title HBASE-29685 Update Netty and Netty TCNative versionsHBASE-29685 Update Netty to address github advisoryOct 27, 2025
@CHarrod283

CHarrod283 commented Oct 27, 2025

Copy link
Copy Markdown
ContributorAuthor

@chandrasekhar-188k it looks like all checks are ok and got approval, but im unable to merge. Is there a person who specifically merges the pr?

@chandrasekhar-188k

chandrasekhar-188k commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

@chandrasekhar-188k it looks like all checks are ok and got approval, but im unable to merge. Is there a person who specifically merges the pr?

@CHarrod283 , members with committer previleges only can merge the PRs.. I will check and merge this PR.

@NihalJainNihalJain changed the title HBASE-29685 Update Netty to address github advisoryHBASE-29685 Bump netty4 to 4.1.127.Final Oct 30, 2025
@NihalJainNihalJain changed the title HBASE-29685 Bump netty4 to 4.1.127.Final HBASE-29685 [hbase-thirdparty] Bump netty4 to 4.1.127.Final Oct 30, 2025
@NihalJain

NihalJain commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Hi @CHarrod283 thanks for your PR. I assume you are new to the project, welcome to the team. Few nits: please ensure to keep PR title in sync with the JIRA title. We usually follow a simple format <jira-id> <jira-title> i.e. HBASE-12345 Fix All The Things
Ref https://hbase.apache.org/book.html#_commit_message_format

We usually don't need to ref jira link in commit message as it is redundant since github handle this mapping. I have update the message and title for you.

@NihalJain

NihalJain commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

@chandrasekhar-188k Feel free to commit this.

@chandrasekhar-188k
chandrasekhar-188k merged commit 57b0338 into apache:masterOct 31, 2025
1 check passed
@NihalJain

NihalJain commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

@chandrasekhar-188kchandrasekhar-188k mentioned this pull request Oct 31, 2025
Merged
@chandrasekhar-188k

chandrasekhar-188k commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

i have used rebase and merge option, it didn't ask for the commit message... i have reverted those commits..

@NihalJain

NihalJain commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Ah no worries thank you!

@chandrasekhar-188k

chandrasekhar-188k commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

what is the process to apply changes again? can we reopen existing PR or create a new PR?

@chandrasekhar-188k

chandrasekhar-188k commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

hi @chandrasekhar-188k request you to revert the commit, the commit message is incorrect, please revert and apply again with fix

what is the process to apply changes again? can we reopen existing PR or create a new PR?

I have opened a new PR: #152

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NihalJainNihalJainNihalJain approved these changes
@pankaj72981pankaj72981pankaj72981 approved these changes
@chandrasekhar-188kchandrasekhar-188kchandrasekhar-188k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CHarrod283@Apache-HBase@chandrasekhar-188k@NihalJain@pankaj72981