Skip to content

HBASE-30202 [hbase-thirdparty] Bump netty4 to 4.1.135.Final - #161

Merged
PDavid merged 2 commits into
apache:masterfrom
alta404:master
Jun 26, 2026
Merged

HBASE-30202 [hbase-thirdparty] Bump netty4 to 4.1.135.Final#161
PDavid merged 2 commits into
apache:masterfrom
alta404:master

Conversation

@alta404

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec2m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌mvninstall0m 31s/branch-mvninstall-root.txtroot in master failed.
-1 ❌compile0m 3s/branch-compile-root.txtroot in master failed.
-1 ❌javadoc0m 17s/branch-javadoc-root.txtroot in master failed.
_ Patch Compile Tests _
-1 ❌mvninstall0m 15s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile0m 3s/patch-compile-root.txtroot in the patch failed.
-1 ❌javac0m 3s/patch-compile-root.txtroot in the patch failed.
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
-1 ❌javadoc0m 18s/patch-javadoc-root.txtroot in the patch failed.
_ Other Tests _
-1 ❌unit0m 17s/patch-unit-root.txtroot in the patch failed.
+0 🆗asflicense0m 17sASF License check generated no output?
4m 34s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#161
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux 646840ac6116 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-161/yetus-precommit-check/src/.yetus/personality.sh
git revisionmaster / b3084b9
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/1/testReport/
Max. process+thread count62 (vs. ulimit of 2000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/1/console
versionsgit=2.34.1 maven=called xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@szlta

Copy link
Copy Markdown

@alta404 - thanks for your work on this. In order to resolve the conflicts and build issues can you rebase your patch please?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall1m 1smaster passed
+1 💚compile0m 17smaster passed
+1 💚javadoc0m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 43sthe patch passed
+1 💚compile0m 18sthe patch passed
+1 💚javac0m 18sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚javadoc0m 7sthe patch passed
_ Other Tests _
+1 💚unit0m 48sroot in the patch passed.
+1 💚asflicense0m 7sThe patch does not generate ASF License warnings.
5m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#161
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux dc60a5375306 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-161/yetus-precommit-check/src/.yetus/personality.sh
git revisionmaster / bd50787
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/2/testReport/
Max. process+thread count419 (vs. ulimit of 2000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/2/console
versionsgit=2.34.1 maven=called xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@szltaszlta left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding)

@pankaj72981@NihalJain could you take a look as well please?

Comment threadpom.xml
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall0m 43smaster passed
+1 💚compile0m 18smaster passed
+1 💚javadoc0m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 41sthe patch passed
+1 💚compile0m 19sthe patch passed
+1 💚javac0m 19sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚javadoc0m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 46sroot in the patch passed.
+1 💚asflicense0m 5sThe patch does not generate ASF License warnings.
3m 43s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#161
Optional Testsdupname asflicense javac javadoc unit codespell detsecrets xmllint compile
unameLinux 7efd77d1eb0f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-161/yetus-precommit-check/src/.yetus/personality.sh
git revisionmaster / c45888b
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/3/testReport/
Max. process+thread count404 (vs. ulimit of 2000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-161/3/console
versionsgit=2.34.1 maven=called xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Comment threadpom.xml

@PDavidPDavid left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. 👍

@szlta

Copy link
Copy Markdown

@alta404 thanks for this PR, I think you can go ahead and merge it

@alta404

Copy link
Copy Markdown
ContributorAuthor

@szlta looks like I don't have access to merge in this repo. Could you please merge it?

@PDavid
PDavid merged commit 790d55a into apache:masterJun 26, 2026
1 check passed
@PDavid

Copy link
Copy Markdown

Many thanks for your contribution @alta404! Also thanks @pankaj72981 and @szlta for your reviews!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alta404@Apache-HBase@szlta@PDavid@pankaj72981