Skip to content

HBASE-26592 Fix the broken shaded protobuf module - #70

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-26592
Dec 17, 2021
Merged

HBASE-26592 Fix the broken shaded protobuf module#70
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-26592

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Dec 17, 2021
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Remove protobuf-java dependency, we only need to unpack its source so only need the artifact dependency in maven dependency plugin.

Add a resources section to include the proto files when generating the final jar.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall0m 46smaster passed
+1 💚compile0m 9smaster passed
+1 💚javadoc0m 8smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 10sthe patch passed
+1 💚compile0m 9sthe patch passed
+1 💚javac0m 9sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 5sthe patch passed
_ Other Tests _
+1 💚unit0m 9shbase-shaded-protobuf in the patch passed.
+1 💚asflicense0m 6sThe patch does not generate ASF License warnings.
3m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-70/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#70
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 0eff5a9cf227 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / c81cf5c
Default JavaOracle Corporation-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-70/1/testReport/
Max. process+thread count39 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf U: hbase-shaded-protobuf
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-70/1/console
versionsgit=2.20.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 775a3bc into apache:masterDec 17, 2021
asfgit pushed a commit that referenced this pull request Dec 17, 2021
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@pankaj72981