HBASE-23662 : Replace HColumnDescriptor(String cf) with ColumnFamilyD…

[virajjasani]

…escriptor

[petersomogyi]

Nice cleanup @virajjasani!

[virajjasani]

@petersomogyi a couple of test failures in above build seems irrelevant, they all are passing locally.
Thanks

[virajjasani]

Incorporated review comments

[petersomogyi]

+1, pending QA
Let's wait for QA result. The above is for the second run and not the latest.

[HorizonNet]

LGTM. Nice cleanup. TestExportSnapshotNoCluster seems to fail consistently, but not related to the changes made here.

[virajjasani]

Sure let pending QA complete.
Thanks for the review @petersomogyi@HorizonNet

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 50 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 15s	master passed
+1 💚	compile	3m 59s	master passed
+1 💚	checkstyle	4m 17s	master passed
+1 💚	shadedjars	5m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 32s	master passed
+0 🆗	spotbugs	1m 36s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	10m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 36s	the patch passed
+1 💚	compile	4m 24s	the patch passed
+1 💚	javac	4m 24s	the patch passed
+1 💚	checkstyle	0m 34s	hbase-client: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40)
+1 💚	checkstyle	1m 36s	hbase-server: The patch generated 0 new + 362 unchanged - 3 fixed = 362 total (was 365)
+1 💚	checkstyle	0m 22s	The patch passed checkstyle in hbase-mapreduce
+1 💚	checkstyle	0m 44s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 13s	The patch passed checkstyle in hbase-endpoint
+1 💚	checkstyle	0m 18s	The patch passed checkstyle in hbase-it
+1 💚	checkstyle	0m 18s	hbase-rest: The patch generated 0 new + 19 unchanged - 6 fixed = 19 total (was 25)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 25s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	2m 31s	the patch passed
+1 💚	findbugs	10m 48s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 53s	hbase-client in the patch passed.
+1 💚	unit	152m 10s	hbase-server in the patch passed.
-1 ❌	unit	16m 2s	hbase-mapreduce in the patch failed.
+1 💚	unit	3m 22s	hbase-thrift in the patch passed.
+1 💚	unit	3m 50s	hbase-endpoint in the patch passed.
+1 💚	unit	1m 5s	hbase-it in the patch passed.
+1 💚	unit	4m 25s	hbase-rest in the patch passed.
+1 💚	asflicense	3m 12s	The patch does not generate ASF License warnings.
		277m 55s

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1003/3/artifact/out/Dockerfile
GITHUB PR	#1003
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8db21fac7d7f 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1003/out/precommit/personality/provided.sh
git revision	master / c8c7aec
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1003/3/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1003/3/testReport/
Max. process+thread count	5271 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-it hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1003/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[virajjasani]

Thanks for the review @petersomogyi@HorizonNet
Will merge this in a while