Skip to content

HBASE-23664 Upgrade JUnit to 4.13 - #1009

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:23664-junit-4.13-branch-2
Jan 10, 2020
Merged

HBASE-23664 Upgrade JUnit to 4.13#1009
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:23664-junit-4.13-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Jan 9, 2020

Copy link
Copy Markdown
Member

Backport of #1004 to branch-2.

@Apache-HBase

Apache-HBase commented Jan 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+1 💚mvninstall5m 22sbranch-2 passed
+1 💚compile3m 0sbranch-2 passed
+1 💚shadedjars4m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 56sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall5m 1sthe patch passed
+1 💚compile3m 8sthe patch passed
+1 💚javac3m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚shadedjars4m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck16m 31sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc3m 0sthe patch passed
_ Other Tests _
+1 💚unit251m 49sroot in the patch passed.
+1 💚asflicense0m 43sThe patch does not generate ASF License warnings.
307m 56s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1009/1/artifact/out/Dockerfile
GITHUB PR#1009
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux b030f65b1873 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1009/out/precommit/personality/provided.sh
git revisionbranch-2 / d7e7d02
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1009/1/testReport/
Max. process+thread count5514 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1009/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Jan 10, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ndimiduk
ndimiduk merged commit fdc9dd6 into apache:branch-2Jan 10, 2020
@ndimiduk
ndimiduk deleted the 23664-junit-4.13-branch-2 branch January 10, 2020 15:21
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@ndimidukGuanghao Zhang
HBASE-23664 Upgrade JUnit to 4.13 (apache#1009)
cc55e47
Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes
@HorizonNetHorizonNetHorizonNet approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ndimiduk@Apache-HBase@saintstack@HorizonNet@virajjasani