Skip to content

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore - #1026

Merged
bharathv merged 1 commit into
apache:masterfrom
binlijin:HBASE-23682
Feb 8, 2020
Merged

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore#1026
bharathv merged 1 commit into
apache:masterfrom
binlijin:HBASE-23682

Conversation

@binlijin

@binlijinbinlijin commented Jan 13, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Jan 13, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall5m 40smaster passed
+1 💚compile1m 16smaster passed
+1 💚checkstyle1m 44smaster passed
+1 💚shadedjars5m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 53smaster passed
+0 🆗spotbugs5m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall6m 12sthe patch passed
+1 💚compile1m 18sthe patch passed
+1 💚javac1m 18sthe patch passed
+1 💚checkstyle1m 46sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 19sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 51sthe patch passed
+1 💚findbugs5m 36sthe patch passed
_ Other Tests _
+1 💚unit3m 41shbase-procedure in the patch passed.
+1 💚unit156m 21shbase-server in the patch passed.
+1 💚asflicense0m 56sThe patch does not generate ASF License warnings.
231m 30s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/1/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 336599b1b7e7 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 0bf933b
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/1/testReport/
Max. process+thread count5069 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet reviewed Jan 13, 2020
View reviewed changes

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Can you also add test cases to ensure we don't run into this one again (at least for the AssignmentManager)?

bharathv
bharathv reviewed Jan 14, 2020
View reviewed changes

@bharathvbharathv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stumbled upon this change. It looks like Nullable annotations are not a standard but curious whats the community's take on it.

Comment threadhbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated
@binlijin

binlijin commented Jan 14, 2020

Copy link
Copy Markdown
ContributorAuthor

LGTM overall. Can you also add test cases to ensure we don't run into this one again (at least for the AssignmentManager)?

Done.

@Apache-HBase

Apache-HBase commented Jan 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 43smaster passed
+1 💚compile1m 15smaster passed
+1 💚checkstyle1m 43smaster passed
+1 💚shadedjars4m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs5m 3sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 27sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚checkstyle1m 40sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 9sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 51sthe patch passed
+1 💚findbugs5m 34sthe patch passed
_ Other Tests _
+1 💚unit3m 45shbase-procedure in the patch passed.
+1 💚unit157m 7shbase-server in the patch passed.
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
227m 52s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/2/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 959f54e97394 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 499ff32
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/2/testReport/
Max. process+thread count4928 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv
bharathv requested changes Jan 14, 2020
View reviewed changes

@bharathvbharathv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the annotations. Few comments in the added test. Mind cleaning it up?

Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java Outdated
/**
* Base class for AM test.
*/
@Category({ MasterTests.class, LargeTests.class })

@bharathvbharathvJan 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be MediumTest, no?

@binlijinbinlijinJan 15, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java Outdated
protected HBaseTestingUtility util;

protected void setupConfiguration(Configuration conf) throws Exception {
FSUtils.setRootDir(conf, util.getDataTestDir());

@bharathvbharathvJan 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again looks like a remnant of copy+paste from TestAssignment...

@binlijinbinlijinJan 15, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it

Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java Outdated
this.util.createTable(tableName, "f");
this.util.waitTableAvailable(tableName);
} finally {
this.util.killMiniHBaseCluster();

@bharathvbharathvJan 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to tearDown()?

@HorizonNetHorizonNetJan 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have a shutdown, instead of kill the cluster, in tearDown. Also seems that an assertion in this test is missing.

@binlijinbinlijinJan 15, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failed when startMiniCluster without this patch.

[INFO] Running org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 210.246 s <<< FAILURE! - in org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore
[ERROR] org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore.testDeadServerMetricRegionChore Time elapsed: 210.054 s <<< ERROR!
java.io.IOException: Shutting down
at org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore.testDeadServerMetricRegionChore(TestDeadServerMetricRegionChore.java:60)
Caused by: java.lang.RuntimeException: Master not initialized after 200000ms
at org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore.testDeadServerMetricRegionChore(TestDeadServerMetricRegionChore.java:60)

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the shutdown failing or because it is part of the tearDown?

@binlijinbinlijinJan 16, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shutdown has no problem, i already change killMiniHBaseCluster
to shutdownMiniCluster.

@Apache-HBase

Apache-HBase commented Jan 15, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 41smaster passed
+1 💚compile1m 14smaster passed
+1 💚checkstyle1m 48smaster passed
+1 💚shadedjars5m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59smaster passed
+0 🆗spotbugs5m 23sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs6m 3smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 31sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
-1 ❌checkstyle1m 30shbase-server: The patch generated 2 new + 9 unchanged - 0 fixed = 11 total (was 9)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 47sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 51sthe patch passed
+1 💚findbugs6m 4sthe patch passed
_ Other Tests _
+1 💚unit3m 58shbase-procedure in the patch passed.
+1 💚unit158m 57shbase-server in the patch passed.
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
232m 13s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9e584873e6ac 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 499ff32
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/testReport/
Max. process+thread count5425 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 15, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 21sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall5m 44smaster passed
+1 💚compile1m 19smaster passed
+1 💚checkstyle1m 49smaster passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59smaster passed
+0 🆗spotbugs5m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 27sthe patch passed
+1 💚compile1m 25sthe patch passed
+1 💚javac1m 25sthe patch passed
+1 💚checkstyle1m 48sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck18m 15sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 59sthe patch passed
+1 💚findbugs6m 30sthe patch passed
_ Other Tests _
+1 💚unit3m 58shbase-procedure in the patch passed.
+1 💚unit179m 18shbase-server in the patch passed.
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
254m 2s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/4/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 09e49d4ba3cb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 4e60583
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/4/testReport/
Max. process+thread count5360 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv
bharathv requested changes Jan 15, 2020
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated
Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java Outdated
@@ -0,0 +1,68 @@
/**

@bharathvbharathvJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: /*

@binlijinbinlijinJan 16, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean change "/**" to "/*" ? I see other tests all use "/**" no one use "/*"

@bharathvbharathvJan 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/** is interpreted as a javadoc in IDEs. If you notice others' changes, people are switching to /* incrementally in their patches (files they are touching). Now that you are adding a new class, it is better to start with /*.

@binlijinbinlijinJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for you explanation.

@Apache-HBase

Apache-HBase commented Jan 16, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 21sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 53smaster passed
+1 💚compile1m 18smaster passed
+1 💚checkstyle1m 43smaster passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57smaster passed
+0 🆗spotbugs5m 28sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs6m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall6m 30sthe patch passed
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
+1 💚checkstyle1m 52sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck18m 50sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 51sthe patch passed
+1 💚findbugs5m 37sthe patch passed
_ Other Tests _
+1 💚unit3m 47shbase-procedure in the patch passed.
-1 ❌unit164m 52shbase-server in the patch failed.
+1 💚asflicense0m 48sThe patch does not generate ASF License warnings.
240m 47s
ReasonTests
Failed junit testshadoop.hbase.master.assignment.TestRegionMoveAndAbandon
hadoop.hbase.master.TestMasterNoCluster
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 9e89df078a8f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 19d3bed
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/testReport/
Max. process+thread count4742 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 16, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for branch
+1 💚mvninstall5m 59smaster passed
+1 💚compile1m 32smaster passed
+1 💚checkstyle1m 49smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7smaster passed
+0 🆗spotbugs5m 32sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs6m 10smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall6m 8sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚checkstyle1m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 22sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 52sthe patch passed
+1 💚findbugs5m 36sthe patch passed
_ Other Tests _
+1 💚unit3m 36shbase-procedure in the patch passed.
-1 ❌unit169m 24shbase-server in the patch failed.
+1 💚asflicense0m 54sThe patch does not generate ASF License warnings.
243m 34s
ReasonTests
Failed junit testshadoop.hbase.TestHBaseTestingUtility
hadoop.hbase.master.assignment.TestRegionMoveAndAbandon
hadoop.hbase.master.TestMasterNoCluster
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 1261dfc1fa9a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 19d3bed
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/testReport/
Max. process+thread count5047 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 17, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall5m 45smaster passed
+1 💚compile1m 19smaster passed
+1 💚checkstyle1m 47smaster passed
+1 💚shadedjars4m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs5m 0sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 26sthe patch passed
+1 💚compile1m 23sthe patch passed
+1 💚javac1m 23sthe patch passed
+1 💚checkstyle1m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 22sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 54sthe patch passed
+1 💚findbugs5m 49sthe patch passed
_ Other Tests _
+1 💚unit3m 44shbase-procedure in the patch passed.
-1 ❌unit167m 37shbase-server in the patch failed.
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
242m 49s
ReasonTests
Failed junit testshadoop.hbase.master.assignment.TestRegionMoveAndAbandon
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5fadedbbb580 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 00fc467
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/testReport/
Max. process+thread count5457 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack

saintstack commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Rerunning build. @bharathv , you approving this change sir?

bharathv
bharathv reviewed Feb 5, 2020
View reviewed changes

@bharathvbharathv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saintstack There were a couple of comments that weren't addressed since the last review. +1 once they are addressed.
@binlijin FYI.

+1

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated
Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
@Apache-HBase

Apache-HBase commented Feb 6, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 38sMaven dependency ordering for branch
+1 💚mvninstall5m 53smaster passed
+1 💚compile1m 23smaster passed
+1 💚checkstyle1m 29smaster passed
+1 💚shadedjars5m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 53smaster passed
+0 🆗spotbugs4m 27sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 32sthe patch passed
+1 💚compile1m 18sthe patch passed
+1 💚javac1m 18sthe patch passed
+1 💚checkstyle1m 30sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 43sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 50sthe patch passed
+1 💚findbugs5m 30sthe patch passed
_ Other Tests _
+1 💚unit1m 49shbase-procedure in the patch passed.
+1 💚unit99m 24shbase-server in the patch passed.
+1 💚asflicense0m 56sThe patch does not generate ASF License warnings.
171m 11s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/8/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux dd1b8cc91996 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / b49ec58
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/8/testReport/
Max. process+thread count6551 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

binlijin
binlijin commented Feb 6, 2020
View reviewed changes

@binlijinbinlijin left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathv The latest patch should have addressed all you comment.

Comment thread...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
@Apache-HBase

Apache-HBase commented Feb 6, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep0m 40sMaven dependency ordering for branch
+1 💚mvninstall5m 52smaster passed
+1 💚compile1m 17smaster passed
+1 💚checkstyle1m 30smaster passed
+1 💚shadedjars5m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52smaster passed
+0 🆗spotbugs4m 56sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 30smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 34sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚checkstyle1m 29sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 36sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 51sthe patch passed
+1 💚findbugs5m 33sthe patch passed
_ Other Tests _
+1 💚unit1m 42shbase-procedure in the patch passed.
+1 💚unit92m 1shbase-server in the patch passed.
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
161m 16s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/9/artifact/out/Dockerfile
GITHUB PR#1026
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 11c36c70826d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revisionmaster / 867b1e9
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/9/testReport/
Max. process+thread count7291 (vs. ulimit of 10000)
modulesC: hbase-procedure hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/9/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv
bharathv reviewed Feb 7, 2020
View reviewed changes

@bharathvbharathv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HorizonNet You were looking at this too, any more comments or is this good to go?

@bharathv
bharathv merged commit 24823ec into apache:masterFeb 8, 2020
bharathv pushed a commit to bharathv/hbase that referenced this pull request Feb 8, 2020
@binlijin@bharathv
HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…
fa396f3
…1026)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 24823ec)
bharathv added a commit that referenced this pull request Feb 9, 2020
@bharathv
HBASE-23682Fix NPE when disable DeadServerMetricRegionChore (#1026) (#…
40c37dd
…1151)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 24823ec)
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@binlijin@thangTang
HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…
5ef1add
…1026)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@binlijin@thangTang
HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…
3b8b98d
…1026)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@bharathv@infraio
HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…
75a4502
…1026) (apache#1151)
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 24823ec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharathvbharathvbharathv approved these changes
@HorizonNetHorizonNetHorizonNet left review comments

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@binlijin@Apache-HBase@saintstack@bharathv@HorizonNet