Uh oh!
There was an error while loading. Please reload this page.
HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common - #1030
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache-HBase
commented
Jan 14, 2020
🎊 +1 overall
This message was automatically generated. |
busbey
reviewed
Jan 15, 2020
| * licenses this file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| /** |
Contributor
There was a problem hiding this comment.
this is a file header and not a javadoc, shouldn't it be using /* and not /**?
Apache-HBase
commented
Jan 16, 2020
Apache-HBase
commented
Jan 16, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 17, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 17, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 21, 2020
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Jan 23, 2020
saintstack
left a comment
Contributor
There was a problem hiding this comment.
A question below but LGTM. Nice.
| consume(doCreateCellScanner(1, 1), 1 * 1); | ||
| consume(doCreateCellScanner(3, 0), 3 * 0); | ||
| consume(doCreateCellScanner(1, 1), 1); | ||
| consume(doCreateCellScanner(3, 0), 0); |
| private int baseTimestampDivide = 1000000; | ||
| private int timestampDiffSize = 100000000; | ||
| private int baseTimestampDivide; | ||
| private int timestampDiffSize; |
Contributor
There was a problem hiding this comment.
The values are overwritten later?
ContributorAuthor
There was a problem hiding this comment.
They are both overwritten in the constructor above.
saintstack
commented
Jan 24, 2020
Contributor
I'm still +1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #967 to branch-1.