Uh oh!
There was an error while loading. Please reload this page.
HBASE-23696 Stop WALProcedureStore after migration finishes - #1050
Closed
saintstack wants to merge 1 commit into
Closed
HBASE-23696 Stop WALProcedureStore after migration finishes#1050saintstack wants to merge 1 commit into
saintstack wants to merge 1 commit into
Conversation
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a question regarding stopping it on the catch body. I had something similar in HBASE-23694 after observing the issues described there, but didn't enclose it in a try/catch.
| throw new IOException("Failed to delete the WALProcedureStore migrated proc wal directory " + | ||
| procWALDir); | ||
| LOG.info("Migration of WALProcedureStore finished"); | ||
| } catch (IOException ioe) { |
Contributor
There was a problem hiding this comment.
Do we need the catch, or could just stop it on the finally and let the IOE be thrown upwards?
ContributorAuthor
There was a problem hiding this comment.
Sorry @wchevreuil . I only now noticed you'd just put up a fix for the same thing.
On this line, I should have rethrown the caught exception. I wanted to pass in 'true' for abort if exception as opposed to 'false' for the finally block. I might be overthinking it since IIRC, if problem here, we'll crash out the Master. Let me resolve this in favor of yours.
saintstack
commented
Jan 15, 2020
ContributorAuthor
Closing as dupe of HBASE-23696 |
saintstack
commented
Jan 15, 2020
ContributorAuthor
Apache-HBase
commented
Jan 15, 2020
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.