Skip to content

HBASE-23698 Switch central repo to https - #1053

Merged
petersomogyi merged 1 commit into
apache:branch-1from
bharathv:HBASE-23698-branch-1
Jan 16, 2020
Merged

HBASE-23698 Switch central repo to https#1053
petersomogyi merged 1 commit into
apache:branch-1from
bharathv:HBASE-23698-branch-1

Conversation

@bharathv

Copy link
Copy Markdown
Contributor

No description provided.

@bharathv
bharathvforce-pushed the HBASE-23698-branch-1 branch from b68df72 to 65f2556CompareJanuary 15, 2020 23:42
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
-1 ❌mvninstall0m 9sroot in branch-1 failed.
-1 ❌compile0m 6sroot in branch-1 failed with JDK v1.8.0_242.
-1 ❌compile0m 7sroot in branch-1 failed with JDK v1.7.0_252.
-1 ❌shadedjars0m 5sbranch has 11 errors when building our shaded downstream artifacts.
-1 ❌javadoc0m 6sroot in branch-1 failed with JDK v1.8.0_242.
-1 ❌javadoc0m 7sroot in branch-1 failed with JDK v1.7.0_252.
_ Patch Compile Tests _
-1 ❌mvninstall0m 7sroot in the patch failed.
-1 ❌compile0m 6sroot in the patch failed with JDK v1.8.0_242.
-1 ❌javac0m 6sroot in the patch failed with JDK v1.8.0_242.
-1 ❌compileN/Aroot in the patch failed with JDK v1.7.0_252.
-1 ❌javacN/Aroot in the patch failed with JDK v1.7.0_252.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
-1 ❌shadedjars0m 5spatch has 11 errors when building our shaded downstream artifacts.
-1 ❌hadoopcheck0m 5sThe patch causes 11 errors with Hadoop v2.8.5.
-1 ❌hadoopcheck0m 10sThe patch causes 11 errors with Hadoop v2.9.2.
-1 ❌javadoc0m 6sroot in the patch failed with JDK v1.8.0_242.
-1 ❌javadoc0m 7sroot in the patch failed with JDK v1.7.0_252.
_ Other Tests _
-1 ❌unit0m 7sroot in the patch failed.
+0 🆗asflicense0m 7sASF License check generated no output?
3m 40s
ReasonTests
XMLParsing Error(s):
pom.xml
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/Dockerfile
GITHUB PR#1053
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 1aee8547bc1c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1053/out/precommit/personality/provided.sh
git revisionbranch-1 / 907184d
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/branch-compile-root-jdk1.8.0_242.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/branch-compile-root-jdk1.7.0_252.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/branch-shadedjars.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/branch-javadoc-root-jdk1.8.0_242.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/branch-javadoc-root-jdk1.7.0_252.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-compile-root-jdk1.8.0_242.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-compile-root-jdk1.8.0_242.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-compile-root-jdk1.7.0_252.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-compile-root-jdk1.7.0_252.txt
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/xml.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-javac-2.9.2.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-javadoc-root-jdk1.8.0_242.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-javadoc-root-jdk1.7.0_252.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/testReport/
Max. process+thread count41 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/1/console
versionsgit=1.9.1 maven=3.0.5
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
-1 ❌mvninstall0m 9sroot in branch-1 failed.
-1 ❌compile0m 6sroot in branch-1 failed with JDK v1.8.0_242.
-1 ❌compile0m 8sroot in branch-1 failed with JDK v1.7.0_252.
-1 ❌shadedjars0m 5sbranch has 11 errors when building our shaded downstream artifacts.
-1 ❌javadoc0m 6sroot in branch-1 failed with JDK v1.8.0_242.
-1 ❌javadoc0m 7sroot in branch-1 failed with JDK v1.7.0_252.
_ Patch Compile Tests _
+1 💚mvninstall8m 29sthe patch passed
+1 💚compile1m 48sthe patch passed with JDK v1.8.0_242
-1 ❌javac1m 48sroot-jdk1.8.0_242 with JDK v1.8.0_242 generated 38 new + 0 unchanged - 0 fixed = 38 total (was 0)
+1 💚compile1m 55sthe patch passed with JDK v1.7.0_252
-1 ❌javac1m 55sroot-jdk1.7.0_252 with JDK v1.7.0_252 generated 38 new + 0 unchanged - 0 fixed = 38 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
+1 💚shadedjars3m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 15sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
-1 ❌javadoc2m 24sroot-jdk1.8.0_242 with JDK v1.8.0_242 generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0)
-1 ❌javadoc4m 26sroot-jdk1.7.0_252 with JDK v1.7.0_252 generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
_ Other Tests _
-1 ❌unit174m 8sroot in the patch failed.
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
207m 37s
ReasonTests
XMLParsing Error(s):
pom.xml
Failed junit testshadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/Dockerfile
GITHUB PR#1053
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux de9ceeaeab7d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1053/out/precommit/personality/provided.sh
git revisionbranch-1 / 907184d
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/branch-compile-root-jdk1.8.0_242.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/branch-compile-root-jdk1.7.0_252.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/branch-shadedjars.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/branch-javadoc-root-jdk1.8.0_242.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/branch-javadoc-root-jdk1.7.0_252.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/diff-compile-javac-root-jdk1.8.0_242.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/diff-compile-javac-root-jdk1.7.0_252.txt
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/xml.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/diff-javadoc-javadoc-root-jdk1.8.0_242.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/diff-javadoc-javadoc-root-jdk1.7.0_252.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/testReport/
Max. process+thread count3784 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1053/2/console
versionsgit=1.9.1 maven=3.0.5
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Comment threadpom.xml
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the parent apache pom (v22) to see if it had this repo in it. It doesn't. Just has apache repo.

This looks good. When you clean your local repo, are you downloading from https?

Thanks

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, verified that.

@saintstack

Copy link
Copy Markdown
Contributor

Its for branch-1 only?

@bharathvbharathv left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its for branch-1 only?

Right now it looks like only branch-1 is affected, probably because branch-1 jobs use an older version of maven (we don't log the version anywhere to confirm that). Like I noted in the jira, mvn versions >= 3.2.3 automatically use https. So folks building locally with latest mvn versions won't hit this issue either.

Comment threadpom.xml
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, verified that.

@petersomogyi

Copy link
Copy Markdown
Contributor

I ran into this and thought the build failure was related to HBASE-23675.

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the build using Maven 3.0.5.

@petersomogyipetersomogyi changed the title Switch central repo to httpsHBASE-23698 Switch central repo to httpsJan 16, 2020
@petersomogyi
petersomogyi merged commit 99a328f into apache:branch-1Jan 16, 2020
@bharathv
bharathv deleted the HBASE-23698-branch-1 branch January 16, 2020 19:00
asfgit pushed a commit that referenced this pull request Jan 17, 2020
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
asfgit pushed a commit that referenced this pull request Jan 17, 2020
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
udaynpusa pushed a commit to mapr/hbase that referenced this pull request Jan 30, 2024
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 8cb278e)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bharathv@Apache-HBase@saintstack@petersomogyi