HBASE-23626 Reduced number of Checkstyle violations in tests in hbase-common

[HorizonNet]

Backport of #972 to branch-1.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 9 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 37s	branch-1 passed
+1 💚	compile	0m 18s	branch-1 passed with JDK v1.8.0_242
+1 💚	compile	0m 22s	branch-1 passed with JDK v1.7.0_252
+1 💚	checkstyle	0m 36s	branch-1 passed
+1 💚	shadedjars	3m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	branch-1 passed with JDK v1.8.0_242
+1 💚	javadoc	0m 22s	branch-1 passed with JDK v1.7.0_252
+0 🆗	spotbugs	1m 16s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 13s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	0m 18s	the patch passed with JDK v1.8.0_242
+1 💚	javac	0m 18s	the patch passed
+1 💚	compile	0m 23s	the patch passed with JDK v1.7.0_252
+1 💚	javac	0m 23s	the patch passed
-1 ❌	checkstyle	0m 30s	hbase-common: The patch generated 12 new + 6 unchanged - 95 fixed = 18 total (was 101)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 17s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 18s	the patch passed with JDK v1.8.0_242
+1 💚	javadoc	0m 25s	the patch passed with JDK v1.7.0_252
+1 💚	findbugs	1m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 29s	hbase-common in the patch passed.
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		37m 1s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/1/artifact/out/Dockerfile
GITHUB PR	#1058
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e1adc50a0232 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1058/out/precommit/personality/provided.sh
git revision	branch-1 / d466f77
Default Java	1.7.0_252
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/1/artifact/out/diff-checkstyle-hbase-common.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/1/testReport/
Max. process+thread count	102 (vs. ulimit of 10000)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 9 new or modified test files.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	9m 0s	branch-1 passed
+1 💚	compile	0m 17s	branch-1 passed with JDK v1.8.0_242
+1 💚	compile	0m 22s	branch-1 passed with JDK v1.7.0_252
+1 💚	checkstyle	0m 36s	branch-1 passed
+1 💚	shadedjars	3m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	branch-1 passed with JDK v1.8.0_242
+1 💚	javadoc	0m 23s	branch-1 passed with JDK v1.7.0_252
+0 🆗	spotbugs	1m 16s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 13s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	0m 18s	the patch passed with JDK v1.8.0_242
+1 💚	javac	0m 18s	the patch passed
+1 💚	compile	0m 23s	the patch passed with JDK v1.7.0_252
+1 💚	javac	0m 23s	the patch passed
+1 💚	checkstyle	0m 30s	hbase-common: The patch generated 0 new + 2 unchanged - 99 fixed = 2 total (was 101)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 13s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 18s	the patch passed with JDK v1.8.0_242
+1 💚	javadoc	0m 23s	the patch passed with JDK v1.7.0_252
+1 💚	findbugs	1m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 29s	hbase-common in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		36m 45s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/2/artifact/out/Dockerfile
GITHUB PR	#1058
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e158878e30a2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1058/out/precommit/personality/provided.sh
git revision	branch-1 / d466f77
Default Java	1.7.0_252
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/2/testReport/
Max. process+thread count	102 (vs. ulimit of 10000)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1058/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[saintstack]

Skimmed