HBASE-23627 Resolved remaining Checkstyle violations in hbase-thrift

[HorizonNet]

No description provided.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 34s	branch-1 passed
+1 💚	compile	0m 24s	branch-1 passed with JDK v1.8.0_242
+1 💚	compile	0m 32s	branch-1 passed with JDK v1.7.0_252
+1 💚	checkstyle	0m 35s	branch-1 passed
+1 💚	shadedjars	3m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	branch-1 passed with JDK v1.8.0_242
+1 💚	javadoc	1m 40s	branch-1 passed with JDK v1.7.0_252
+0 🆗	spotbugs	1m 57s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 54s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	0m 24s	the patch passed with JDK v1.8.0_242
+1 💚	javac	0m 24s	the patch passed
+1 💚	compile	0m 32s	the patch passed with JDK v1.7.0_252
+1 💚	javac	0m 32s	the patch passed
-1 ❌	checkstyle	0m 29s	hbase-thrift: The patch generated 1 new + 0 unchanged - 12 fixed = 1 total (was 12)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 8s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 24s	the patch passed with JDK v1.8.0_242
+1 💚	javadoc	1m 41s	the patch passed with JDK v1.7.0_252
+1 💚	findbugs	1m 59s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 2s	hbase-thrift in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		44m 25s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/1/artifact/out/Dockerfile
GITHUB PR	#1065
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7ccf1c09b6fe 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1065/out/precommit/personality/provided.sh
git revision	branch-1 / dc602d7
Default Java	1.7.0_252
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/1/artifact/out/diff-checkstyle-hbase-thrift.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/1/testReport/
Max. process+thread count	568 (vs. ulimit of 10000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	9m 13s	branch-1 passed
+1 💚	compile	0m 23s	branch-1 passed with JDK v1.8.0_242
+1 💚	compile	0m 33s	branch-1 passed with JDK v1.7.0_252
+1 💚	checkstyle	0m 33s	branch-1 passed
+1 💚	shadedjars	3m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	branch-1 passed with JDK v1.8.0_242
+1 💚	javadoc	1m 41s	branch-1 passed with JDK v1.7.0_252
+0 🆗	spotbugs	1m 56s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 53s	branch-1 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	0m 24s	the patch passed with JDK v1.8.0_242
+1 💚	javac	0m 24s	the patch passed
+1 💚	compile	0m 32s	the patch passed with JDK v1.7.0_252
+1 💚	javac	0m 32s	the patch passed
+1 💚	checkstyle	0m 28s	hbase-thrift: The patch generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	3m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 29s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 24s	the patch passed with JDK v1.8.0_242
+1 💚	javadoc	1m 40s	the patch passed with JDK v1.7.0_252
+1 💚	findbugs	2m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 15s	hbase-thrift in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		45m 51s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/2/artifact/out/Dockerfile
GITHUB PR	#1065
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 26205b0e872b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1065/out/precommit/personality/provided.sh
git revision	branch-1 / 99a59cf
Default Java	1.7.0_252
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/2/testReport/
Max. process+thread count	572 (vs. ulimit of 10000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1065/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[saintstack]

LGTM. Nice cleanup.