Uh oh!
There was an error while loading. Please reload this page.
HBASE-23708 Support metrics for region traffic - #1069
Open
Yiran-wu wants to merge 1 commit into
Open
Conversation
Apache-HBase
commented
Jan 19, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 20, 2020
💔 -1 overall
This message was automatically generated. |
Yiran-wu
commented
Jan 20, 2020
ContributorAuthor
This error can be ignored. I didn't change it. What about the others?
|
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this. For sure we are not double counting? These are not exposed already? If not, nice addition. They just show in JMX? Exposing them in UI would be a follow-on?
Thanks for doing this.
| if (mutation instanceof Put) { | ||
| HRegion.updateCellTimestamps(familyCellMaps[index].values(), byteTS); | ||
| miniBatchOp.incrementNumOfPuts(); | ||
| miniBatchOp.incrementBytesForPuts(mutation.heapSize()); |
Contributor
There was a problem hiding this comment.
Do we traverse any synchronize blocks here or update any volatiles? In other words, wondering what the cost of these updates are.
We are also bulking up metrics w/ these added numbers... the metrics we send the master on each report (every second or so).
Contributor
There was a problem hiding this comment.
We spend a lot of cpu counting currently. This adds to the counting load.
ContributorAuthor
There was a problem hiding this comment.
@saintstack Thanks for review
At present, we only have aggregate information and cannot know how much network resources are used in each region.
Contributor
There was a problem hiding this comment.
I too am concerned about the cost of evaluating heapSize() in a hot code path. Also, this is not the best estimate of the wire size of the put.
| public void updatePut(final long size) { | ||
| source.updatePut(); | ||
| source.updatePutBytes(size); | ||
| source.updateReceivedBytes(size); |
Contributor
There was a problem hiding this comment.
What is the difference between put and received? They are not the same?
ContributorAuthor
There was a problem hiding this comment.
Received contains all write operations such as increment/append/put/bulkload, putBytes consists of its own
Apache-HBase
commented
Apr 18, 2020
💔 -1 overall
This message was automatically generated. |
2 similar comments
Apache-HBase
commented
Apr 18, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 18, 2020
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we need some metrics to measure the amount of traffic being read and written to each region, which can help us more clearly analyze how much network resources are consumed by each region.
putBytes/getBytes/scanBytes/deleteBytes/incrementBytes/appendBytes/bulkLoadBytes