Skip to content

HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests - #1075

Merged
HorizonNet merged 3 commits into
apache:branch-1from
ultratendency:HBASE-23645_branch-1
Jan 22, 2020
Merged

HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests#1075
HorizonNet merged 3 commits into
apache:branch-1from
ultratendency:HBASE-23645_branch-1

Conversation

@HorizonNet

@HorizonNetHorizonNet commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

Backport of #989 to branch-1.

@Apache-HBase

Apache-HBase commented Jan 20, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep1m 26sMaven dependency ordering for branch
+1 💚mvninstall7m 54sbranch-1 passed
+1 💚compile0m 28sbranch-1 passed with JDK v1.8.0_242
+1 💚compile0m 34sbranch-1 passed with JDK v1.7.0_252
+1 💚checkstyle5m 58sbranch-1 passed
+1 💚shadedjars3m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34sbranch-1 passed with JDK v1.8.0_242
+1 💚javadoc0m 35sbranch-1 passed with JDK v1.7.0_252
+0 🆗spotbugs1m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 24sbranch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile0m 28sthe patch passed with JDK v1.8.0_242
+1 💚javac0m 28sthe patch passed
+1 💚compile0m 35sthe patch passed with JDK v1.7.0_252
+1 💚javac0m 35sthe patch passed
+1 💚checkstyle5m 55sroot: The patch generated 0 new + 1 unchanged - 29 fixed = 1 total (was 30)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
+1 💚shadedjars3m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 21sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 29sthe patch passed with JDK v1.8.0_242
+1 💚javadoc0m 35sthe patch passed with JDK v1.7.0_252
+0 🆗findbugs0m 12shbase-checkstyle has no data from findbugs
_ Other Tests _
+1 💚unit0m 11shbase-checkstyle in the patch passed.
+1 💚unit2m 34shbase-common in the patch passed.
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
51m 0s
ReasonTests
XMLParsing Error(s):
hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/1/artifact/out/Dockerfile
GITHUB PR#1075
Optional Testsdupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
unameLinux da78c439ca9e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1075/out/precommit/personality/provided.sh
git revisionbranch-1 / 99a59cf
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/1/artifact/out/xml.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/1/testReport/
Max. process+thread count164 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-common U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Jan 20, 2020
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. LGTM

Whats the ill-formed xml thing about?

Comment threadhbase-common/src/test/java/org/apache/hadoop/hbase/TestTimeout.java
*/
@Ignore
@Test
public void infiniteLoop() {

@saintstacksaintstackJan 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this one.....

Comment threadhbase-common/src/test/java/org/apache/hadoop/hbase/Waiter.java
* Perform a predicate evaluation.
* @return the boolean result of the evaluation.
* @throws Exception thrown if the predicate evaluation could not evaluate.
* @throws E thrown if the predicate evaluation could not evaluate.

@saintstacksaintstackJan 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@HorizonNet

HorizonNet commented Jan 20, 2020

Copy link
Copy Markdown
ContributorAuthor

@saintstack It is related to HBASE-22732. We get it on every PR targeting branch-1, which changes the suppressions file.

@Apache-HBase

Apache-HBase commented Jan 20, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec21m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep1m 30sMaven dependency ordering for branch
+1 💚mvninstall8m 11sbranch-1 passed
+1 💚compile0m 33sbranch-1 passed with JDK v1.8.0_242
+1 💚compile0m 40sbranch-1 passed with JDK v1.7.0_252
+1 💚checkstyle6m 21sbranch-1 passed
+1 💚shadedjars4m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sbranch-1 passed with JDK v1.8.0_242
+1 💚javadoc0m 39sbranch-1 passed with JDK v1.7.0_252
+0 🆗spotbugs1m 14sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 26sbranch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
-0 ⚠️patch1m 30sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 35sthe patch passed
+1 💚compile0m 34sthe patch passed with JDK v1.8.0_242
+1 💚javac0m 34sthe patch passed
+1 💚compile0m 40sthe patch passed with JDK v1.7.0_252
+1 💚javac0m 40sthe patch passed
-1 ❌checkstyle6m 22sroot: The patch generated 1 new + 0 unchanged - 30 fixed = 1 total (was 30)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
+1 💚shadedjars3m 49spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck6m 26sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 36sthe patch passed with JDK v1.8.0_242
+1 💚javadoc0m 42sthe patch passed with JDK v1.7.0_252
+0 🆗findbugs0m 14shbase-checkstyle has no data from findbugs
_ Other Tests _
+1 💚unit0m 13shbase-checkstyle in the patch passed.
+1 💚unit2m 50shbase-common in the patch passed.
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
77m 58s
ReasonTests
XMLParsing Error(s):
hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/2/artifact/out/Dockerfile
GITHUB PR#1075
Optional Testsdupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
unameLinux 9bbbcc270f40 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1075/out/precommit/personality/provided.sh
git revisionbranch-1 / 2e3273f
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/2/artifact/out/diff-checkstyle-root.txt
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/2/artifact/out/xml.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/2/testReport/
Max. process+thread count171 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-common U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 21, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep1m 22sMaven dependency ordering for branch
+1 💚mvninstall7m 43sbranch-1 passed
+1 💚compile0m 31sbranch-1 passed with JDK v1.8.0_242
+1 💚compile0m 35sbranch-1 passed with JDK v1.7.0_252
+1 💚checkstyle6m 29sbranch-1 passed
+1 💚shadedjars3m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sbranch-1 passed with JDK v1.8.0_242
+1 💚javadoc0m 39sbranch-1 passed with JDK v1.7.0_252
+0 🆗spotbugs1m 10sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 26sbranch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
-0 ⚠️patch1m 23sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 6sthe patch passed
+1 💚compile0m 28sthe patch passed with JDK v1.8.0_242
+1 💚javac0m 28sthe patch passed
+1 💚compile0m 35sthe patch passed with JDK v1.7.0_252
+1 💚javac0m 35sthe patch passed
+1 💚checkstyle5m 50sroot: The patch generated 0 new + 0 unchanged - 30 fixed = 0 total (was 30)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
+1 💚shadedjars3m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 13sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 27sthe patch passed with JDK v1.8.0_242
+1 💚javadoc0m 34sthe patch passed with JDK v1.7.0_252
+0 🆗findbugs0m 12shbase-checkstyle has no data from findbugs
_ Other Tests _
+1 💚unit0m 13shbase-checkstyle in the patch passed.
+1 💚unit2m 30shbase-common in the patch passed.
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
51m 38s
ReasonTests
XMLParsing Error(s):
hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/3/artifact/out/Dockerfile
GITHUB PR#1075
Optional Testsdupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
unameLinux 111011621c10 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1075/out/precommit/personality/provided.sh
git revisionbranch-1 / ee50d48
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/3/artifact/out/xml.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/3/testReport/
Max. process+thread count102 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-common U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1075/3/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 9d4ea24 into apache:branch-1Jan 22, 2020
@HorizonNet
HorizonNet deleted the HBASE-23645_branch-1 branch January 22, 2020 13:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet@Apache-HBase@saintstack