HBASE-23330: Fix delegation token fetch with MasterRegistry by bharathv · Pull Request #1084 · apache/hbase

bharathv · 2020-01-23T08:23:50Z

No description provided.

Apache-HBase · 2020-01-23T13:41:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 41s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	2m 22s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	3m 2s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	5m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 44s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	1m 41s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 29s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 45s	the patch passed
+1 💚	compile	2m 31s	the patch passed
+1 💚	javac	2m 31s	the patch passed
-1 ❌	checkstyle	1m 28s	hbase-server: The patch generated 3 new + 5 unchanged - 0 fixed = 8 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	18m 29s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	2m 3s	the patch passed
+1 💚	findbugs	10m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 6s	hbase-client in the patch passed.
-1 ❌	unit	194m 22s	hbase-server in the patch failed.
+1 💚	unit	24m 20s	hbase-mapreduce in the patch passed.
-1 ❌	unit	4m 6s	hbase-thrift in the patch failed.
+1 💚	asflicense	2m 25s	The patch does not generate ASF License warnings.
		311m 33s

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.regionserver.TestTags
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.thrift2.TestThriftConnection

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/1/artifact/out/Dockerfile
GITHUB PR	#1084
JIRA Issue	HBASE-23330
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4cea401909ad 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1084/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `d9bb034`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/1/artifact/out/patch-unit-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/1/artifact/out/patch-unit-hbase-thrift.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/1/testReport/
Max. process+thread count	5256 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server hbase-mapreduce hbase-thrift U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

apurtell · 2020-01-23T21:12:16Z

Changes look fine, waiting on a clean precommit before approval

Apache-HBase · 2020-01-23T23:41:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 39s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 32s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	2m 36s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	3m 2s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	4m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 8s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	1m 55s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	9m 13s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 16s	the patch passed
+1 💚	compile	2m 38s	the patch passed
+1 💚	javac	2m 38s	the patch passed
+1 💚	checkstyle	3m 6s	the patch passed
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	16m 44s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	2m 4s	the patch passed
+1 💚	findbugs	9m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 15s	hbase-client in the patch passed.
-1 ❌	unit	170m 13s	hbase-server in the patch failed.
-1 ❌	unit	20m 17s	hbase-mapreduce in the patch failed.
+1 💚	unit	4m 7s	hbase-thrift in the patch passed.
+1 💚	asflicense	2m 18s	The patch does not generate ASF License warnings.
		280m 58s

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/2/artifact/out/Dockerfile
GITHUB PR	#1084
JIRA Issue	HBASE-23330
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux cd1927c94e6f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1084/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `d9bb034`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/2/artifact/out/patch-unit-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/2/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/2/testReport/
Max. process+thread count	5524 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server hbase-mapreduce hbase-thrift U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

apurtell · 2020-01-24T01:02:15Z

TestFromClientSide is a known issue and the other failure doesn't look related.

apurtell · 2020-01-24T18:00:06Z

@bharathv Please push an update that resolves the conflicts.

Updated thrift generated java code. Putting in a separate commit for easy reviewing of the core patch.

bharathv · 2020-01-24T21:20:48Z

Rebased after the feature branch got force-pushed.!

apurtell · 2020-01-25T02:04:40Z

Got tired of waiting for another QA run. Since this is a feature branch I think it's fine to merge now.

Apache-HBase · 2020-01-25T02:10:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ HBASE-18095/client-locate-meta-no-zookeeper Compile Tests _
+0 🆗	mvndep	0m 39s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 32s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	compile	2m 36s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	checkstyle	2m 39s	HBASE-18095/client-locate-meta-no-zookeeper passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 0s	HBASE-18095/client-locate-meta-no-zookeeper passed
+0 🆗	spotbugs	1m 43s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 29s	HBASE-18095/client-locate-meta-no-zookeeper passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 12s	the patch passed
+1 💚	compile	2m 44s	the patch passed
+1 💚	javac	2m 44s	the patch passed
+1 💚	checkstyle	2m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	16m 31s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	1m 59s	the patch passed
+1 💚	findbugs	8m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 9s	hbase-client in the patch passed.
-1 ❌	unit	170m 55s	hbase-server in the patch failed.
-1 ❌	unit	20m 26s	hbase-mapreduce in the patch failed.
+1 💚	unit	4m 3s	hbase-thrift in the patch passed.
+1 💚	asflicense	2m 31s	The patch does not generate ASF License warnings.
		280m 2s

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.snapshot.TestExportSnapshotNoCluster
	hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/3/artifact/out/Dockerfile
GITHUB PR	#1084
JIRA Issue	HBASE-23330
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 196d16ec350d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1084/out/precommit/personality/provided.sh
git revision	HBASE-18095/client-locate-meta-no-zookeeper / `62da419`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/3/artifact/out/patch-unit-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/3/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/3/testReport/
Max. process+thread count	5671 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server hbase-mapreduce hbase-thrift U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1084/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Andrew Purtell <apurtell@apache.org>

) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit fcb2012)

Signed-off-by: Andrew Purtell <apurtell@apache.org>

) Signed-off-by: Andrew Purtell <apurtell@apache.org>

Signed-off-by: Andrew Purtell <apurtell@apache.org>

) Signed-off-by: Andrew Purtell <apurtell@apache.org>

Signed-off-by: Andrew Purtell <apurtell@apache.org>

) Signed-off-by: Andrew Purtell <apurtell@apache.org>

) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit d8b3f55)

…4598) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit d8b3f55) Co-authored-by: Bharath Vissapragada <bharathv@apache.org>

) (apache#4598) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit d8b3f55) Co-authored-by: Bharath Vissapragada <bharathv@apache.org> (cherry picked from commit 2cd30e5) Change-Id: I19f257814bd6a27582d6a611c5b9ab1d2a3db463

…pache#1084) (apache#4598)" CDPD-43278 Compilation failure after HBASE-23330 in downstream components This reverts commit 538bb0f. Change-Id: I49654d9bc189bf8023b476ab429493af1a092ab6

) (apache#4598) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit d8b3f55) Co-authored-by: Bharath Vissapragada <bharathv@apache.org> (cherry picked from commit 2cd30e5) Change-Id: I7cf85b4b611c71b0e87d0b23a1f85542e912e197

bharathv force-pushed the HBASE-23330-2 branch from b6e02e5 to 54febefCompare January 23, 2020 18:54

apurtell approved these changes Jan 24, 2020
View reviewed changes

asfgit force-pushed the HBASE-18095/client-locate-meta-no-zookeeper branch from d9bb034 to 62da419Compare January 24, 2020 17:44

bharathv added 2 commits January 24, 2020 11:37

HBASE-23330: Fix delegation token fetch with MasterRegistry
c5fe977

Thrift gen-java
185dfa4
Updated thrift generated java code. Putting in a separate commit for easy reviewing of the core patch.

bharathv force-pushed the HBASE-23330-2 branch from 54febef to 185dfa4Compare January 24, 2020 21:19

apurtell merged commit 39ff6f8 into apache:HBASE-18095/client-locate-meta-no-zookeeperJan 25, 2020

asfgit pushed a commit that referenced this pull request Jan 29, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
5a94f84
Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request Jan 29, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
f1145f5
Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request Jan 30, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
fcb2012
Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit to bharathv/hbase that referenced this pull request Feb 2, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
a4b287e
) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit fcb2012)

asfgit pushed a commit that referenced this pull request Feb 3, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
0309968
Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request Feb 4, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
c17f772
Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request Feb 5, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
2bf4444
Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request Feb 5, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
0033b1b
Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit that referenced this pull request Feb 9, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
38b9a4d
Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit that referenced this pull request Feb 11, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
7780f52
Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit that referenced this pull request Feb 13, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
56e52ac
Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit to bharathv/hbase that referenced this pull request Feb 14, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
62ae6bf
) Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit to bharathv/hbase that referenced this pull request Feb 17, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
a7cd668
) Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit that referenced this pull request Feb 18, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
92ad240
Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit to bharathv/hbase that referenced this pull request Feb 20, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
2612bc6
) Signed-off-by: Andrew Purtell <apurtell@apache.org>

bharathv added a commit that referenced this pull request Feb 20, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (#1084)
d8b3f55
Signed-off-by: Andrew Purtell <apurtell@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
8cbece3
) Signed-off-by: Andrew Purtell <apurtell@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
ea39e0b
) Signed-off-by: Andrew Purtell <apurtell@apache.org>

Apache9 pushed a commit to Apache9/hbase that referenced this pull request Jul 5, 2022
HBASE-23330: Fix delegation token fetch with MasterRegistry (apache#1084
3d00a63
) Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit d8b3f55)

Navigation Menu

Uh oh!

HBASE-23330: Fix delegation token fetch with MasterRegistry - #1084

HBASE-23330: Fix delegation token fetch with MasterRegistry#1084
apurtell merged 2 commits into
apache:HBASE-18095/client-locate-meta-no-zookeeperfrom
bharathv:HBASE-23330-2

bharathv commented Jan 23, 2020

Uh oh!

Apache-HBase commented Jan 23, 2020

Uh oh!

apurtell commented Jan 23, 2020

Uh oh!

Apache-HBase commented Jan 23, 2020

Uh oh!

apurtell commented Jan 24, 2020

Uh oh!

apurtell commented Jan 24, 2020

Uh oh!

bharathv commented Jan 24, 2020

Uh oh!

apurtell commented Jan 25, 2020

Uh oh!

Apache-HBase commented Jan 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bharathv commented Jan 23, 2020

Uh oh!

Apache-HBase commented Jan 23, 2020

Uh oh!

apurtell commented Jan 23, 2020

Uh oh!

Apache-HBase commented Jan 23, 2020

Uh oh!

apurtell commented Jan 24, 2020

Uh oh!

apurtell commented Jan 24, 2020

Uh oh!

bharathv commented Jan 24, 2020

Uh oh!

apurtell commented Jan 25, 2020

Uh oh!

Apache-HBase commented Jan 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants