Uh oh!
There was an error while loading. Please reload this page.
HBASE-23731: De-flake TestFromClientSide - #1091
Merged
apurtell merged 1 commit intoJan 27, 2020
Merged
Conversation
Apache-HBase
commented
Jan 27, 2020
💔 -1 overall
This message was automatically generated. |
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Some nits in below.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Jan 27, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 27, 2020
💔 -1 overall
This message was automatically generated. |
HorizonNet
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall. Left two minor NITs. As the same test is failing twice in QA: Is it related to these changes?
Uh oh!
There was an error while loading. Please reload this page.
bharathv
commented
Jan 27, 2020
bharathv
left a comment
ContributorAuthor
There was a problem hiding this comment.
As the same test is failing twice in QA: Is it related to these changes?
I think the test is generally flakey on master. It already made it to the leaderboard https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/dashboard.html
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues.
saintstack
approved these changes
Jan 27, 2020
saintstack
commented
Jan 27, 2020
Contributor
+1'd it. Check out the @HorizonNet comment. This goes to the branch only? |
bharathv
commented
Jan 27, 2020
ContributorAuthor
Thanks for the quick review @saintstack.
|
HorizonNet
approved these changes
Jan 27, 2020
Apache-HBase
commented
Jan 27, 2020
💔 -1 overall
This message was automatically generated. |
asfgit pushed a commit
that referenced
this pull request
Jan 29, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
asfgit pushed a commit
that referenced
this pull request
Jan 29, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
asfgit pushed a commit
that referenced
this pull request
Jan 30, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 2, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 60cb4f3)
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 2, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 60cb4f3)
asfgit pushed a commit
that referenced
this pull request
Feb 3, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
asfgit pushed a commit
that referenced
this pull request
Feb 4, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
asfgit pushed a commit
that referenced
this pull request
Feb 5, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
asfgit pushed a commit
that referenced
this pull request
Feb 5, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
that referenced
this pull request
Feb 9, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
that referenced
this pull request
Feb 11, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
that referenced
this pull request
Feb 13, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 14, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 17, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
that referenced
this pull request
Feb 18, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 20, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
that referenced
this pull request
Feb 20, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 23, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 5c88672)
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 24, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 5c88672)
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 25, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 5c88672)
bharathv added a commit
to bharathv/hbase
that referenced
this pull request
Feb 26, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 5c88672)
bharathv added a commit
that referenced
this pull request
Feb 27, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> (cherry picked from commit 5c88672)
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <stack@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a couple of issues.
There was a leak of a file descriptor for hbck lock file. This
was contributing to all the "ConnectionRefused" stack traces since
it was trying to renew lease for an already expired mini dfs cluster.
This issue was there for a while, just that we noticed it now.
After upgrade to JUnit 4.13, it looks like the behavior for test
timeouts has changed. Earlier the timeout seems to have applied for
each parameterized run, but now it looks like it is applied across
all the runs.
This patch fixes both the issues.