Skip to content

HBASE-23281: Track meta region locations in masters (#830) - #1097

Closed
bharathv wants to merge 3 commits into
apache:branch-2from
bharathv:HBASE-23281-branch-2
Closed

HBASE-23281: Track meta region locations in masters (#830)#1097
bharathv wants to merge 3 commits into
apache:branch-2from
bharathv:HBASE-23281-branch-2

Conversation

@bharathv

Copy link
Copy Markdown
Contributor

This patch adds a simple cache that tracks the meta region replica
locations. It keeps an eye on the region movements so that the
cached locations are not stale.

This information is used for servicing client RPCs for connections
that use master based registry (HBASE-18095). The RPC end points
will be added in a separate patch.

This patch implements a simple cache that all the masters
can lookup to serve cluster ID to clients. Active HMaster
is still responsible for creating it but all the masters
will read it from fs to serve clients.
RPCs exposing it will come in a separate patch as a part of
HBASE-18095.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Guangxu Cheng <guangxucheng@gmail.com>
(cherry picked from commit c2e01f2)
…ache#812)
Currently we just track whether an active master exists.
It helps to also track the address of the active master in
all the masters to help serve the client RPC requests to
know which master is active.
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit efebb84)
* HBASE-23281: Track meta region changes on masters
This patch adds a simple cache that tracks the meta region replica
locations. It keeps an eye on the region movements so that the
cached locations are not stale.
This information is used for servicing client RPCs for connections
that use master based registry (HBASE-18095). The RPC end points
will be added in a separate patch.
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8571d38)
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 18 new or modified test files.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall6m 58sbranch-2 passed
+1 💚compile1m 56sbranch-2 passed
+1 💚checkstyle2m 28sbranch-2 passed
+1 💚shadedjars4m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20sbranch-2 passed
+0 🆗spotbugs0m 44sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs6m 30sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall6m 32sthe patch passed
+1 💚compile1m 57sthe patch passed
+1 💚javac1m 57sthe patch passed
+1 💚checkstyle0m 42sThe patch passed checkstyle in hbase-client
+1 💚checkstyle0m 14sThe patch passed checkstyle in hbase-zookeeper
+1 💚checkstyle1m 25shbase-server: The patch generated 0 new + 114 unchanged - 6 fixed = 114 total (was 120)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck20m 30sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc1m 28sthe patch passed
+1 💚findbugs6m 26sthe patch passed
_ Other Tests _
+1 💚unit4m 4shbase-client in the patch passed.
+1 💚unit0m 54shbase-zookeeper in the patch passed.
+1 💚unit167m 33shbase-server in the patch passed.
+1 💚asflicense1m 37sThe patch does not generate ASF License warnings.
253m 46s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1097/1/artifact/out/Dockerfile
GITHUB PR#1097
JIRA IssueHBASE-23281
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 893a96afaca9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1097/out/precommit/personality/provided.sh
git revisionbranch-2 / e0f9133
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1097/1/testReport/
Max. process+thread count4812 (vs. ulimit of 10000)
modulesC: hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1097/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this but seems some of the delta in this one I just reviewed on another PR. Might have a merge conflict.

@bharathv

Copy link
Copy Markdown
ContributorAuthor

Will be merged as a part of #1098

@bharathv
bharathv deleted the HBASE-23281-branch-2 branch January 29, 2020 00:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bharathv@Apache-HBase@apurtell