Skip to content

Revert "HBASE-23304: RPCs needed for client meta information lookup (… - #1119

Merged
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:revert-pull-1098-branch-2
Feb 5, 2020
Merged

Revert "HBASE-23304: RPCs needed for client meta information lookup (…#1119
ndimiduk merged 1 commit into
apache:branch-2from
ndimiduk:revert-pull-1098-branch-2

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

#904) (#1098)"

This reverts commit 71f0354.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

FYI @bharathv@apurtell

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 18 new or modified test files.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 30sbranch-2 passed
+1 💚compile2m 26sbranch-2 passed
+1 💚checkstyle2m 17sbranch-2 passed
+1 💚shadedjars4m 26sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32sbranch-2 passed
+0 🆗spotbugs0m 38sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs8m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
-1 ❌mvninstall2m 49sroot in the patch failed.
-1 ❌compile0m 55shbase-server in the patch failed.
-1 ❌cc0m 55shbase-server in the patch failed.
-1 ❌javac0m 55shbase-server in the patch failed.
-1 ❌checkstyle0m 36shbase-client: The patch generated 1 new + 194 unchanged - 0 fixed = 195 total (was 194)
-1 ❌checkstyle1m 8shbase-server: The patch generated 13 new + 119 unchanged - 0 fixed = 132 total (was 119)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌shadedjars3m 34spatch has 36 errors when building our shaded downstream artifacts.
-1 ❌hadoopcheck2m 5sThe patch causes 36 errors with Hadoop v2.8.5.
-1 ❌hadoopcheck4m 35sThe patch causes 36 errors with Hadoop v2.9.2.
-1 ❌hadoopcheck7m 31sThe patch causes 36 errors with Hadoop v3.1.2.
-1 ❌hbaseprotoc0m 55shbase-server in the patch failed.
+1 💚javadoc1m 35sthe patch passed
-1 ❌findbugs1m 1shbase-server in the patch failed.
_ Other Tests _
+1 💚unit0m 50shbase-protocol-shaded in the patch passed.
+1 💚unit4m 3shbase-client in the patch passed.
+1 💚unit0m 53shbase-zookeeper in the patch passed.
-1 ❌unit1m 5shbase-server in the patch failed.
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
64m 49s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/Dockerfile
GITHUB PR#1119
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 2d3305e3a61c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1119/out/precommit/personality/provided.sh
git revisionbranch-2 / 12f4e09
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-compile-hbase-server.txt
cchttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-compile-hbase-server.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-compile-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-javac-3.1.2.txt
hbaseprotochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-hbaseprotoc-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-findbugs-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/testReport/
Max. process+thread count283 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimidukforce-pushed the revert-pull-1098-branch-2 branch from 9a66604 to 9990c54CompareFebruary 3, 2020 22:56
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 12s#1119 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/2/console
versionsgit=2.17.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@bharathv

Copy link
Copy Markdown
Contributor

+1 subject to a clean QA build. Thanks for the revert.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 19 new or modified test files.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 47sbranch-2 passed
+1 💚compile2m 23sbranch-2 passed
+1 💚checkstyle2m 17sbranch-2 passed
+1 💚shadedjars4m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 26sbranch-2 passed
+0 🆗spotbugs0m 34sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs8m 11sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 21sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚cc2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
-1 ❌checkstyle0m 37shbase-client: The patch generated 1 new + 194 unchanged - 0 fixed = 195 total (was 194)
-1 ❌checkstyle1m 14shbase-server: The patch generated 13 new + 119 unchanged - 0 fixed = 132 total (was 119)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck17m 4sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚hbaseprotoc2m 12sthe patch passed
+1 💚javadoc1m 27sthe patch passed
+1 💚findbugs8m 27sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
+1 💚unit3m 32shbase-client in the patch passed.
+1 💚unit0m 48shbase-zookeeper in the patch passed.
+1 💚unit155m 2shbase-server in the patch passed.
+1 💚asflicense1m 32sThe patch does not generate ASF License warnings.
239m 20s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/3/artifact/out/Dockerfile
GITHUB PR#1119
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux b1f1ac2279cb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1119/out/precommit/personality/provided.sh
git revisionbranch-2 / 12f4e09
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/3/artifact/out/diff-checkstyle-hbase-client.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/3/artifact/out/diff-checkstyle-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/3/testReport/
Max. process+thread count4979 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1119/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit bb8d9df into apache:branch-2Feb 5, 2020
@ndimiduk
ndimiduk deleted the revert-pull-1098-branch-2 branch February 5, 2020 00:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@bharathv